Re: We need to remove exec_program() from our Cmake files

2023-10-28 Thread Milian Wolff
ttps://cmake.org/cmake/help/latest/module/FindPkgConfig.html -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: RFC: an improved ki18n_install

2023-03-07 Thread Milian Wolff
On Dienstag, 7. März 2023 02:51:06 CET Aleix Pol wrote: > On Mon, Mar 6, 2023 at 8:31 PM Milian Wolff wrote: > > Hey all, > > > > for context please see [1] and [2]. > > > > [1]: https://bugs.kde.org/show_bug.cgi?id=460245 > > [2]: > > https://dis

Re: RFC: an improved ki18n_install

2023-03-07 Thread Milian Wolff
On Dienstag, 7. März 2023 00:30:20 CET Albert Astals Cid wrote: > El dilluns, 6 de març de 2023, a les 20:31:01 (CET), Milian Wolff va escriure: > > Hey all, > > > > for context please see [1] and [2]. > > > > [1]: https://bugs.kde.org/show_bug

RFC: an improved ki18n_install

2023-03-06 Thread Milian Wolff
y. What do others say to this approach? Thanks -- Milian Wolff http://milianw.de

Re: New santizer warning in KF 5.98 headers

2023-01-11 Thread Milian Wolff
On Mittwoch, 11. Januar 2023 11:26:42 CET Ingo Klöcker wrote: > On Mittwoch, 11. Januar 2023 11:02:04 CET Milian Wolff wrote: > > On Dienstag, 10. Januar 2023 23:45:26 CET Michael Reeves wrote: > > > Thanks. I would say your right there this would definitely have caught > &g

Re: New santizer warning in KF 5.98 headers

2023-01-11 Thread Milian Wolff
the code is clearly wrong and it's unclear what it's trying to achieve here. Does anyone know what this is trying to do? Qt::ConnectionType connectionType = static_cast(-1) Should this maybe just be changed to use Qt::AutoConnection? Thanks -- Milian Wolff m...@milianw.de http://milianw.de sign

Re: State of server-side retrace of KDE crashes?

2021-12-17 Thread Milian Wolff
the binary that is run. Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: New repo in kdereview: kalk

2021-02-19 Thread Milian Wolff
9 = > it tells me the result is 63. > > Compare to kcalc that properly tells me 65. > > You can't really use C/C++ floating point to do actual math, it's not very > good for that, you need to use "infinite" precision numbers like kcalc > does. > > Please r

Re: Retiring

2021-01-13 Thread Milian Wolff
leaving - may the same happen to you ;-) I.e.: Take your well earned break and come back whenever it suites you again! Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Milian Wolff
On Montag, 19. Oktober 2020 17:21:28 CEST Harald Sitter wrote: > On 19.10.20 17:06, Milian Wolff wrote: > > On Montag, 19. Oktober 2020 16:56:27 CEST Harald Sitter wrote: > >> On 19.10.20 12:30, Milian Wolff wrote: > >>> On Montag, 19. Oktober 2020 11:27:29 CEST

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Milian Wolff
On Montag, 19. Oktober 2020 13:33:38 CEST Christophe Giboudeaux wrote: > On lundi 19 octobre 2020 12:30:59 CEST Milian Wolff wrote: > > On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: > > > Yo > > > > > > On 18.10.20 10:11,

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Milian Wolff
On Montag, 19. Oktober 2020 16:56:27 CEST Harald Sitter wrote: > On 19.10.20 12:30, Milian Wolff wrote: > > On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: > >> Yo > >> > >> On 18.10.20 10:11, Milian Wolff wrote: > >>> Hey all, >

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Milian Wolff
On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: > Yo > > On 18.10.20 10:11, Milian Wolff wrote: > > Hey all, > > > > since some time now I'm only compiling parts of KF5 selectively into a > > custom prefix. Most notably, I'm only interes

CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-18 Thread Milian Wolff
missing which would prevent this? I am hoping that any folder works as long as it's listed in the `XDG_DATA_DIRS` env var - can someone confirm this? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: KPluginLoader UBSAN warnings (object has invalid vptr)

2020-10-17 Thread Milian Wolff
On Samstag, 17. Oktober 2020 00:16:01 CEST Thiago Macieira wrote: > On Thursday, 15 October 2020 07:22:59 PDT Milian Wolff wrote: > > I have the feeling that this might be a limitation of UBSAN? Or is this an > > actual problem - does anyone know? > > I've seen simil

KPluginLoader UBSAN warnings (object has invalid vptr)

2020-10-15 Thread Milian Wolff
rceFormatter ``` Maybe that's the problem? Does anyone know? -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: KDiagram - Persistent FTBFS for stable branch on Windows

2020-10-12 Thread Milian Wolff
On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: > On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff wrote: > > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: > > > Hi KDiagram Developers, > > > > > > The stable branch of KDiagram ha

Re: KDiagram - Persistent FTBFS for stable branch on Windows

2020-10-12 Thread Milian Wolff
tly for the following projects: > - KStars > - Konversation > - Skrooge > - Okteta > - KDiff3 > - Alkimia > - KMyMoney > - KRename -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

kdesrc-build messes with environment

2019-04-24 Thread Milian Wolff
this could come from? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Welcome CuteHMI

2019-04-15 Thread Milian Wolff
res through JavaScript... I > wish the project wasn't dead, but I try to hang on and not cry :P "all build systems suck", don't bother too much about it ;-) -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Phabricator: How to get the email address of contributors?

2018-01-04 Thread Milian Wolff
ave not necessarily consented to having > their email address made public > > It isn't "bad" software, it just happens to have a workflow weakness > when Arcanist isn't used (which upstream strongly recommend). Yes, one of many workflow weaknesses and I've raised my concerns ab

Re: Recommended modesetting driver for Intel graphic cards

2017-11-20 Thread Milian Wolff
On Montag, 20. November 2017 23:40:38 CET Milian Wolff wrote: > On Montag, 20. November 2017 17:28:06 CET Martin Flöser wrote: > > Am 2017-11-20 11:59, schrieb Milian Wolff: > > > On Samstag, 18. November 2017 15:34:16 CET Friedrich W. H. Kossebau > > > > >

Re: Recommended modesetting driver for Intel graphic cards

2017-11-20 Thread Milian Wolff
On Montag, 20. November 2017 17:28:06 CET Martin Flöser wrote: > Am 2017-11-20 11:59, schrieb Milian Wolff: > > On Samstag, 18. November 2017 15:34:16 CET Friedrich W. H. Kossebau > > > > wrote: > >> Am Donnerstag, 16. November 2017, 23:24:52 CET schrieb Ingo

Re: Recommended modesetting driver for Intel graphic cards (was: Re: liquidshell in kdereview)

2017-11-20 Thread Milian Wolff
e xf86ConfigLayout > [12.125] (II) LoadModule: "intel" > [12.127] (WW) Warning, couldn't open module intel > [12.127] (II) UnloadModule: "intel" > [12.127] (II) Unloading intel > [12.127] (EE) Failed to load module "intel" (module does not exist, 0) > [12.127] (II) LoadModule: "modesetting" > [12.127] (II) Loading /usr/lib64/xorg/modules/drivers/modesetting_drv.so I've also recently come across this. According to [1] the performance is supposedly much worse. Is this still true for more recent mesa/kernel versions? [1]: https://www.phoronix.com/scan.php?page=news_item=Intel-DDX-May-Tests Thanks, I'll have to try this out -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: How to install icons for multiple themes

2017-04-20 Thread Milian Wolff
On Donnerstag, 20. April 2017 11:34:39 CEST Matthias Klumpp wrote: > 2017-04-20 11:30 GMT+02:00 Milian Wolff <m...@milianw.de>: > > [...] > > Hey Albert, > > > > sorry for the delay and thanks for the response. The above makes me wonder > > about

Re: How to install icons for multiple themes

2017-04-20 Thread Milian Wolff
On Montag, 17. April 2017 23:36:24 CEST Albert Astals Cid wrote: > El dilluns, 17 d’abril de 2017, a les 22:27:15 CEST, Milian Wolff va escriure: > > Hey all, > > > > how is one supposed to install different versions of icons for different > > icon themes? Say I have

How to install icons for multiple themes

2017-04-17 Thread Milian Wolff
subsystem? Is this in ECM? Am I missing some environment variable? Any help would be appreciated, thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-27 Thread Milian Wolff
tps://git.reviewboard.kde.org/r/128949/#comment66982> unrelated to the actual change set here, someone should cleanup this file to use Q_UNUSED instead of manually casting to void. - Milian Wolff On Sept. 22, 2016, 7:24 p.m., Pascal VITOUX

Re: Solved: missing dependencies when compiling with Ninja generator

2016-09-21 Thread Milian Wolff
ake until you get 3.6.0+. > Maybe packagers want to backport the fix. I see that Ubuntu Yakkety is > going to ship CMake 3.5.2. Great, looking into that has long been on my TODO. Glad to hear a confirmation that this got properly fixed now. Thanks -- Milian Wolff m...@milianw.de http:

Re: Policy regarding QtWebKit and QtScript

2015-12-25 Thread Milian Wolff
pile" and argument for or against a piece of software if there is no feature equivalent alternative that takes less time to compile? Qt WebEngine is far easier to compile than Qt WebKit in my experience, and it certainly doesn't take significantly longer. And of course the former is far

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-28 Thread Milian Wolff
On Montag, 28. September 2015 23:10:33 CEST Albert Astals Cid wrote: > El Dilluns, 28 de setembre de 2015, a les 16:41:58, Milian Wolff va escriure: > > On Friday, September 25, 2015 11:35:35 PM CEST Albert Astals Cid wrote: > > > El Divendres, 25 de setembre de 2015, a les 05:1

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-28 Thread Milian Wolff
On Friday, September 25, 2015 11:35:35 PM CEST Albert Astals Cid wrote: > El Divendres, 25 de setembre de 2015, a les 05:15:35, Milian Wolff va > > escriure: > > On Montag, 21. September 2015 20:29:32 CEST Albert Astals Cid wrote: > > > El Dijous, 10 de setembre de 2015

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-24 Thread Milian Wolff
combined with ASan and should thus find even more issues in our codebase! Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: [Development] Please help me get my pending review count down

2015-07-31 Thread Milian Wolff
to copy'n'paste and you can pull the changeset and test it. That's much better than manually applying some plaintext diff. Bye -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbHCo KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-30 Thread Milian Wolff
On Thursday, July 30, 2015 09:23:00 PM Mark Gaiser wrote: On Tue, Jul 28, 2015 at 4:28 PM, David Faure fa...@kde.org wrote: On Tuesday 14 July 2015 19:28:58 Thomas Lübking wrote: On Dienstag, 14. Juli 2015 19:00:14 CEST, Milian Wolff wrote: On Tuesday, July 14, 2015 11:49:25 AM David

Re: 3 UDSEntry optimizations

2015-07-24 Thread Milian Wolff
figure out whether this is still applicable? Or if one wants to come up with some improvements, one needs documentation on how to do that. Mixing email, blog and commit messages is not a good idea. The commit message should be self consistent. Bye -- Milian Wolff m...@milianw.de http

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-24 Thread Milian Wolff
in the afternoon. Please let's get this done and end this painful release asap. \o/ Rock on guys, I'm a happy KF5 KDE PIM user. Let's get this beast released! -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-14 Thread Milian Wolff
on-disk meta data in the worst case, esp. on old rotary disks. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-29 Thread Milian Wolff
On Friday 26 June 2015 03:17:49 Vishesh Handa wrote: On Wed, Jun 24, 2015 at 9:52 AM, Milian Wolff m...@milianw.de wrote: Hm, so maybe related to https://git.reviewboard.kde.org/r/124128/ ? Vishesh, did you also see similar freezes? I didn't actually get the freezes, but David Edmunson

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-24 Thread Milian Wolff
On Wednesday 24 June 2015 00:39:30 Andreas Hartmetz wrote: On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: Hey all, in massif-visualizer's framework branch, and now also kate, I sometimes notice GUI lockups when I try to open files via Ctrl + O. The backtraces look like

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-14 Thread Milian Wolff
will still get potentially expensive sycoca rebuilding when something happens, but I'm not sure how expensive this is. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-14 Thread Milian Wolff
compiled KF5-based stuff (e.g. KDEPlatformTheme.so) with kdesrc-build compiled KF5 libraries (/home/milian/projects/kf5/*)? The applications do not recover from this lockup. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Distros and QtWebEngine

2015-04-21 Thread Milian Wolff
subject? I seem to have missed it, and also can't find it in my recent mails. Sorry for that. Thanks -- Milian Wolff m...@milianw.de http://milianw.de

Re: Distros and QtWebEngine

2015-04-21 Thread Milian Wolff
On Monday 20 April 2015 23:19:22 Luigi Toscano wrote: Milian Wolff ha scritto: I'm not a KDE PIM maintainer, but with my KDevelop hat on (that uses a web view to display documentation pages, currently QtWebKit), kio_man uses khtml (why don't you use it)? But anyway, also khtml

Re: branchGroup stable-qt4 Compile failures. Need dev assistance please.

2015-04-21 Thread Milian Wolff
in there are just historic artifacts. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Distros and QtWebEngine

2015-04-20 Thread Milian Wolff
effort than supporting different implementations. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: make uninstall

2015-02-04 Thread Milian Wolff
we'll get more homogeinity that way. This is now done (https://git.reviewboard.kde.org/r/122359/). Thank you Alex, much appreciated! -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread Milian Wolff
, this is something that kdesrc-build could automate for us. The rest of the above is independent of the actual tool. Even with reviewboard or phabricator, you'll need to know where to push your change. Bugfix? Latest stable release you want to support. New feature? dev. Bye -- Milian Wolff m

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread Milian Wolff
gerrit means using it exactly like Qt is using it! Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75164 --- Ship it! Ship It! - Milian Wolff On Jan. 31, 2015, 5:48

Re: Feature matrix for future infrastructure

2015-01-30 Thread Milian Wolff
custom human review. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Milian Wolff
so. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Milian Wolff
, I think! tl;dr; please do not rule-out Gerrit just because you don't know it (yet)! Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Milian Wolff
by running rbt post and specifing the git hash manually all in all, this makes it /much/ simpler to use than rbt. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-26 Thread Milian Wolff
/krecursivefilterproxymodel.cpp https://git.reviewboard.kde.org/r/122252/#comment51807 again, use iterators kdeui/itemviews/krecursivefilterproxymodel.cpp https://git.reviewboard.kde.org/r/122252/#comment51809 again, use iterators - Milian Wolff On Jan. 25, 2015, 6:51 p.m., David Faure wrote

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread Milian Wolff
://git.reviewboard.kde.org/r/17/#comment51801 is this still required in qt5? this should really be added upstream, imo... kdeui/tests/krecursivefilterproxymodeltest.cpp https://git.reviewboard.kde.org/r/17/#comment51803 style: { on newline? - Milian Wolff On Jan. 23, 2015, 6:11 p.m

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
important for us. snip Thanks again! -- Milian Wolff m...@milianw.de http://milianw.de

Feature matrix for future infrastructure

2015-01-23 Thread Milian Wolff
etc. pp. wherever possible. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
-build to replicate the tree structure e.g. But https://showoff.phab.io/project/ only shows a list of projects. Same for https://showoff.phab.io/diffusion/. I tried to create a new project and a new repository, and could not figure out how to create a tree with it. Bye -- Milian Wolff m

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
On Friday 23 January 2015 15:40:40 Ben Cooksley wrote: On Fri, Jan 23, 2015 at 3:52 AM, Milian Wolff m...@milianw.de wrote: On Wednesday 21 January 2015 17:12:07 Ben Cooksley wrote: Hi all, As promised in the earlier thread, i'd like to present the sysadmin report on the state

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Milian Wolff
phabricator instance could be set up such that we all can play around with the features it provides, including pushing changes and trying out arc. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Milian Wolff
to what I heard from gerrit Please correct me if I'm wrong. I only know Gerrit from its usage in Qt. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Milian Wolff
On Wednesday 21 January 2015 17:53:51 Jan Kundrát wrote: On Wednesday, 21 January 2015 15:54:52 CEST, Milian Wolff wrote: snip 9) I do not know what effort for integration with KDE Indentity you're referring to. It's a simple LDAP server, and the entire integration was trivial. It's

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-09 Thread Milian Wolff
://git.reviewboard.kde.org/r/121930/#comment51245 just add that to the conditional above, no need to duplicate it here. sorry that I didn't spot this sooner - Milian Wolff On Jan. 9, 2015, 2:19 p.m., René J.V. Bertin wrote

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Milian Wolff
and it works, and Allan has no objections, that you can go ahead and push this. but please don't comment out code, just remove it. kdecore/util/kshareddatacache_p.h https://git.reviewboard.kde.org/r/121930/#comment51185 remove dead code - Milian Wolff On Jan. 8, 2015, 5:09 p.m., René J.V

Re: Changes to our Git infrastructure

2015-01-05 Thread Milian Wolff
on the important aspects first, the admins would have less work and most people are still happy. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Changes to our Git infrastructure

2015-01-05 Thread Milian Wolff
about the cli tools for developers, i.e. what currently is rbt tools. You, otoh, speak about the server-side tools, which of course can be written in any language you are willing to install on the server side. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Changes to our Git infrastructure

2015-01-05 Thread Milian Wolff
, I also fail to see the issue here. PHP is 15.23MiB on my Arch box. Compare that with 34M of karchive build dir when you enable debug symbols (and karchive is small!). Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Changes to our Git infrastructure

2014-12-27 Thread Milian Wolff
On Saturday 27 December 2014 12:56:27 Jan Kundrát wrote: On Tuesday, 23 December 2014 13:21:37 CEST, Milian Wolff wrote: Furthermore, I'd like to use the same review mechanism for post-review. When a patch is triggering problems, I'd like to start a discussion in the context

Re: Changes to branch management

2014-12-23 Thread Milian Wolff
be a nuisance if someone would delete one of our stable branches, but deleting one of the release tags would be ugly as I'd then need to figure out what commit was chosen for what release. Bye and thanks for your continuous work Ben, much appreciated! Take care. -- Milian Wolff m...@milianw.de http

Re: [Kde-pim] Problems with infrastructure

2014-12-15 Thread Milian Wolff
sets and then pushing them to an alias remote. Then I can fix them up and/or rebase and push again to update everything. With reviewboard, I'd need to manually push each individual patch, and updating them is again as much work. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: ThreadWeaver: using QObject's as Jobs

2014-11-25 Thread Milian Wolff
On Monday 24 November 2014 23:00:45 Mirko Boehm wrote: Hi Milian! Man, I totally thought this is absolutely intuitive :-) I will write something up as a blog post over the weekend. In the meantime, I am trying to answer your question below. On 24 Nov 2014, at 01:57, Milian Wolff m

Re: Triggering rebuild after changing a *.json file

2014-11-23 Thread Milian Wolff
On Sunday 23 November 2014 10:39:02 Andreas Pakulat wrote: Hi, On Sun, Nov 23, 2014 at 4:36 AM, Milian Wolff m...@milianw.de wrote: Hey all, in my quest for better *.json support in KF5 based applications, I noticed that we currently do not rebuild properly on changes to the *.desktop

Re: Triggering rebuild after changing a *.json file

2014-11-23 Thread Milian Wolff
On Sunday 23 November 2014 23:37:45 Kevin Funk wrote: On Sunday 23 November 2014 17:54:21 Milian Wolff wrote: On Sunday 23 November 2014 10:39:02 Andreas Pakulat wrote: Hi, On Sun, Nov 23, 2014 at 4:36 AM, Milian Wolff m...@milianw.de wrote: Hey all, in my quest

ThreadWeaver: using QObject's as Jobs

2014-11-23 Thread Milian Wolff
job. But what if my job already is a QObject, since it has its own signals that it emits when data is received? Can I inherit from QObjectDecorator and pass this as the JobInterface *decoratee? Bye -- Milian Wolff m...@milianw.de http://milianw.de

Q_PLUGIN_METADATA for KDE plugins?

2014-11-22 Thread Milian Wolff
Hey all, do we also need Q_PLUGIN_METADATA for plugins of, say, Kate or KDevelop? Currently we don't use it and it seems to work fine. Can someone shed some light on this? Are we missing out on something? Thanks -- Milian Wolff m...@milianw.de http://milianw.de

Re: Q_PLUGIN_METADATA for KDE plugins?

2014-11-22 Thread Milian Wolff
On Sunday 23 November 2014 03:53:57 Milian Wolff wrote: Hey all, do we also need Q_PLUGIN_METADATA for plugins of, say, Kate or KDevelop? Currently we don't use it and it seems to work fine. Can someone shed some light on this? Are we missing out on something? Sigh, I'm tired apparently. We

Triggering rebuild after changing a *.json file

2014-11-22 Thread Milian Wolff
and a reconfigure is triggered, which is pretty slow as well. But nothing is rebuilt. With the macro above, I trigger the build but still, the *.o file that uses K_PLUGIN_FACTORY_WITH_JSON is still containing the old strings... I'm at loss - can someone help me please? Thanks -- Milian Wolff m

Re: desktoptojson and list properties / i18n of JSON files

2014-11-20 Thread Milian Wolff
your list over the weekend. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-19 Thread Milian Wolff
_DEFAULT_SOURCE Diffs - cmake/modules/FindKDE4Internal.cmake 134d14f11706f5a19a9b5e069119add2ea498dde Diff: https://git.reviewboard.kde.org/r/121147/diff/ Testing --- warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 which did the same. Thanks, Milian Wolff

Re: desktoptojson and list properties / i18n of JSON files

2014-11-19 Thread Milian Wolff
files. Please check the above. Anyhow, imo it should be our goal to get this supported. In the ideal scenario, a plugin would be just a .so installed into the right directory. No .desktop, no sycoca cache. So again, what is necessary to get this done? Bye -- Milian Wolff m...@milianw.de http

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write the .json files directly, i.e. can scripty/ki18n cope with them nowadays? So, any chance we can use .json directly here

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Milian Wolff
On Tuesday 18 November 2014 22:31:08 Albert Astals Cid wrote: El Dimarts, 18 de novembre de 2014, a les 14:09:00, Milian Wolff va escriure: On Tuesday 18 November 2014 12:48:42 Sebastian Kügler wrote: On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write

Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
134d14f11706f5a19a9b5e069119add2ea498dde Diff: https://git.reviewboard.kde.org/r/121147/diff/ Testing --- warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 which did the same. Thanks, Milian Wolff

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
_DEFAULT_SOURCE Diffs - cmake/modules/FindKDE4Internal.cmake 134d14f11706f5a19a9b5e069119add2ea498dde Diff: https://git.reviewboard.kde.org/r/121147/diff/ Testing --- warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 which did the same. Thanks, Milian

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- On Nov. 17, 2014, 3:29 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
134d14f11706f5a19a9b5e069119add2ea498dde Diff: https://git.reviewboard.kde.org/r/121147/diff/ Testing --- warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 which did the same. Thanks, Milian Wolff

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
/FindKDE4Internal.cmake 134d14f11706f5a19a9b5e069119add2ea498dde Diff: https://git.reviewboard.kde.org/r/121147/diff/ Testing --- warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 which did the same. Thanks, Milian Wolff

Re: desktoptojson and list properties

2014-11-17 Thread Milian Wolff
On Monday 17 November 2014 18:35:51 Sebastian Kügler wrote: On Monday, November 17, 2014 02:04:51 Aleix Pol wrote: On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff m...@milianw.de wrote: snip Fine, I could add similar code to desktoptojson, but: Since desktoptojson will be called

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Milian Wolff
/121134/#comment49264 why did you change the conditional? use int oldRefCount = s_refCount.fetchAndAddOrdered(-1) if (oldRefCount = 1 s_allowQuit) - Milian Wolff On Nov. 16, 2014, 2:12 p.m., René J.V. Bertin wrote

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Milian Wolff
/121134/#comment49267 remove this. - Milian Wolff On Nov. 16, 2014, 3:53 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Milian Wolff
On Nov. 16, 2014, 2:58 p.m., Milian Wolff wrote: as I said before: Did you check whether that is actually the case? Did you add some assertions to see what other thread is calling this code? I'm not sure whether this is supposed to be threadsafe or not. If it must be threadsafe

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Milian Wolff
On Nov. 16, 2014, 7:05 p.m., Pino Toscano wrote: kdecore/kernel/kglobal.cpp, lines 323-324 https://git.reviewboard.kde.org/r/121134/diff/3/?file=328834#file328834line323 QAtomicInt is not a POD, so it is not safe to be used this way. You rather need to use the semi-private

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Milian Wolff
/#comment49278 see above, this is just useless - remove this (also below). - Milian Wolff On Nov. 16, 2014, 7:13 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Milian Wolff
On Nov. 16, 2014, 2:58 p.m., Milian Wolff wrote: as I said before: Did you check whether that is actually the case? Did you add some assertions to see what other thread is calling this code? I'm not sure whether this is supposed to be threadsafe or not. If it must be threadsafe

desktoptojson and list properties

2014-11-16 Thread Milian Wolff
the kdevelopplugin.desktop file without it being installed yet? Or can we nowadays write the .json files directly, i.e. can scripty/ki18n cope with them nowadays? Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: desktoptojson and list properties

2014-11-16 Thread Milian Wolff
On Sunday 16 November 2014 23:52:25 Milian Wolff wrote: Hello all! KDevelop is currently bitten hard by a bug/limitation in desktoptojson. It does not actually understand the .desktop files and custom properties get converted to plain JSON strings. Looking at the sources it's also clear why

_BSD_SOURCE and _GNU_SOURCE

2014-11-14 Thread Milian Wolff
and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE Why do we defined _BSD_SOURCE or _GNU_SOURCE in FindKDE4Internal.cmake? Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: decoration.h | [was: Review Request for KDecoration]

2014-11-06 Thread Milian Wolff
QStyleOptionViewItem? Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request for KDecoration

2014-11-04 Thread Milian Wolff
the source file probably should be tagged static. http://stackoverflow.com/questions/1358400/what-is-external-linkage-and-internal-linkage-in-c Bye -- Milian Wolff m...@milianw.de http://milianw.de

  1   2   3   >