suffers... yet another reason for refactoring.
- Ruurd Pels
On Dec. 4, 2011, 8:42 a.m., Jaime Torres Amate wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313
as moving the rest of the function in the else clause AFAICS on short
notice.
- Ruurd Pels
On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
it looks like m_service should always be initialized
beforehand, so why is it that that did not happen for that particular website.
Maybe an errormessage is in order?
- Ruurd Pels
On Nov. 17, 2011, 8:33 p.m., Dawit Alemayehu wrote
conditions always yielding true, for
example if ( xxx-isEmpty() == false) ) instead.
- Ruurd Pels
On Oct. 7, 2011, 2:13 p.m., Jaime Torres Amate wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote:
Revert the whitespace changes with git. Other than that I dislike multiple
exit points even in trivially short functions. It really does not hurt to
create a local variable holding the result of the function and then return
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102794/#review7169
---
Ship it!
Ship It!
- Ruurd Pels
On Oct. 7, 2011, 4:25 p.m
On Tuesday 26 July 2011 22.43.33 Alexander Neundorf wrote:
Should the stuff we do just be merged into the cmake version ?
Can somebody who knows more about X11 please have a look at these two
files, one in kdelibs, the other one in cmake 2.8.5 or git HEAD ?
