Re: [REVIEW]: plasma-mobile repositories

2012-03-26 Thread Aaron J. Seigo
On Friday, March 23, 2012 20:38:49 Albert Astals Cid wrote:
 Problems i found in a few seconds with a grep

i've fixed these now in the master branch. please let me know if you find 
additional issues. thanks.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.


Re: [REVIEW]: plasma-mobile repositories

2012-03-26 Thread Albert Astals Cid
El Dilluns, 26 de març de 2012, a les 12:32:37, Aaron J. Seigo va escriure:
 On Friday, March 23, 2012 20:38:49 Albert Astals Cid wrote:
  Problems i found in a few seconds with a grep
 
 i've fixed these now in the master branch. please let me know if you find
 additional issues. thanks.

Have you check that your catalogs are loaded? I don't find any reference to 
libmobilecomponentsplugin other than the one in the Messages.sh file.

Albert


Re: [REVIEW]: plasma-mobile repositories

2012-03-26 Thread Albert Astals Cid
El Divendres, 23 de març de 2012, a les 12:01:04, Aaron J. Seigo va escriure:
 hi everyone ...
 
 the repositories holding the Plasma Active code have been moved into
 kdereview as plasma-mobile and plasma-mobile-config so as to go through the
 usual 2 week review period before moving to their permanent home.

Lamarque says plasma-mobile-config is still Work In Progress stuff. Please 
move it back to some playground.

Albert

 
 if there are any question or queries, input or feedback, please don't
 hesitate
 :)


Re: [REVIEW]: plasma-mobile repositories

2012-03-26 Thread Lamarque V. Souza
Em Monday 26 March 2012, Albert Astals Cid escreveu:
 El Divendres, 23 de març de 2012, a les 12:01:04, Aaron J. Seigo va 
escriure:
  hi everyone ...
  
  the repositories holding the Plasma Active code have been moved into
  kdereview as plasma-mobile and plasma-mobile-config so as to go through
  the usual 2 week review period before moving to their permanent home.
 
 Lamarque says plasma-mobile-config is still Work In Progress stuff. Please
 move it back to some playground.

Hey, I wrote work in progress in the sense that no Plasma Active 
image 
ships with it yet. I do not see why withdraw the review request for it. It is 
includes only configuration files. There is no compiled code, not even QML 
code, in it.
 
 Albert
 
  if there are any question or queries, input or feedback, please don't
  hesitate
  
  :)


-- 
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br


Re: [REVIEW]: plasma-mobile repositories

2012-03-26 Thread Aaron J. Seigo
On Monday, March 26, 2012 20:43:29 Albert Astals Cid wrote:
 Lamarque says plasma-mobile-config is still Work In Progress stuff. Please

plasma-mobile-config is the exact same content as in plasma-mobile/config. it 
is 
broken out into its own repository so that:

* per-device branches for configuration can be easily maintained

* a build system (or rather, install system since nothing is actually built) 
can be put in place without hosing people's systems (which would be the case 
if a build system was added to plasma-mobile/config and then built on/for e.g. 
a desktop system)

as Lamarque replied, it's only a WIP in that none of our device images use it 
yet. that's also why there is still plasma-mobile/config. as soon our OBS 
projects shift from using plasma-mobile/config (it gets put into its own 
tarball and package already) to the plasma-mobile-config repo then plasma-
mobile/config will go away.

so .. no, i won't move it to playground because it is not playground material.

cheers ...

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.


[REVIEW]: plasma-mobile repositories

2012-03-23 Thread Aaron J. Seigo
hi everyone ...

the repositories holding the Plasma Active code have been moved into kdereview 
as plasma-mobile and plasma-mobile-config so as to go through the usual 2 week 
review period before moving to their permanent home.

if there are any question or queries, input or feedback, please don't hesitate 
:)

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.


Re: [REVIEW]: plasma-mobile repositories

2012-03-23 Thread Albert Astals Cid
El Divendres, 23 de març de 2012, a les 12:01:04, Aaron J. Seigo va escriure:
 hi everyone ...
 
 the repositories holding the Plasma Active code have been moved into
 kdereview as plasma-mobile and plasma-mobile-config so as to go through the
 usual 2 week review period before moving to their permanent home.
 
 if there are any question or queries, input or feedback, please don't
 hesitate
 :)

Please fix i18n :-)

Problems i found in a few seconds with a grep

shell/widgetsexplorer/kcategorizeditemsviewmodels.cpp
  has a i18n but the file doesn't seem to be extracted

shell/widgetsexplorer/plasmaappletitemmodel.cpp
  the same

components/mobilecomponents/ViewSearch.qml
  the same

And then i stopped looking, please have i18n in mind and once you think you've 
fixed it tell me again and i'll do an in depth review.

Cheers,
  Albert