Re: KDEREVIEW: share like connect and plasmate

2013-02-01 Thread Ben Cooksley
On Thu, Jan 31, 2013 at 12:47 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, January 31, 2013 10:43:29 Ben Cooksley wrote: as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate SDK and

Re: KDEREVIEW: share like connect and plasmate

2013-01-30 Thread Ben Cooksley
On Wed, Jan 30, 2013 at 11:23 PM, Giorgos Tsiapaliokas terie...@gmail.com wrote: Hello, Hi Giorgos, as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate and Share-Like-Connect headed? They are both

Re: KDEREVIEW: share like connect and plasmate

2013-01-30 Thread Aaron J. Seigo
On Thursday, January 31, 2013 10:43:29 Ben Cooksley wrote: as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate SDK and Share-Like-Connect headed? Base thanks :) -- Aaron J. Seigo

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Ben Cooksley
On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: What about Share-Like-Connect? i was waiting until i was back in the office with time to work on it again before requesting the move. :) so ... yes, SLC is ready to

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Aaron J. Seigo
On Monday, January 7, 2013 22:58:12 Ben Cooksley wrote: On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: What about Share-Like-Connect? i was waiting until i was back in the office with time to work on it again

Re: KDEREVIEW: share like connect and plasmate

2013-01-05 Thread Aaron J. Seigo
hi .. feedback was taken into consideration; fixes were made; some issues have been punted to the next release so we can practice release early, release often, make it better each release rather than release when it is perfect, namely never. please move plasmate out of kdereview so we can get

Re: KDEREVIEW: share like connect and plasmate

2013-01-05 Thread Aaron J. Seigo
On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: What about Share-Like-Connect? i was waiting until i was back in the office with time to work on it again before requesting the move. :) so ... yes, SLC is ready to be moved out of kdereview. we have it working properly on desktop as

Re: KDEREVIEW: share like connect and plasmate

2013-01-03 Thread Giorgos Tsiapaliokas
On 3 January 2013 01:51, Pino Toscano p...@kde.org wrote: - PasswordAsker sounds like could be implemented on top of KPasswordDialog we have asked in #kde-devel and we have been informed that kdialogpassword isn't a safe replacement for pinetry, so this isn't an issue.

Re: KDEREVIEW: share like connect and plasmate

2013-01-03 Thread Pino Toscano
Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: On 3 January 2013 01:51, Pino Toscano p...@kde.org wrote: - PasswordAsker sounds like could be implemented on top of KPasswordDialog we have asked in #kde-devel and we have been informed that kdialogpassword isn't a safe

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Sebastian Kügler
On Tuesday, January 01, 2013 15:39:27 Ben Cooksley wrote: On Tue, Jan 1, 2013 at 3:31 AM, Antonis Tsiapaliokas kok...@gmail.com wrote: Hello, We would like to inform you that all the above issues of the plasmate has been fixed. Can someone move it to extragear? Which project(s)

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Ben Cooksley
On Thu, Jan 3, 2013 at 7:56 AM, Sebastian Kügler se...@kde.org wrote: On Tuesday, January 01, 2013 15:39:27 Ben Cooksley wrote: On Tue, Jan 1, 2013 at 3:31 AM, Antonis Tsiapaliokas kok...@gmail.com wrote: Hello, We would like to inform you that all the above issues of the plasmate has

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Giorgos Tsiapaliokas
On 2 January 2013 23:38, Pino Toscano p...@kde.org wrote: - BranchDialog sounds like could be replaced with KInputDialog::getText with a custom validator Still there. - CommitDialog, other than being a KDialog, should better be use layouts instead of placing widgets manually Still

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Pino Toscano
Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: On 2 January 2013 23:38, Pino Toscano p...@kde.org wrote: - BranchDialog sounds like could be replaced with KInputDialog::getText with a custom validator Still there. - CommitDialog, other than being a KDialog, should

Re: KDEREVIEW: share like connect and plasmate

2013-01-01 Thread Giorgos Tsiapaliokas
On 1 January 2013 04:39, Ben Cooksley bcooks...@kde.org wrote: On Tue, Jan 1, 2013 at 3:31 AM, Antonis Tsiapaliokas kok...@gmail.com wrote: Hello, We would like to inform you that all the above issues of the plasmate has been fixed. Can someone move it to extragear? Which project(s) does

Re: KDEREVIEW: share like connect and plasmate

2012-12-31 Thread Ben Cooksley
On Tue, Jan 1, 2013 at 3:31 AM, Antonis Tsiapaliokas kok...@gmail.com wrote: Hello, We would like to inform you that all the above issues of the plasmate has been fixed. Can someone move it to extragear? Which project(s) does this concern? Also, does anyone have any final reviews to make

Re: KDEREVIEW: share like connect and plasmate

2012-12-31 Thread Antonis Tsiapaliokas
Hello, We would like to inform you that all the above issues of the plasmate has been fixed. Can someone move it to extragear? Cheers, Antonis

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Antonis Tsiapaliokas
- PasswordAsker sounds like could be implemented on top of KPasswordDialog gpgme is using pinetry-qt4 for password prompt, i don't think that we should use the KPasswordDialog.

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Pino Toscano
Alle giovedì 8 novembre 2012, Antonis Tsiapaliokas ha scritto: - PasswordAsker sounds like could be implemented on top of KPasswordDialog gpgme is using pinetry-qt4 for password prompt, i don't think that we should use the KPasswordDialog. Did you actually understand what I'm referring

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Aaron J. Seigo
On Thursday, November 8, 2012 20:06:10 Antonis Tsiapaliokas wrote: - PasswordAsker sounds like could be implemented on top of KPasswordDialog gpgme is using pinetry-qt4 for password prompt, i don't think that we should use the KPasswordDialog. gpgme does this because pinentry-qt4 is

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Antonis Tsiapaliokas
Did you actually understand what I'm referring to? I guess that we all agree that we should replace the QDialog with the KPasswordDialog (right?). If so, how can we do that? Even if someone doesn't have the pinentry-qt4, then the pinentry (CL) is opening. And i wasn't able to remove the

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Giorgos Tsiapaliokas
Hello, On 3 November 2012 19:35, Pino Toscano p...@kde.org wrote: - a numer of .ui files sets bold/bigger texts, but using a qt rich text which forces a font size (and in few cases also the font face) and which is the correct way in order to fix this? - RemoteInstaller uses

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Giorgos Tsiapaliokas
On 4 November 2012 16:55, Pino Toscano p...@kde.org wrote: - the following binaries are installed in $prefix/bin: - plasmaengineexplorer - plasmakconfigxteditor - plasmaremoteinstaller - plasmate - plasmawallpaperviewer - plasmoidviewer - remote-widgets-browser (*) -

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Hi, Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: On 3 November 2012 19:35, Pino Toscano p...@kde.org wrote: - a numer of .ui files sets bold/bigger texts, but using a qt rich text which forces a font size (and in few cases also the font face) and which is the correct

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: On 4 November 2012 16:55, Pino Toscano p...@kde.org wrote: - the following binaries are installed in $prefix/bin: - plasmaengineexplorer - plasmakconfigxteditor - plasmaremoteinstaller - plasmate -

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Albert Astals Cid
El Dijous, 1 de novembre de 2012, a les 20:06:36, Aaron J. Seigo va escriure: Hello all ... Hi This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them to their more permanent

KDEREVIEW: share like connect and plasmate

2012-11-05 Thread David Edmundson
Initial code review of Share-Like-Connect: from provider.h ~Provider(); This class is designed to be subclassed, yet the destructor is public and non virtual. The derived classes will leak everything. -- virtual QVariant executeAction(SLC::Provider::Action action, const QVariantHash

Re: KDEREVIEW: share like connect and plasmate

2012-11-04 Thread Pino Toscano
Hi, Alle sabato 3 novembre 2012, Pino Toscano ha scritto: Alle giovedì 1 novembre 2012, Aaron J. Seigo ha scritto: This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them to

Re: KDEREVIEW: share like connect and plasmate

2012-11-04 Thread Aaron J. Seigo
On Sunday, November 4, 2012 15:55:00 Pino Toscano wrote: Regarding plasmate: I fixed earlier a number of i18n issues (ugh...), and the layout of two .ui files. (A couple more today...) Thanks for your thorough review; I'll make sure the people working on Plasmate start processing your

Re: KDEREVIEW: share like connect and plasmate

2012-11-03 Thread Pino Toscano
Hi, Alle giovedì 1 novembre 2012, Aaron J. Seigo ha scritto: This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them to their more permanent homes in a couple of weeks. Most of

Re: KDEREVIEW: share like connect and plasmate

2012-11-03 Thread Kevin Krammer
On Saturday, 2012-11-03, Pino Toscano wrote: - RemoteInstaller uses /var/tmp/plasmaremoteinstaller/ as destination directory, which is a bit too generic (at least appending the user name and chmod'ing it 600 would help); also there is a race between the KIO exists and the mkdir calls I guess

KDEREVIEW: share like connect and plasmate

2012-11-01 Thread Aaron J. Seigo
Hello all ... This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them to their more permanent homes in a couple of weeks. Most of the apps in the plasmate repo have actually been