Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/#review99601
---




ksysguardd/Linux/Memory.c (line 307)


unrelated to the actual change set here, someone should cleanup this file 
to use Q_UNUSED instead of manually casting to void.


- Milian Wolff


On Sept. 22, 2016, 7:24 p.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128949/
> ---
> 
> (Updated Sept. 22, 2016, 7:24 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Add monitors for Linux memory infos dirty and writeback
> 
> A usecase can be the monitoring of datas being written to a slow storage 
> device like a USB mass storage before umounting and removing it.
> 
> 
> Diffs
> -
> 
>   ksysguardd/Linux/Memory.h 2dbd6f2 
>   ksysguardd/Linux/Memory.c 1bc3ace 
> 
> Diff: https://git.reviewboard.kde.org/r/128949/diff/
> 
> 
> Testing
> ---
> 
> Works as expected in the ksysguard GUI application (system monitor).
> Also, I use it with a plasma widget almost everyday since several months 
> without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

[Pascal VITOUX]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/
---

(Updated Sept. 22, 2016, 7:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Plasma.


Changes
---

Submitted with commit 9e44ca1112bea650a190411ee0783e60c10758e3 by David 
Edmundson on behalf of Pascal VITOUX to branch master.


Repository: ksysguard


Description
---

Add monitors for Linux memory infos dirty and writeback

A usecase can be the monitoring of datas being written to a slow storage device 
like a USB mass storage before umounting and removing it.


Diffs
-

  ksysguardd/Linux/Memory.h 2dbd6f2 
  ksysguardd/Linux/Memory.c 1bc3ace 

Diff: https://git.reviewboard.kde.org/r/128949/diff/


Testing
---

Works as expected in the ksysguard GUI application (system monitor).
Also, I use it with a plasma widget almost everyday since several months 
without issue.


Thanks,

Pascal VITOUX

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

[Pascal VITOUX]

> On sep. 22, 2016, 8:53 après-midi, David Edmundson wrote:
> > Do you have commit access?

No I don't.


- Pascal


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/#review99427
---


On sep. 22, 2016, 4:01 après-midi, Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128949/
> ---
> 
> (Updated sep. 22, 2016, 4:01 après-midi)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Add monitors for Linux memory infos dirty and writeback
> 
> A usecase can be the monitoring of datas being written to a slow storage 
> device like a USB mass storage before umounting and removing it.
> 
> 
> Diffs
> -
> 
>   ksysguardd/Linux/Memory.h 2dbd6f2 
>   ksysguardd/Linux/Memory.c 1bc3ace 
> 
> Diff: https://git.reviewboard.kde.org/r/128949/diff/
> 
> 
> Testing
> ---
> 
> Works as expected in the ksysguard GUI application (system monitor).
> Also, I use it with a plasma widget almost everyday since several months 
> without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/#review99427
---


Ship it!




Do you have commit access?

- David Edmundson


On Sept. 22, 2016, 2:01 p.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128949/
> ---
> 
> (Updated Sept. 22, 2016, 2:01 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Add monitors for Linux memory infos dirty and writeback
> 
> A usecase can be the monitoring of datas being written to a slow storage 
> device like a USB mass storage before umounting and removing it.
> 
> 
> Diffs
> -
> 
>   ksysguardd/Linux/Memory.h 2dbd6f2 
>   ksysguardd/Linux/Memory.c 1bc3ace 
> 
> Diff: https://git.reviewboard.kde.org/r/128949/diff/
> 
> 
> Testing
> ---
> 
> Works as expected in the ksysguard GUI application (system monitor).
> Also, I use it with a plasma widget almost everyday since several months 
> without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

[Pascal VITOUX]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/
---

(Updated sep. 22, 2016, 4:01 après-midi)


Review request for kde-workspace and Plasma.


Repository: ksysguard


Description
---

Add monitors for Linux memory infos dirty and writeback

A usecase can be the monitoring of datas being written to a slow storage device 
like a USB mass storage before umounting and removing it.


Diffs
-

  ksysguardd/Linux/Memory.h 2dbd6f2 
  ksysguardd/Linux/Memory.c 1bc3ace 

Diff: https://git.reviewboard.kde.org/r/128949/diff/


Testing
---

Works as expected in the ksysguard GUI application (system monitor).
Also, I use it with a plasma widget almost everyday since several months 
without issue.


Thanks,

Pascal VITOUX