Re: Banning QNetworkAccessManager

2020-02-22 Thread Johnny Jazeix
Hi, as Volker said, without any alternative, we can't just ban QNAM. And even with one, we would need time to implement it (for example, for GCompris, this part of the code was written by someone who is less active now, so rewriting it, testing it and be sure it works will take some time). Can't

Re: Banning QNetworkAccessManager

2020-02-21 Thread Ben Cooksley
On Thu, Feb 20, 2020 at 9:57 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > > On Mon, Feb 3, 2020 at 7:42 AM Volker

Re: Banning QNetworkAccessManager

2020-02-20 Thread Albert Astals Cid
El dijous, 20 de febrer de 2020, a les 14:29:47 CET, Allen Winter va escriure: > On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > > escriure: > > > Additionally, improved documentation, a possible

Re: Banning QNetworkAccessManager

2020-02-20 Thread Nicolás Alvarez
El jue., 20 de feb. de 2020 a la(s) 10:30, Allen Winter (win...@kde.org) escribió: > > On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > > escriure: > > > Additionally, improved documentation, a

Re: Banning QNetworkAccessManager

2020-02-20 Thread Allen Winter
On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > escriure: > > Additionally, improved documentation, a possible KNAM and/or driving the > > QNAM > > changes upstream can still be done alongside

Re: Banning QNetworkAccessManager

2020-02-20 Thread Volker Krause
On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > > I agree on the problem of QNAM's default,

Re: Banning QNetworkAccessManager

2020-02-19 Thread Albert Astals Cid
El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va escriure: > Additionally, improved documentation, a possible KNAM and/or driving the QNAM > changes upstream can still be done alongside this obviously. Also for Qt5 which will probably never be changed a clazy warning and

Re: Banning QNetworkAccessManager

2020-02-19 Thread Albert Astals Cid
El dimecres, 19 de febrer de 2020, a les 8:05:01 CET, Ben Cooksley va escriure: > The easiest path forward is to simply ban QNetworkAccessManager. Stop saying that, that's not going to happen. Cheers, Albert > > > > > Regards, > > Volker > > Regards, > Ben >

Re: Banning QNetworkAccessManager

2020-02-19 Thread Ben Cooksley
On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > I agree on the problem of QNAM's default, see also > > > https://conf.kde.org/en/ > > >

Re: Banning QNetworkAccessManager

2020-02-19 Thread Volker Krause
On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also > > https://conf.kde.org/en/ > > akademy2019/public/events/135 on that subject. > > > > On Saturday, 1 February 2020

Re: Banning QNetworkAccessManager

2020-02-18 Thread Ben Cooksley
On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ > akademy2019/public/events/135 on that subject. > > On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: > [...] > > Prior to now, i've taken the approach

Re: Banning QNetworkAccessManager

2020-02-06 Thread Johnny Jazeix
[...] > All of the places where we have actively hit this issue have already > been fixed (Marble and Attica come immediately to mind, not sure if > GCompris fixed their code). > I took a quick look and we use some code to handle redirection:

Re: Banning QNetworkAccessManager

2020-02-03 Thread Ben Cooksley
On Mon, Feb 3, 2020 at 11:51 PM Johan Ouwerkerk wrote: > > On Mon, Feb 3, 2020 at 11:27 AM laurent Montel wrote: > > > > Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit : > > > I updated: > > > > > > https://community.kde.org/Policies/API_to_Avoid > > > > > > Which had no mention

Re: Banning QNetworkAccessManager

2020-02-03 Thread Ben Cooksley
On Mon, Feb 3, 2020 at 10:49 PM David Edmundson wrote: > > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Many thanks for updating the wiki David. > > David Cheers, Ben

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned

Re: Banning QNetworkAccessManager

2020-02-03 Thread Johan Ouwerkerk
On Mon, Feb 3, 2020 at 11:27 AM laurent Montel wrote: > > Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit : > > I updated: > > > > https://community.kde.org/Policies/API_to_Avoid > > > > Which had no mention of this. > > > > David > > I think that you made an error > >

Re: Banning QNetworkAccessManager

2020-02-03 Thread David Edmundson
No, no. Please go the other way round and update the wiki to whatever working code you have. David

Re: Banning QNetworkAccessManager

2020-02-03 Thread laurent Montel
Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit : > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. > > David I think that you made an error "networkAccessManger->setAttribute(QNetworkRequest::FollowRedirectsAttribute, true); "

Re: Banning QNetworkAccessManager

2020-02-03 Thread David Edmundson
I updated: https://community.kde.org/Policies/API_to_Avoid Which had no mention of this. David

Re: Banning QNetworkAccessManager

2020-02-03 Thread Ben Cooksley
On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ > akademy2019/public/events/135 on that subject. > > On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: > [...] > > Prior to now, i've taken the approach

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

Banning QNetworkAccessManager

2020-02-01 Thread Ben Cooksley
Hi all, For an extremely long time now, it has been a known issue with the QNetworkAccessManager that by default it does not follow redirects as issued by the server it is accessing. This is something the Qt Project has refused to address using the justification of 'behavioural compatibility'