Re: Falkon in kdereview

[Dr.-Ing. Christoph Cullmann]

Hi,

> On Sun, Mar 25, 2018 at 11:08 PM, David Rosca  wrote:
>> On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann
>>  wrote:
>>> Hi,
>>>
>>> no objections from my side,
>>>
>>> just a note that we need to take care of the last remaining things on
>>>
>>> https://community.kde.org/Incubator/Projects/Falkon
>>>
>>> for the final incubation to be done.
>>>
>>> I think the mailing list/website stuff shouldn't be an issue to get done.
>>
>> I've requested mailing list creation, but I'm not sure about the
>> website. Does it have to be a site under kde.org (subdomain)? If yes,
>> then I'm afraid I have no idea how to proceed there. The other option
>> is to host it on my server, as is www.qupzilla.com right now.
>> For the site contents it would be enough just basic info and download
>> links, I think.
>>
> 
> Mailing list and websites are now up and running. Repository was also
> moved to extragear.
> 
> Incubation should be completed now.
I think so, too.

As said in https://phabricator.kde.org/T6857
somebody can take a final look at the manifesto compliance and we are done ;=)

Some usable web browser in our umbrella ;=) Nice!

Greetings
Christoph

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Falkon in kdereview

[David Rosca]

On Sun, Mar 25, 2018 at 11:08 PM, David Rosca  wrote:
> On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann
>  wrote:
>> Hi,
>>
>> no objections from my side,
>>
>> just a note that we need to take care of the last remaining things on
>>
>> https://community.kde.org/Incubator/Projects/Falkon
>>
>> for the final incubation to be done.
>>
>> I think the mailing list/website stuff shouldn't be an issue to get done.
>
> I've requested mailing list creation, but I'm not sure about the
> website. Does it have to be a site under kde.org (subdomain)? If yes,
> then I'm afraid I have no idea how to proceed there. The other option
> is to host it on my server, as is www.qupzilla.com right now.
> For the site contents it would be enough just basic info and download
> links, I think.
>

Mailing list and websites are now up and running. Repository was also
moved to extragear.

Incubation should be completed now.

David

>>
>> The Manifest compliance is IMHO there, licensing stuff was reviewed some 
>> weeks
>> ago if I am not mistaken.
>
> Manifest compliance is done I hope. Licensing should be ok now too.
>
> David
>
>>
>> Greetings
>> Christoph
>>
>> - Am 20. Mrz 2018 um 13:40 schrieb nowrep now...@gmail.com:
>>
>>> On Wed, Feb 28, 2018 at 12:10 PM, David Rosca  wrote:
 Hi,
 I'd like to request review for Falkon.

>>>
>>> All issues that were pointed out are now fixed.
>>>
>>> It's been in kdereview for over two weeks now, so if there are no
>>> objections I will request move to extragear by the end of this week.
>>>
>>> David
>>
>> --
>> - Dr.-Ing. Christoph Cullmann -
>> AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
>> Science Park 1 Tel:   +49-681-38360-22
>> 66123 Saarbrücken  Fax:   +49-681-38360-20
>> GERMANYWWW:   http://www.AbsInt.com
>> 
>> Geschäftsführung: Dr.-Ing. Christian Ferdinand
>> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Falkon in kdereview

[Ben Cooksley]

On Mon, Mar 26, 2018 at 10:08 AM, David Rosca  wrote:
> On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann
>  wrote:
>> Hi,
>>
>> no objections from my side,
>>
>> just a note that we need to take care of the last remaining things on
>>
>> https://community.kde.org/Incubator/Projects/Falkon
>>
>> for the final incubation to be done.
>>
>> I think the mailing list/website stuff shouldn't be an issue to get done.
>
> I've requested mailing list creation, but I'm not sure about the
> website. Does it have to be a site under kde.org (subdomain)? If yes,
> then I'm afraid I have no idea how to proceed there. The other option
> is to host it on my server, as is www.qupzilla.com right now.
> For the site contents it would be enough just basic info and download
> links, I think.

Please file a Sysadmin request so we can discuss what needs to be
provisioned there.
We generally have solutions for most types of site hosting.

>
>>
>> The Manifest compliance is IMHO there, licensing stuff was reviewed some 
>> weeks
>> ago if I am not mistaken.
>
> Manifest compliance is done I hope. Licensing should be ok now too.
>
> David

Regards,
Ben

>
>>
>> Greetings
>> Christoph
>>
>> - Am 20. Mrz 2018 um 13:40 schrieb nowrep now...@gmail.com:
>>
>>> On Wed, Feb 28, 2018 at 12:10 PM, David Rosca  wrote:
 Hi,
 I'd like to request review for Falkon.

>>>
>>> All issues that were pointed out are now fixed.
>>>
>>> It's been in kdereview for over two weeks now, so if there are no
>>> objections I will request move to extragear by the end of this week.
>>>
>>> David
>>
>> --
>> - Dr.-Ing. Christoph Cullmann -
>> AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
>> Science Park 1 Tel:   +49-681-38360-22
>> 66123 Saarbrücken  Fax:   +49-681-38360-20
>> GERMANYWWW:   http://www.AbsInt.com
>> 
>> Geschäftsführung: Dr.-Ing. Christian Ferdinand
>> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Falkon in kdereview

[David Rosca]

On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann
 wrote:
> Hi,
>
> no objections from my side,
>
> just a note that we need to take care of the last remaining things on
>
> https://community.kde.org/Incubator/Projects/Falkon
>
> for the final incubation to be done.
>
> I think the mailing list/website stuff shouldn't be an issue to get done.

I've requested mailing list creation, but I'm not sure about the
website. Does it have to be a site under kde.org (subdomain)? If yes,
then I'm afraid I have no idea how to proceed there. The other option
is to host it on my server, as is www.qupzilla.com right now.
For the site contents it would be enough just basic info and download
links, I think.

>
> The Manifest compliance is IMHO there, licensing stuff was reviewed some weeks
> ago if I am not mistaken.

Manifest compliance is done I hope. Licensing should be ok now too.

David

>
> Greetings
> Christoph
>
> - Am 20. Mrz 2018 um 13:40 schrieb nowrep now...@gmail.com:
>
>> On Wed, Feb 28, 2018 at 12:10 PM, David Rosca  wrote:
>>> Hi,
>>> I'd like to request review for Falkon.
>>>
>>
>> All issues that were pointed out are now fixed.
>>
>> It's been in kdereview for over two weeks now, so if there are no
>> objections I will request move to extragear by the end of this week.
>>
>> David
>
> --
> - Dr.-Ing. Christoph Cullmann -
> AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
> Science Park 1 Tel:   +49-681-38360-22
> 66123 Saarbrücken  Fax:   +49-681-38360-20
> GERMANYWWW:   http://www.AbsInt.com
> 
> Geschäftsführung: Dr.-Ing. Christian Ferdinand
> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Falkon in kdereview

[Dr.-Ing. Christoph Cullmann]

Hi,

no objections from my side,

just a note that we need to take care of the last remaining things on

https://community.kde.org/Incubator/Projects/Falkon

for the final incubation to be done.

I think the mailing list/website stuff shouldn't be an issue to get done.

The Manifest compliance is IMHO there, licensing stuff was reviewed some weeks
ago if I am not mistaken.

Greetings
Christoph

- Am 20. Mrz 2018 um 13:40 schrieb nowrep now...@gmail.com:

> On Wed, Feb 28, 2018 at 12:10 PM, David Rosca  wrote:
>> Hi,
>> I'd like to request review for Falkon.
>>
> 
> All issues that were pointed out are now fixed.
> 
> It's been in kdereview for over two weeks now, so if there are no
> objections I will request move to extragear by the end of this week.
> 
> David

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Falkon in kdereview

[David Rosca]

On Wed, Feb 28, 2018 at 12:10 PM, David Rosca  wrote:
> Hi,
> I'd like to request review for Falkon.
>

All issues that were pointed out are now fixed.

It's been in kdereview for over two weeks now, so if there are no
objections I will request move to extragear by the end of this week.

David

Re: Falkon in kdereview

[David Rosca]

On Sat, Mar 3, 2018 at 6:47 PM, Albert Astals Cid  wrote:
> El dimecres, 28 de febrer de 2018, a les 12:10:36 CET, David Rosca va
> escriure:
>> Hi,
>> I'd like to request review for Falkon.
>>
>> It's been actually in kdereview for some time already, but I never got
>> to properly request review, sorry about that.
>>
>> There is a project set up in bugzilla, CI build and code should be in
>> accordance with guidelines too.
>> There are also some autotests, although they are rather unstable on
>> FreeBSD build. It looks like crash in QtWebEngine, but the backtrace
>> from CI is without symbols, so it is unfortunately useless.
>>
>> Target is Extragear for now, and later possibly moving to KDE Applications.
>
> Looks really nice :)
>
> One small fix you need to do, you need to also exclude scripts from your src/
> Messages.sh

Right, I missed that, thanks.

>
> the look of your scripts/Messages.sh file looks like it's trying to be too
> smart and it'll confuse some of our tools that may try to guess which .po
> files need packaging, i'd really suggest having one Messages.sh per subfolder,
> since after all you still need to edit the python_scripts variable so it's not
> automagic that any added script will get the .po extracted.

I did it this way so that the entire folder with python extension can
be installed with simple install(DIRECTORY ...) without excluding
anything. It seemed to work fine, but I'll change it so there is
Messages.sh in each subfolder.

>
> also two random comments, probably you can ignore most of them but since i
> spent some time i'll just comment.
>  * I think you need a qDeleteAll in AdBlockSubscription::loadSubscription
> before m_rules.clear();

Yes

>  * The bookmarks text in https://i.imgur.com/xkELczj.png doesn't fit here

It probably needs to remove titles completely, as they may be very
long depending on translation, and width of that sidebar should be
fixed.

David

>
> Cheers,
>   Albert
>
>>
>> Thanks,
>> David
>
>
>
>

Re: Falkon in kdereview

[Albert Astals Cid]

El dimecres, 28 de febrer de 2018, a les 12:10:36 CET, David Rosca va 
escriure:
> Hi,
> I'd like to request review for Falkon.
> 
> It's been actually in kdereview for some time already, but I never got
> to properly request review, sorry about that.
> 
> There is a project set up in bugzilla, CI build and code should be in
> accordance with guidelines too.
> There are also some autotests, although they are rather unstable on
> FreeBSD build. It looks like crash in QtWebEngine, but the backtrace
> from CI is without symbols, so it is unfortunately useless.
> 
> Target is Extragear for now, and later possibly moving to KDE Applications.

Looks really nice :)

One small fix you need to do, you need to also exclude scripts from your src/
Messages.sh

the look of your scripts/Messages.sh file looks like it's trying to be too 
smart and it'll confuse some of our tools that may try to guess which .po 
files need packaging, i'd really suggest having one Messages.sh per subfolder, 
since after all you still need to edit the python_scripts variable so it's not 
automagic that any added script will get the .po extracted.

also two random comments, probably you can ignore most of them but since i 
spent some time i'll just comment.
 * I think you need a qDeleteAll in AdBlockSubscription::loadSubscription 
before m_rules.clear();
 * The bookmarks text in https://i.imgur.com/xkELczj.png doesn't fit here

Cheers,
  Albert

> 
> Thanks,
> David

Re: Falkon in kdereview

[Tobias C. Berner]

I think Qt except Webengine and Webkit has debug symbols in the CI

Mfg Tobias

Am 28.02.2018 12:30 schrieb "Adriaan de Groot" :

> On Wednesday, February 28, 2018 6:10:36 AM EST David Rosca wrote:
> > There are also some autotests, although they are rather unstable on
> > FreeBSD build. It looks like crash in QtWebEngine, but the backtrace
> > from CI is without symbols, so it is unfortunately useless.
>
> The KDE-FreeBSD developers are generally happy with *using* Qupzilla /
> Falkon
> though -- it's the autotests that fall over, not the browser itself.
> Something
> we'll have to look at by hand. Don't let it be a blocker.
>
> That said, the FreeBSD CI VMs should have debug symbols, so we'll have to
> look
> at that since -- as you notice -- it makes the CI less useful for
> application
> developers.
>
> [ade]
>

Re: Falkon in kdereview

[Kevin Kofler]

Adriaan de Groot wrote:
> That said, the FreeBSD CI VMs should have debug symbols, so we'll have to
> look at that since -- as you notice -- it makes the CI less useful for
> application developers.

QtWebEngine is special, it is built without debugging information for all 
the Chromium code by default. Make sure you build your QtWebEngine with: 
CONFIG += "webcore_debug v8base_debug force_debug_info"

This will build Chromium code with -g1 debuginfo. To get the normal -g2 (the 
default if you pass just -g, at least in GCC), you can try:
sed -i -e 's/symbol_level=1/symbol_level=2/g' src/core/config/common.pri
but this may cause the linker to run out of memory, and it can also crash 
other tools (e.g., the eu-strip tool that Fedora uses to split the debuginfo 
into a separate file crashes on it). So caveat emptor.

Another possibility is that the crash is in JITted code (e.g., JavaScript 
compiled by the V8 JIT), in which case you cannot possibly get a useful 
backtrace at all, no matter how much debugging information you enable.

Kevin Kofler

Re: Falkon in kdereview

[Adriaan de Groot]

On Wednesday, February 28, 2018 6:10:36 AM EST David Rosca wrote:
> There are also some autotests, although they are rather unstable on
> FreeBSD build. It looks like crash in QtWebEngine, but the backtrace
> from CI is without symbols, so it is unfortunately useless.

The KDE-FreeBSD developers are generally happy with *using* Qupzilla / Falkon 
though -- it's the autotests that fall over, not the browser itself. Something 
we'll have to look at by hand. Don't let it be a blocker.

That said, the FreeBSD CI VMs should have debug symbols, so we'll have to look 
at that since -- as you notice -- it makes the CI less useful for application 
developers.

[ade]


signature.asc
Description: This is a digitally signed message part.

Falkon in kdereview

[David Rosca]

Hi,
I'd like to request review for Falkon.

It's been actually in kdereview for some time already, but I never got
to properly request review, sorry about that.

There is a project set up in bugzilla, CI build and code should be in
accordance with guidelines too.
There are also some autotests, although they are rather unstable on
FreeBSD build. It looks like crash in QtWebEngine, but the backtrace
from CI is without symbols, so it is unfortunately useless.

Target is Extragear for now, and later possibly moving to KDE Applications.

Thanks,
David