Re: KSambaShare destructor proposed patch

2011-03-19 Thread Rodrigo Belém
On Sat, Mar 19, 2011 at 8:51 AM, Fabrice Ménard wrote: > Le vendredi 18 mars 2011 20:55:52 David Faure a écrit : >> Looks good, please commit -- if you don't have a kde svn/git account yet, >> please get one, your patches are good ;) > Thanks > > I don't have an account  yet. I will commit to you

Re: KSambaShare destructor proposed patch

2011-03-19 Thread Fabrice Ménard
Le vendredi 18 mars 2011 20:55:52 David Faure a écrit : > Looks good, please commit -- if you don't have a kde svn/git account yet, > please get one, your patches are good ;) Thanks I don't have an account yet. Before I get one, I'll have to study thoroughly techbase.kde and try to better unders

Re: KSambaShare destructor proposed patch

2011-03-18 Thread David Faure
On Friday 18 March 2011, Fabrice Ménard wrote: > Hi, > > As KSambaShare and KDirWatch are global statics we must ensure that an > object has not already been destroyed before calling anything on it. Looks good, please commit -- if you don't have a kde svn/git account yet, please get one, your pa

KSambaShare destructor proposed patch

2011-03-18 Thread Fabrice Ménard
Hi, As KSambaShare and KDirWatch are global statics we must ensure that an object has not already been destroyed before calling anything on it. Regards, -- Fabrice Ménarddiff --git a/kio/kio/ksambashare.cpp b/kio/kio/ksambashare.cpp index e82f1b7..dfab22e 100644 --- a/kio/kio/ksambashare.cpp ++