Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Kevin Ottens
Hello, On Saturday 29 December 2012 02:47:13 Friedrich W. H. Kossebau wrote: --- 8 --- Qt Includes If you add #includes for Qt classes, use both the module and class name. This allows library code to be used by applications without excessive compiler include paths. Example: // wrong

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Stephen Kelly
Kevin Ottens wrote: We should push to use the class name only includes I think. I agree. We have a buildsystem that is good enough that we can specify the directories to look for the 'class name' headers in, and it is in the buildsystem that that stuff belongs. See the kinds of practical

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread David Faure
On Saturday 29 December 2012 02:47:13 Friedrich W. H. Kossebau wrote: Will kde-frameworks be Qt5-only, so not need to support both Qt4 and Qt5 and thus to use module-less Qt includes? At some point it will be, yes. Right now it supports both, so a bunch of QtGui/ was removed in #include

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Albert Astals Cid
El Dissabte, 29 de desembre de 2012, a les 10:48:48, Kevin Ottens va escriure: Hello, On Saturday 29 December 2012 02:47:13 Friedrich W. H. Kossebau wrote: --- 8 --- Qt Includes If you add #includes for Qt classes, use both the module and class name. This allows library code to be

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Adriaan de Groot
On Saturday, December 29, 2012 04:25:54 PM Albert Astals Cid wrote: Would there be any chance to have the style check done by a pre-commit hook? Or at least have a command-line tool that checks it for me? Wouldn't that typically be a Krazy thing to check (and you can run Krazy checks from the

Re: Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Martin Gräßlin
On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote: Would there be any chance to have the style check done by a pre-commit hook? Or at least have a command-line tool that checks it for me? yeah that should be possible. At my old day-job I created a pre-commit hook to basically grep

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Allen Winter
On Saturday 29 December 2012 07:11:17 PM Martin Gräßlin wrote: On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote: Would there be any chance to have the style check done by a pre-commit hook? Or at least have a command-line tool that checks it for me? yeah that should be

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Milian Wolff
On Saturday 29 December 2012 19:11:17 Martin Gräßlin wrote: On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote: Would there be any chance to have the style check done by a pre-commit hook? Or at least have a command-line tool that checks it for me? yeah that should be possible.

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Laszlo Papp
On Sat, Dec 29, 2012 at 7:50 PM, Allen Winter win...@kde.org wrote: If you have the Krazy command line tool installed ( https://gitorious.org/krazy) then you could write a pre-commit hook that runs 'krazy2 --style' on the files being committed. ./krazy2 --style Unknown option: style

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Kevin Ottens
On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote: El Dissabte, 29 de desembre de 2012, a les 10:48:48, Kevin Ottens va escriure: Hello, On Saturday 29 December 2012 02:47:13 Friedrich W. H. Kossebau wrote: --- 8 --- Qt Includes If you add #includes for Qt classes,

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Kevin Ottens
On Saturday 29 December 2012 11:06:30 David Faure wrote: Well, for frameworks that intend to be as close to Qt as possible they should do the same (for the convenience of developers who don't use qmake/cmake but set up their project configuration in their IDE by hand, for instance Visual

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Stephen Kelly
Thiago Macieira wrote: On sábado, 29 de dezembro de 2012 22.58.49, Kevin Ottens wrote: On Saturday 29 December 2012 11:06:30 David Faure wrote: Well, for frameworks that intend to be as close to Qt as possible they should do the same (for the convenience of developers who don't use

Kdelibs Coding Style vs. preparations for Qt5

2012-12-28 Thread Friedrich W. H. Kossebau
Hi, what about adapting the Kdelibs Coding Style to the upcoming preparations for the porting to Qt5? A lot of (KDE) projects follow that kdelibs one, but there is (at least?) one rule which seems to conflict with the recommendations for the preparations: --- 8 --- Qt Includes If you add