Re: Kup in KDE Review

2020-04-16 Thread Michael Reeves
On Tue, Apr 14, 2020, 5:19 AM Simon Persson wrote: > On 2020-04-07 05:09, Adriaan de Groot wrote: > > On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote: > . > > > > > > > - Uses a handful of deprecated methods; depending on what exactly you > want to > > be compatible with, you might

Re: Kup in KDE Review

2020-04-14 Thread Kevin Ottens
Hello, On Thursday, 9 April 2020 07:25:34 CEST Simon Persson wrote: > On 2020-04-07 06:01, Nicolas Fella wrote: > > I briefly skimmed trough the codebase. Looks all sane to me. A few > > minor observations: > > > > - You may want to look into KConfigXT. It should be able to generate > > the

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
On 2020-04-07 05:09, Adriaan de Groot wrote: On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote: Please help to review kup. - It's probably worthwhile looking at REUSE licensing compliance (see reuse.software, or ask on IRC #kde-devel) so that the license is machine- readable and

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
On 2020-04-08 16:53, Christophe Giboudeaux wrote: 'COPYING' only covers the GPL-2.0-only part of the code. You also need the GPL-3.0-only and the LicenseRef-KDE-Accepted-GPL reference. Note that we're slowly moving from the monolithic license blocks to SPDX statements. See

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
Hello! On 2020-04-07 06:01, Nicolas Fella wrote: Hi, I briefly skimmed trough the codebase. Looks all sane to me. A few minor observations: - You may want to look into KConfigXT. It should be able to generate the classes from settings/ from an XML description. I think that I looked at

Re: Kup in KDE Review

2020-04-14 Thread Simon Persson
On 2020-04-07 21:28, Jonathan Riddell wrote: This looks great.  I think the other comments have covered the main issues so I'll just make a cheeky feature request and suggest it gets the ability to upload to cloud storage since I would guess that's the main way to do backups these days.

Re: Kup in KDE Review

2020-04-14 Thread Christophe Giboudeaux
On lundi 6 avril 2020 12:32:54 CEST Simon Persson wrote: > Hello! > > > Please help to review kup. > 'COPYING' only covers the GPL-2.0-only part of the code. You also need the GPL-3.0-only and the LicenseRef-KDE-Accepted-GPL reference. Note that we're slowly moving from the monolithic

Re: Kup in KDE Review

2020-04-08 Thread Nicolas Fella
On Montag, 6. April 2020 12:32:54 CEST Simon Persson wrote: > Hello! > > > Please help to review kup. > > It is a backup scheduler tightly integrated with plasma (has system > setting kcm, systray plasmoid, kioslave). It supports saving backups > either with bup or with rsync. > > It has been

Re: Kup in KDE Review

2020-04-08 Thread Simon Persson
On 2020-04-07 06:02, Albert Astals Cid wrote: When in the kcm i go to add new plan i get the "Versioned backup" disabled because bup is not installed *BUT* it is still the selected radio button, i guess in that case it would make more sense if the "Synchronized backup" was the selected one,

Re: Kup in KDE Review

2020-04-07 Thread Jonathan Riddell
This looks great. I think the other comments have covered the main issues so I'll just make a cheeky feature request and suggest it gets the ability to upload to cloud storage since I would guess that's the main way to do backups these days. Talking to Nextcloud or gdrive or AWS directly would

Re: Kup in KDE Review

2020-04-06 Thread Albert Astals Cid
El dilluns, 6 d’abril de 2020, a les 12:32:54 CEST, Simon Persson va escriure: > Hello! > > > Please help to review kup. > > It is a backup scheduler tightly integrated with plasma (has system > setting kcm, systray plasmoid, kioslave). It supports saving backups > either with bup or with

Re: Kup in KDE Review

2020-04-06 Thread Adriaan de Groot
On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote: > Please help to review kup. - It's probably worthwhile looking at REUSE licensing compliance (see reuse.software, or ask on IRC #kde-devel) so that the license is machine- readable and checkable. - Although you find_package(LibGit2) you

Kup in KDE Review

2020-04-06 Thread Simon Persson
Hello! Please help to review kup. It is a backup scheduler tightly integrated with plasma (has system setting kcm, systray plasmoid, kioslave). It supports saving backups either with bup or with rsync. It has been developed outside of KDE for many years and only now is being incubated.

[sysadmin/repo-metadata] projects/kdereview/kup: Move Kup to KDE Review per the request of it's maintainer.

2020-04-06 Thread Ben Cooksley
Git commit cc33a7e893e58ad817b7358cbdfce56b3b93142d by Ben Cooksley. Committed on 06/04/2020 at 09:30. Pushed by bcooksley into branch 'master'. Move Kup to KDE Review per the request of it's maintainer. Fixes T12928 CCMAIL: kde-core-devel@kde.org R +0-0projects/kdereview/kup