Re: New repo in kdereview: KWeather
El dimecres, 30 de novembre de 2022, a les 15:58:29 (CET), Devin va escriure:
> Should be fixed now, I removed the dialog flag on the window.
Confirmed :)
>
> Thanks,
> Devin
>
> On Tue, Nov 29, 2022 at 10:33 PM Nate Graham wrote:
> > This happens on X11 when using QtDialogs for reasons I don't understand.
> > See
> > https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8
> > 047d6f90e01899b2e03.
> >
> > Nate
> >
> > On 11/29/22 16:48, Devin wrote:
> > > Hmm, I have no idea why the behaviour is different for you, but I get:
> > > https://i.imgur.com/CvGD8HS.png
> > >
> > > If you removed the "Qt.Dialog" flag here:
> > > https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/sett
> > > ings/SettingsWindow.qml#L14, does it still have the issue?
> > >
> > > Thanks,
> > > Devin
> > >
> > > On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid wrote:
> > >> El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va
escriure:
> > Ok, now that i updated kirigami-addons, the Settings dialog shows,
> > but
> > it's uncloseable, any idea why that would be?
> > >>>
> > >>> That's very strange, it should be showing up as a regular window, does
> > >>> pressing the close button on the window decoration not work?
> > >>
> > >> Which close button?
> > >>
> > >> https://i.imgur.com/2jX2yUS.png
> > >>
> > >> Cheers,
> > >>
> > >>Albert
> > >>>
> > >>> Thanks,
> > >>> Devin
> > >>>
> > >>> On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid
wrote:
> > El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert
> > Astals
> > Cid va>
> >
> > escriure:
> > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
> >
> > escriure:
> > >>> There's potentially overlapping text.
> > >>
> > >> I have fixed text wrapping in the weather delegates so it should
> > >> wrap
> > >> properly now.
> > >>
> > >>> Here settingsModel.forecastStyle is not i18n'ed
> > >>
> > >> I have fixed it now (it converts to i18n'd dedicated strings in the
> > >> QML)
> > >
> > > FWIW i can't open settings anymore
> > >
> > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot
> > > assign
> > > to
> > > non-existent property "onActivated" qrc:/qml/main.qml:136:
> > > TypeError:
> > > Cannot call method 'close' of null
> >
> > Ok, now that i updated kirigami-addons, the Settings dialog shows,
> > but
> > it's
> > uncloseable, any idea why that would be?
> >
> > Cheers,
> >
> > Albert
> > >
> > > Cheers,
> > >
> > >Albert
> > >>
> > >> On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid
> > >>
> > >> wrote:
> > >>> El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
> >
> > escriure:
> > Hi everyone,
> >
> > I would like to put kweather through kdereview:
> >
> > https://invent.kde.org/plasma-mobile/kweather
> >
> > KWeather is an application that can give simple weather
> > information
> > for different weather locations. Please note that KWeatherCore
> > (the
> > library the app depends on) has already passed kdereview.
> > >>>
> > >>> There's potentially overlapping text.
> > >>>
> > >>> See https://i.imgur.com/BrOgi3A.png
> > >>>
> > >>> The settings show untranslateable text, i.e.
> > >>>
> > >>> MobileForm.FormComboBoxDelegate {
> > >>>
> > >>> id: forecastStyleDropdown
> > >>> text: i18n("Forecast Style")
> > >>> currentValue: settingsModel.forecastStyle
> > >>>
> > >>> Here settingsModel.forecastStyle is not i18n'ed
> > >>>
> > >>> Not KWeather's fault but i just realized that Kirigami's about
> > >>> page
> > >>> doesn't
> > >>> properly credit translators :/
> > >>>
> > >>> Cheers,
> > >>>
> > >>>Albert
> >
> > Thanks,
> > Devin
Re: New repo in kdereview: KWeather
Should be fixed now, I removed the dialog flag on the window.
Thanks,
Devin
On Tue, Nov 29, 2022 at 10:33 PM Nate Graham wrote:
>
> This happens on X11 when using QtDialogs for reasons I don't understand.
> See
> https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03.
>
> Nate
>
>
> On 11/29/22 16:48, Devin wrote:
> > Hmm, I have no idea why the behaviour is different for you, but I get:
> > https://i.imgur.com/CvGD8HS.png
> >
> > If you removed the "Qt.Dialog" flag here:
> > https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14,
> > does it still have the issue?
> >
> > Thanks,
> > Devin
> >
> > On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid wrote:
> >>
> >> El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va
> >> escriure:
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but
> it's uncloseable, any idea why that would be?
> >>> That's very strange, it should be showing up as a regular window, does
> >>> pressing the close button on the window decoration not work?
> >>
> >> Which close button?
> >>
> >> https://i.imgur.com/2jX2yUS.png
> >>
> >> Cheers,
> >>Albert
> >>
> >>>
> >>> Thanks,
> >>> Devin
> >>>
> >>> On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote:
> El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals
> Cid va>
> escriure:
> > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
>
> escriure:
> >>> There's potentially overlapping text.
> >>
> >> I have fixed text wrapping in the weather delegates so it should wrap
> >> properly now.
> >>
> >>> Here settingsModel.forecastStyle is not i18n'ed
> >>
> >> I have fixed it now (it converts to i18n'd dedicated strings in the
> >> QML)
> >
> > FWIW i can't open settings anymore
> >
> > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign
> > to
> > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
> > Cannot call method 'close' of null
>
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but
> it's
> uncloseable, any idea why that would be?
>
> Cheers,
>
> Albert
>
> > Cheers,
> >
> >Albert
> >
> >> On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid
> >> wrote:
> >>> El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
>
> escriure:
> Hi everyone,
>
> I would like to put kweather through kdereview:
>
> https://invent.kde.org/plasma-mobile/kweather
>
> KWeather is an application that can give simple weather
> information
> for different weather locations. Please note that KWeatherCore
> (the
> library the app depends on) has already passed kdereview.
> >>>
> >>> There's potentially overlapping text.
> >>>
> >>> See https://i.imgur.com/BrOgi3A.png
> >>>
> >>> The settings show untranslateable text, i.e.
> >>>
> >>> MobileForm.FormComboBoxDelegate {
> >>>
> >>> id: forecastStyleDropdown
> >>> text: i18n("Forecast Style")
> >>> currentValue: settingsModel.forecastStyle
> >>>
> >>> Here settingsModel.forecastStyle is not i18n'ed
> >>>
> >>> Not KWeather's fault but i just realized that Kirigami's about page
> >>> doesn't
> >>> properly credit translators :/
> >>>
> >>> Cheers,
> >>>
> >>>Albert
> >>>
> Thanks,
> Devin
> >>
> >>
> >>
> >>
Re: New repo in kdereview: KWeather
This happens on X11 when using QtDialogs for reasons I don't understand.
See
https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03.
Nate
On 11/29/22 16:48, Devin wrote:
Hmm, I have no idea why the behaviour is different for you, but I get:
https://i.imgur.com/CvGD8HS.png
If you removed the "Qt.Dialog" flag here:
https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14,
does it still have the issue?
Thanks,
Devin
On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid wrote:
El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure:
Ok, now that i updated kirigami-addons, the Settings dialog shows, but
it's uncloseable, any idea why that would be?
That's very strange, it should be showing up as a regular window, does
pressing the close button on the window decoration not work?
Which close button?
https://i.imgur.com/2jX2yUS.png
Cheers,
Albert
Thanks,
Devin
On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote:
El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals
Cid va>
escriure:
El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
escriure:
There's potentially overlapping text.
I have fixed text wrapping in the weather delegates so it should wrap
properly now.
Here settingsModel.forecastStyle is not i18n'ed
I have fixed it now (it converts to i18n'd dedicated strings in the
QML)
FWIW i can't open settings anymore
qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign
to
non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
Cannot call method 'close' of null
Ok, now that i updated kirigami-addons, the Settings dialog shows, but
it's
uncloseable, any idea why that would be?
Cheers,
Albert
Cheers,
Albert
On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid
wrote:
El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
escriure:
Hi everyone,
I would like to put kweather through kdereview:
https://invent.kde.org/plasma-mobile/kweather
KWeather is an application that can give simple weather
information
for different weather locations. Please note that KWeatherCore
(the
library the app depends on) has already passed kdereview.
There's potentially overlapping text.
See https://i.imgur.com/BrOgi3A.png
The settings show untranslateable text, i.e.
MobileForm.FormComboBoxDelegate {
id: forecastStyleDropdown
text: i18n("Forecast Style")
currentValue: settingsModel.forecastStyle
Here settingsModel.forecastStyle is not i18n'ed
Not KWeather's fault but i just realized that Kirigami's about page
doesn't
properly credit translators :/
Cheers,
Albert
Thanks,
Devin
Re: New repo in kdereview: KWeather
Hmm, I have no idea why the behaviour is different for you, but I get:
https://i.imgur.com/CvGD8HS.png
If you removed the "Qt.Dialog" flag here:
https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14,
does it still have the issue?
Thanks,
Devin
On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid wrote:
>
> El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure:
> > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but
> > > it's uncloseable, any idea why that would be?
> > That's very strange, it should be showing up as a regular window, does
> > pressing the close button on the window decoration not work?
>
> Which close button?
>
> https://i.imgur.com/2jX2yUS.png
>
> Cheers,
> Albert
>
> >
> > Thanks,
> > Devin
> >
> > On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote:
> > > El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals
> > > Cid va>
> > > escriure:
> > > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
> > >
> > > escriure:
> > > > > > There's potentially overlapping text.
> > > > >
> > > > > I have fixed text wrapping in the weather delegates so it should wrap
> > > > > properly now.
> > > > >
> > > > > > Here settingsModel.forecastStyle is not i18n'ed
> > > > >
> > > > > I have fixed it now (it converts to i18n'd dedicated strings in the
> > > > > QML)
> > > >
> > > > FWIW i can't open settings anymore
> > > >
> > > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign
> > > > to
> > > > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
> > > > Cannot call method 'close' of null
> > >
> > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but
> > > it's
> > > uncloseable, any idea why that would be?
> > >
> > > Cheers,
> > >
> > > Albert
> > >
> > > > Cheers,
> > > >
> > > > Albert
> > > >
> > > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid
> wrote:
> > > > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
> > >
> > > escriure:
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > I would like to put kweather through kdereview:
> > > > > > >
> > > > > > > https://invent.kde.org/plasma-mobile/kweather
> > > > > > >
> > > > > > > KWeather is an application that can give simple weather
> > > > > > > information
> > > > > > > for different weather locations. Please note that KWeatherCore
> > > > > > > (the
> > > > > > > library the app depends on) has already passed kdereview.
> > > > > >
> > > > > > There's potentially overlapping text.
> > > > > >
> > > > > > See https://i.imgur.com/BrOgi3A.png
> > > > > >
> > > > > > The settings show untranslateable text, i.e.
> > > > > >
> > > > > > MobileForm.FormComboBoxDelegate {
> > > > > >
> > > > > > id: forecastStyleDropdown
> > > > > > text: i18n("Forecast Style")
> > > > > > currentValue: settingsModel.forecastStyle
> > > > > >
> > > > > > Here settingsModel.forecastStyle is not i18n'ed
> > > > > >
> > > > > > Not KWeather's fault but i just realized that Kirigami's about page
> > > > > > doesn't
> > > > > > properly credit translators :/
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Albert
> > > > > >
> > > > > > > Thanks,
> > > > > > > Devin
>
>
>
>
Re: New repo in kdereview: KWeather
El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure:
> > Ok, now that i updated kirigami-addons, the Settings dialog shows, but
> > it's uncloseable, any idea why that would be?
> That's very strange, it should be showing up as a regular window, does
> pressing the close button on the window decoration not work?
Which close button?
https://i.imgur.com/2jX2yUS.png
Cheers,
Albert
>
> Thanks,
> Devin
>
> On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote:
> > El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals
> > Cid va>
> > escriure:
> > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
> >
> > escriure:
> > > > > There's potentially overlapping text.
> > > >
> > > > I have fixed text wrapping in the weather delegates so it should wrap
> > > > properly now.
> > > >
> > > > > Here settingsModel.forecastStyle is not i18n'ed
> > > >
> > > > I have fixed it now (it converts to i18n'd dedicated strings in the
> > > > QML)
> > >
> > > FWIW i can't open settings anymore
> > >
> > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign
> > > to
> > > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
> > > Cannot call method 'close' of null
> >
> > Ok, now that i updated kirigami-addons, the Settings dialog shows, but
> > it's
> > uncloseable, any idea why that would be?
> >
> > Cheers,
> >
> > Albert
> >
> > > Cheers,
> > >
> > > Albert
> > >
> > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid
wrote:
> > > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
> >
> > escriure:
> > > > > > Hi everyone,
> > > > > >
> > > > > > I would like to put kweather through kdereview:
> > > > > >
> > > > > > https://invent.kde.org/plasma-mobile/kweather
> > > > > >
> > > > > > KWeather is an application that can give simple weather
> > > > > > information
> > > > > > for different weather locations. Please note that KWeatherCore
> > > > > > (the
> > > > > > library the app depends on) has already passed kdereview.
> > > > >
> > > > > There's potentially overlapping text.
> > > > >
> > > > > See https://i.imgur.com/BrOgi3A.png
> > > > >
> > > > > The settings show untranslateable text, i.e.
> > > > >
> > > > > MobileForm.FormComboBoxDelegate {
> > > > >
> > > > > id: forecastStyleDropdown
> > > > > text: i18n("Forecast Style")
> > > > > currentValue: settingsModel.forecastStyle
> > > > >
> > > > > Here settingsModel.forecastStyle is not i18n'ed
> > > > >
> > > > > Not KWeather's fault but i just realized that Kirigami's about page
> > > > > doesn't
> > > > > properly credit translators :/
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Albert
> > > > >
> > > > > > Thanks,
> > > > > > Devin
Re: New repo in kdereview: KWeather
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's
> uncloseable, any idea why that would be?
That's very strange, it should be showing up as a regular window, does
pressing the close button on the window decoration not work?
Thanks,
Devin
On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid wrote:
>
> El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals Cid va
> escriure:
> > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
> escriure:
> > > > There's potentially overlapping text.
> > >
> > > I have fixed text wrapping in the weather delegates so it should wrap
> > > properly now.
> > >
> > > > Here settingsModel.forecastStyle is not i18n'ed
> > >
> > > I have fixed it now (it converts to i18n'd dedicated strings in the QML)
> >
> > FWIW i can't open settings anymore
> >
> > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to
> > non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
> > Cannot call method 'close' of null
>
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's
> uncloseable, any idea why that would be?
>
> Cheers,
> Albert
>
> >
> > Cheers,
> > Albert
> >
> > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote:
> > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
> escriure:
> > > > > Hi everyone,
> > > > >
> > > > > I would like to put kweather through kdereview:
> > > > >
> > > > > https://invent.kde.org/plasma-mobile/kweather
> > > > >
> > > > > KWeather is an application that can give simple weather information
> > > > > for different weather locations. Please note that KWeatherCore (the
> > > > > library the app depends on) has already passed kdereview.
> > > >
> > > > There's potentially overlapping text.
> > > >
> > > > See https://i.imgur.com/BrOgi3A.png
> > > >
> > > > The settings show untranslateable text, i.e.
> > > >
> > > > MobileForm.FormComboBoxDelegate {
> > > >
> > > > id: forecastStyleDropdown
> > > > text: i18n("Forecast Style")
> > > > currentValue: settingsModel.forecastStyle
> > > >
> > > > Here settingsModel.forecastStyle is not i18n'ed
> > > >
> > > > Not KWeather's fault but i just realized that Kirigami's about page
> > > > doesn't
> > > > properly credit translators :/
> > > >
> > > > Cheers,
> > > >
> > > > Albert
> > > >
> > > > > Thanks,
> > > > > Devin
>
>
>
>
Re: New repo in kdereview: KWeather
El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals Cid va
escriure:
> El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
escriure:
> > > There's potentially overlapping text.
> >
> > I have fixed text wrapping in the weather delegates so it should wrap
> > properly now.
> >
> > > Here settingsModel.forecastStyle is not i18n'ed
> >
> > I have fixed it now (it converts to i18n'd dedicated strings in the QML)
>
> FWIW i can't open settings anymore
>
> qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to
> non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
> Cannot call method 'close' of null
Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's
uncloseable, any idea why that would be?
Cheers,
Albert
>
> Cheers,
> Albert
>
> > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote:
> > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
escriure:
> > > > Hi everyone,
> > > >
> > > > I would like to put kweather through kdereview:
> > > >
> > > > https://invent.kde.org/plasma-mobile/kweather
> > > >
> > > > KWeather is an application that can give simple weather information
> > > > for different weather locations. Please note that KWeatherCore (the
> > > > library the app depends on) has already passed kdereview.
> > >
> > > There's potentially overlapping text.
> > >
> > > See https://i.imgur.com/BrOgi3A.png
> > >
> > > The settings show untranslateable text, i.e.
> > >
> > > MobileForm.FormComboBoxDelegate {
> > >
> > > id: forecastStyleDropdown
> > > text: i18n("Forecast Style")
> > > currentValue: settingsModel.forecastStyle
> > >
> > > Here settingsModel.forecastStyle is not i18n'ed
> > >
> > > Not KWeather's fault but i just realized that Kirigami's about page
> > > doesn't
> > > properly credit translators :/
> > >
> > > Cheers,
> > >
> > > Albert
> > >
> > > > Thanks,
> > > > Devin
Re: New repo in kdereview: KWeather
> You've been told that you need to increase your minimum dependency in another > email, i'll do it again. > > Increase your required version of kirigami addons so that it matches reality. I apologize for being confused, I was wondering how I was supposed to bump a runtime QML dependency version... Nicolas added a change to add it as a proper compile time dependency now: https://invent.kde.org/plasma-mobile/kweather/-/merge_requests/79 Thanks, Devin On Mon, Nov 28, 2022 at 7:48 PM Nate Graham wrote: > > Thanks, I'm happy with the UI now! Really great app. > > Nate
Re: New repo in kdereview: KWeather
Is there some way I can do this at runtime? kirigami-addons is used here as a QML API. Thanks, Devin On Mon, Nov 28, 2022 at 12:17 PM Ingo Klöcker wrote: > > On Montag, 28. November 2022 17:53:59 CET Devin wrote: > > > FWIW i can't open settings anymore > > > > Make sure you have the latest kirigami-addons built (from master). > > I have read "use the latest kirigami-addons" many times in the last few weeks. > Isn't it possible to add a version check to detect this and show an > appropriate error if users of kirigami-addons don't use the required version? > > Whenever I add new API to libkleo that I use in Kleopatra, I bump the version > of libkleo and require the bumped version in Kleopatra, so that people > building Kleopatra immediately notice if they need to update libkleo. > > Regards, > Ingo
Re: New repo in kdereview: KWeather
El dilluns, 28 de novembre de 2022, a les 17:53:59 (CET), Devin va escriure:
> > FWIW i can't open settings anymore
>
> Make sure you have the latest kirigami-addons built (from master).
Depending on an unreleased version of a dependency is not acceptable if you
want to release your application (which it is my understanding of what you're
aiming given you're asking us to review it).
Cheers,
Albert
>
> Thanks,
> Devin
>
> On Mon, Nov 28, 2022 at 11:15 AM Albert Astals Cid wrote:
> > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
escriure:
> > > > There's potentially overlapping text.
> > >
> > > I have fixed text wrapping in the weather delegates so it should wrap
> > > properly now.
> > >
> > > > Here settingsModel.forecastStyle is not i18n'ed
> > >
> > > I have fixed it now (it converts to i18n'd dedicated strings in the QML)
> >
> > FWIW i can't open settings anymore
> >
> > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign
> > to non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
> > Cannot call method 'close' of null
> >
> > Cheers,
> >
> > Albert
> >
> > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote:
> > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
escriure:
> > > > > Hi everyone,
> > > > >
> > > > > I would like to put kweather through kdereview:
> > > > >
> > > > > https://invent.kde.org/plasma-mobile/kweather
> > > > >
> > > > > KWeather is an application that can give simple weather information
> > > > > for different weather locations. Please note that KWeatherCore (the
> > > > > library the app depends on) has already passed kdereview.
> > > >
> > > > There's potentially overlapping text.
> > > >
> > > > See https://i.imgur.com/BrOgi3A.png
> > > >
> > > > The settings show untranslateable text, i.e.
> > > >
> > > > MobileForm.FormComboBoxDelegate {
> > > >
> > > > id: forecastStyleDropdown
> > > > text: i18n("Forecast Style")
> > > > currentValue: settingsModel.forecastStyle
> > > >
> > > > Here settingsModel.forecastStyle is not i18n'ed
> > > >
> > > > Not KWeather's fault but i just realized that Kirigami's about page
> > > > doesn't
> > > > properly credit translators :/
> > > >
> > > > Cheers,
> > > >
> > > > Albert
> > > >
> > > > > Thanks,
> > > > > Devin
Re: New repo in kdereview: KWeather
On Montag, 28. November 2022 17:53:59 CET Devin wrote: > > FWIW i can't open settings anymore > > Make sure you have the latest kirigami-addons built (from master). I have read "use the latest kirigami-addons" many times in the last few weeks. Isn't it possible to add a version check to detect this and show an appropriate error if users of kirigami-addons don't use the required version? Whenever I add new API to libkleo that I use in Kleopatra, I bump the version of libkleo and require the bumped version in Kleopatra, so that people building Kleopatra immediately notice if they need to update libkleo. Regards, Ingo signature.asc Description: This is a digitally signed message part.
Re: New repo in kdereview: KWeather
> FWIW i can't open settings anymore
Make sure you have the latest kirigami-addons built (from master).
Thanks,
Devin
On Mon, Nov 28, 2022 at 11:15 AM Albert Astals Cid wrote:
>
> El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure:
> > > There's potentially overlapping text.
> >
> > I have fixed text wrapping in the weather delegates so it should wrap
> > properly now.
> >
> > > Here settingsModel.forecastStyle is not i18n'ed
> >
> > I have fixed it now (it converts to i18n'd dedicated strings in the QML)
>
> FWIW i can't open settings anymore
>
> qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent unavailable
> qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to non-existent
> property "onActivated"
> qrc:/qml/main.qml:136: TypeError: Cannot call method 'close' of null
>
> Cheers,
> Albert
>
> >
> > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote:
> > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
> > > escriure:
> > > > Hi everyone,
> > > >
> > > > I would like to put kweather through kdereview:
> > > >
> > > > https://invent.kde.org/plasma-mobile/kweather
> > > >
> > > > KWeather is an application that can give simple weather information
> > > > for different weather locations. Please note that KWeatherCore (the
> > > > library the app depends on) has already passed kdereview.
> > >
> > > There's potentially overlapping text.
> > >
> > > See https://i.imgur.com/BrOgi3A.png
> > >
> > > The settings show untranslateable text, i.e.
> > >
> > > MobileForm.FormComboBoxDelegate {
> > >
> > > id: forecastStyleDropdown
> > > text: i18n("Forecast Style")
> > > currentValue: settingsModel.forecastStyle
> > >
> > > Here settingsModel.forecastStyle is not i18n'ed
> > >
> > > Not KWeather's fault but i just realized that Kirigami's about page
> > > doesn't
> > > properly credit translators :/
> > >
> > > Cheers,
> > >
> > > Albert
> > >
> > > > Thanks,
> > > > Devin
>
>
>
>
Re: New repo in kdereview: KWeather
El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure:
> > There's potentially overlapping text.
>
> I have fixed text wrapping in the weather delegates so it should wrap
> properly now.
>
> > Here settingsModel.forecastStyle is not i18n'ed
>
> I have fixed it now (it converts to i18n'd dedicated strings in the QML)
FWIW i can't open settings anymore
qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent unavailable
qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign to non-existent
property "onActivated"
qrc:/qml/main.qml:136: TypeError: Cannot call method 'close' of null
Cheers,
Albert
>
> On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote:
> > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure:
> > > Hi everyone,
> > >
> > > I would like to put kweather through kdereview:
> > >
> > > https://invent.kde.org/plasma-mobile/kweather
> > >
> > > KWeather is an application that can give simple weather information
> > > for different weather locations. Please note that KWeatherCore (the
> > > library the app depends on) has already passed kdereview.
> >
> > There's potentially overlapping text.
> >
> > See https://i.imgur.com/BrOgi3A.png
> >
> > The settings show untranslateable text, i.e.
> >
> > MobileForm.FormComboBoxDelegate {
> >
> > id: forecastStyleDropdown
> > text: i18n("Forecast Style")
> > currentValue: settingsModel.forecastStyle
> >
> > Here settingsModel.forecastStyle is not i18n'ed
> >
> > Not KWeather's fault but i just realized that Kirigami's about page
> > doesn't
> > properly credit translators :/
> >
> > Cheers,
> >
> > Albert
> >
> > > Thanks,
> > > Devin
Re: New repo in kdereview: KWeather
> There's potentially overlapping text.
I have fixed text wrapping in the weather delegates so it should wrap
properly now.
> Here settingsModel.forecastStyle is not i18n'ed
I have fixed it now (it converts to i18n'd dedicated strings in the QML)
On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid wrote:
>
> El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure:
> > Hi everyone,
> >
> > I would like to put kweather through kdereview:
> >
> > https://invent.kde.org/plasma-mobile/kweather
> >
> > KWeather is an application that can give simple weather information
> > for different weather locations. Please note that KWeatherCore (the
> > library the app depends on) has already passed kdereview.
>
> There's potentially overlapping text.
>
> See https://i.imgur.com/BrOgi3A.png
>
> The settings show untranslateable text, i.e.
>
> MobileForm.FormComboBoxDelegate {
> id: forecastStyleDropdown
> text: i18n("Forecast Style")
> currentValue: settingsModel.forecastStyle
>
> Here settingsModel.forecastStyle is not i18n'ed
>
> Not KWeather's fault but i just realized that Kirigami's about page doesn't
> properly credit translators :/
>
> Cheers,
> Albert
>
> >
> > Thanks,
> > Devin
>
>
>
>
Re: New repo in kdereview: KWeather
Really great app. I have just a few minor UX comments, in order of how strongly I feel about them: The main page has no scrollbars, so it's not obvious that the view is scrollable, especially because with various window sizes, nothing looks visibly cut off on the bottom to suggest scrollability, which is the typical metaphor on mobile: https://i.imgur.com/mN7AD09.jpg I would recommend using the standard style Kirigami scrollbars which are always visible in desktop mode, and semi-auto-hide in mobile mode. Like KRecorder, the config dialog should be a separate window on desktop mode (and a full-window page on mobile mode, which it already does, so +1 for that). I can swipe left and right to switch which city's weather is being displayed, but this isn't visually obvious. Maybe add subtle left- and rightward-pointing arrows on the sides of the view to suggest that there's more than, and that can also be tapped/clicked to change the view. In the "Add Location" sheet, the "Add Current Location" button should probably use the "mark-location" icon, which is more visually appropriate. In the "Add Location" sheet, the search button should be disabled when the search field has no text in it. Also... is that button even needed at all? The search field seems to start searching immediately after I finish typing, so maybe the button can be removed. The Locations button in the top-right corner of the main page should maybe use the "find-location" icon which is slightly more visually appropriate. Also its tooltip needs to start with an action verb and say something like "Choose locations". On 11/9/22 15:00, Devin wrote: Hi everyone, I would like to put kweather through kdereview: https://invent.kde.org/plasma-mobile/kweather KWeather is an application that can give simple weather information for different weather locations. Please note that KWeatherCore (the library the app depends on) has already passed kdereview. Thanks, Devin
Re: New repo in kdereview: KWeather
El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure:
> Hi everyone,
>
> I would like to put kweather through kdereview:
>
> https://invent.kde.org/plasma-mobile/kweather
>
> KWeather is an application that can give simple weather information
> for different weather locations. Please note that KWeatherCore (the
> library the app depends on) has already passed kdereview.
There's potentially overlapping text.
See https://i.imgur.com/BrOgi3A.png
The settings show untranslateable text, i.e.
MobileForm.FormComboBoxDelegate {
id: forecastStyleDropdown
text: i18n("Forecast Style")
currentValue: settingsModel.forecastStyle
Here settingsModel.forecastStyle is not i18n'ed
Not KWeather's fault but i just realized that Kirigami's about page doesn't
properly credit translators :/
Cheers,
Albert
>
> Thanks,
> Devin
Re: New repo in kdereview: KWeather
Hi, You are missing kirigami-addons and yes this should be marked in the cmakelists.txt file. Cheers, Carl Original Message On Nov 12, 2022, 20:14, Jeremy Whiting wrote: > Looks like it's got a runtime dependency on kirigami (Maybe that's expected > for plasma-mobile, not sure) > > Built it on laptop and got this from cmake: > > cmake .. > -- The C compiler identification is GNU 12.2.0 > -- The CXX compiler identification is GNU 12.2.0 > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Check for working C compiler: /usr/bin/cc - skipped > -- Detecting C compile features > -- Detecting C compile features - done > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Check for working CXX compiler: /usr/bin/c++ - skipped > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found > components: Interpreter > -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE) > CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 > (message): > Reuse tool not found, skipping test generation > Call Stack (most recent call first): > CMakeLists.txt:30 (include) > > -- Skipping execution of outbound license tests. > -- Installing in the same prefix as Qt, adopting their path scheme. > -- Setting build type to 'Debug' as none was specified. > -- Looking for __GLIBC__ > -- Looking for __GLIBC__ - found > -- Performing Test _OFFT_IS_64BIT > -- Performing Test _OFFT_IS_64BIT - Success > -- Performing Test HAVE_DATE_TIME > -- Performing Test HAVE_DATE_TIME - Success > -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found > version "5.99.0") > -- Found KF5Kirigami2: /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake > (found version "5.99.0") > -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1") > -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version > "5.99.0") > -- Found KF5CoreAddons: > /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version > "5.99.0") > -- Found KF5Notifications: > /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version > "5.99.0") > -- Found KF5: success (found suitable version "5.99.0", minimum required is > "5.90.0") found components: Config Kirigami2 I18n CoreAddons Notifications > -- Found X11: /usr/include > -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so > -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found > -- Looking for gethostbyname > -- Looking for gethostbyname - found > -- Looking for connect > -- Looking for connect - found > -- Looking for remove > -- Looking for remove - found > -- Looking for shmat > -- Looking for shmat - found > -- Looking for IceConnectionNumber in ICE > -- Looking for IceConnectionNumber in ICE - found > -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found > version "5.99.0") > -- Found KF5: success (found suitable version "5.99.0", minimum required is > "5.90.0") found components: Plasma > -- Found org.kde.kholidays-QMLModule: TRUE (found version "") > -- The following RUNTIME packages have been found: > > * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime > dependency. > > -- The following OPTIONAL packages have been found: > > * Python3 > Required to run tests of module ECMCheckOutboundLicense > * Qt5QuickCompiler > * KF5Package (required version >= 5.99.0) > * KF5Service (required version >= 5.99.0) > * Freetype > * PkgConfig > * Fontconfig > > -- The following REQUIRED packages have been found: > > * ECM (required version >= 5.90.0) > * Qt5Network (required version >= 5.15.7) > * Qt5QmlModels (required version >= 5.15.7) > * Qt5Quick > * Qt5Test > * Qt5Svg > * Qt5QuickControls2 > * Qt5Charts > * KF5Kirigami2 (required version >= 5.90.0) > * Gettext > * KF5I18n (required version >= 5.90.0) > * KF5Notifications (required version >= 5.90.0) > * KF5KWeatherCore (required version >= 0.6.0) > * KF5CoreAddons (required version >= 5.99.0) > * Qt5Gui (required version >= 5.15.2) > * Qt5Widgets (required version >= 5.15.2) > * KF5Plasma (required version >= 5.90.0) > * KF5 (required version >= 5.90.0) > * Qt5Qml > * Qt5Core > * Qt5 > > -- The following features have been disabled: > > * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX definitions > (requires reuse tool) > > -- The following OPTIONAL packages have not been found: > > * ReuseTool > Required to run tests of module ECMCheckOutboundLicense > > -- Configuring done > -- Generating done > -- Build files have been written to: > /home/jeremy/data/devel/kde/src/kde/plasma-mobile/kweather/build > > then it built and installed fine, but trying to run failed with this: > > kweather > QQmlApplicationEngine failed to load component > qrc:/qml/main.qml:163:26: Type SettingsDialog unavailable >
Re: New repo in kdereview: KWeather
Looks like it's got a runtime dependency on kirigami (Maybe that's expected for plasma-mobile, not sure) Built it on laptop and got this from cmake: cmake .. -- The C compiler identification is GNU 12.2.0 -- The CXX compiler identification is GNU 12.2.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found components: Interpreter -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE) CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 (message): Reuse tool not found, skipping test generation Call Stack (most recent call first): CMakeLists.txt:30 (include) -- Skipping execution of outbound license tests. -- Installing in the same prefix as Qt, adopting their path scheme. -- Setting build type to 'Debug' as none was specified. -- Looking for __GLIBC__ -- Looking for __GLIBC__ - found -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Performing Test HAVE_DATE_TIME -- Performing Test HAVE_DATE_TIME - Success -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.99.0") -- Found KF5Kirigami2: /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.99.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1") -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.99.0") -- Found KF5CoreAddons: /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.99.0") -- Found KF5Notifications: /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.99.0") -- Found KF5: success (found suitable version "5.99.0", minimum required is "5.90.0") found components: Config Kirigami2 I18n CoreAddons Notifications -- Found X11: /usr/include -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.99.0") -- Found KF5: success (found suitable version "5.99.0", minimum required is "5.90.0") found components: Plasma -- Found org.kde.kholidays-QMLModule: TRUE (found version "") -- The following RUNTIME packages have been found: * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime dependency. -- The following OPTIONAL packages have been found: * Python3 Required to run tests of module ECMCheckOutboundLicense * Qt5QuickCompiler * KF5Package (required version >= 5.99.0) * KF5Service (required version >= 5.99.0) * Freetype * PkgConfig * Fontconfig -- The following REQUIRED packages have been found: * ECM (required version >= 5.90.0) * Qt5Network (required version >= 5.15.7) * Qt5QmlModels (required version >= 5.15.7) * Qt5Quick * Qt5Test * Qt5Svg * Qt5QuickControls2 * Qt5Charts * KF5Kirigami2 (required version >= 5.90.0) * Gettext * KF5I18n (required version >= 5.90.0) * KF5Notifications (required version >= 5.90.0) * KF5KWeatherCore (required version >= 0.6.0) * KF5CoreAddons (required version >= 5.99.0) * Qt5Gui (required version >= 5.15.2) * Qt5Widgets (required version >= 5.15.2) * KF5Plasma (required version >= 5.90.0) * KF5 (required version >= 5.90.0) * Qt5Qml * Qt5Core * Qt5 -- The following features have been disabled: * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX definitions (requires reuse tool) -- The following OPTIONAL packages have not been found: * ReuseTool Required to run tests of module ECMCheckOutboundLicense -- Configuring done -- Generating done -- Build files have been written to: /home/jeremy/data/devel/kde/src/kde/plasma-mobile/kweather/build then it built and installed fine, but trying to run failed with this: kweather QQmlApplicationEngine failed to load component qrc:/qml/main.qml:163:26: Type SettingsDialog unavailable qrc:/qml/settings/SettingsDialog.qml:33:22: Type SettingsComponent unavailable qrc:/qml/settings/SettingsComponent.qml:13:1: module "org.kde.kirigamiaddons.labs.mobileform" is not installed maybe cmake should have said it depends on kirigami? On Wed, Nov 9, 2022 at 3:00 PM Devin wrote: > Hi everyone, > > I would like to put kweather through kdereview: > > https://invent.kde.org/plasma-mobile/kweather > > KWeather is an application that can give simple weather
Re: New repo in kdereview: KWeather
> Only nitpick I found as a user was that it's a bit weird that Settings -> > About changes the main window instead of showing about data in the little > settings window. I would suggest making About be one of the buttons on the > main window, or showing the about data in the settings window. I guess I can make the about page a popup as well, thanks! Regards, Devin On Wed, Nov 9, 2022 at 5:37 PM Jeremy Whiting wrote: > > After installing kirigami-addons it runs fine, adding my location went > smooth, etc. Only nitpick I found as a user was that it's a bit weird that > Settings -> About changes the main window instead of showing about data in > the little settings window. I would suggest making About be one of the > buttons on the main window, or showing the about data in the settings window. > > On Wed, Nov 9, 2022 at 3:31 PM Jeremy Whiting > wrote: >> >> Looks like it's got a runtime dependency on kirigami (Maybe that's expected >> for plasma-mobile, not sure) >> >> Built it on laptop and got this from cmake: >> >> cmake .. >> -- The C compiler identification is GNU 12.2.0 >> -- The CXX compiler identification is GNU 12.2.0 >> -- Detecting C compiler ABI info >> -- Detecting C compiler ABI info - done >> -- Check for working C compiler: /usr/bin/cc - skipped >> -- Detecting C compile features >> -- Detecting C compile features - done >> -- Detecting CXX compiler ABI info >> -- Detecting CXX compiler ABI info - done >> -- Check for working CXX compiler: /usr/bin/c++ - skipped >> -- Detecting CXX compile features >> -- Detecting CXX compile features - done >> -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found >> components: Interpreter >> -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE) >> CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 >> (message): >> Reuse tool not found, skipping test generation >> Call Stack (most recent call first): >> CMakeLists.txt:30 (include) >> >> >> -- Skipping execution of outbound license tests. >> -- Installing in the same prefix as Qt, adopting their path scheme. >> -- Setting build type to 'Debug' as none was specified. >> -- Looking for __GLIBC__ >> -- Looking for __GLIBC__ - found >> -- Performing Test _OFFT_IS_64BIT >> -- Performing Test _OFFT_IS_64BIT - Success >> -- Performing Test HAVE_DATE_TIME >> -- Performing Test HAVE_DATE_TIME - Success >> -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found >> version "5.99.0") >> -- Found KF5Kirigami2: >> /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version >> "5.99.0") >> -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1") >> -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found >> version "5.99.0") >> -- Found KF5CoreAddons: >> /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version >> "5.99.0") >> -- Found KF5Notifications: >> /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found >> version "5.99.0") >> -- Found KF5: success (found suitable version "5.99.0", minimum required is >> "5.90.0") found components: Config Kirigami2 I18n CoreAddons Notifications >> -- Found X11: /usr/include >> -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so >> -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found >> -- Looking for gethostbyname >> -- Looking for gethostbyname - found >> -- Looking for connect >> -- Looking for connect - found >> -- Looking for remove >> -- Looking for remove - found >> -- Looking for shmat >> -- Looking for shmat - found >> -- Looking for IceConnectionNumber in ICE >> -- Looking for IceConnectionNumber in ICE - found >> -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found >> version "5.99.0") >> -- Found KF5: success (found suitable version "5.99.0", minimum required is >> "5.90.0") found components: Plasma >> -- Found org.kde.kholidays-QMLModule: TRUE (found version "") >> -- The following RUNTIME packages have been found: >> >> * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime >> dependency. >> >> -- The following OPTIONAL packages have been found: >> >> * Python3 >> Required to run tests of module ECMCheckOutboundLicense >> * Qt5QuickCompiler >> * KF5Package (required version >= 5.99.0) >> * KF5Service (required version >= 5.99.0) >> * Freetype >> * PkgConfig >> * Fontconfig >> >> -- The following REQUIRED packages have been found: >> >> * ECM (required version >= 5.90.0) >> * Qt5Network (required version >= 5.15.7) >> * Qt5QmlModels (required version >= 5.15.7) >> * Qt5Quick >> * Qt5Test >> * Qt5Svg >> * Qt5QuickControls2 >> * Qt5Charts >> * KF5Kirigami2 (required version >= 5.90.0) >> * Gettext >> * KF5I18n (required version >= 5.90.0) >> * KF5Notifications (required version >= 5.90.0) >> * KF5KWeatherCore (required version >= 0.6.0) >> * KF5CoreAddons (required version >= 5.99.0) >> * Qt5Gui (required version >= 5.15.2) >> * Qt5Widgets
Re: New repo in kdereview: KWeather
After installing kirigami-addons it runs fine, adding my location went smooth, etc. Only nitpick I found as a user was that it's a bit weird that Settings -> About changes the main window instead of showing about data in the little settings window. I would suggest making About be one of the buttons on the main window, or showing the about data in the settings window. On Wed, Nov 9, 2022 at 3:31 PM Jeremy Whiting wrote: > Looks like it's got a runtime dependency on kirigami (Maybe that's > expected for plasma-mobile, not sure) > > Built it on laptop and got this from cmake: > > cmake .. > -- The C compiler identification is GNU 12.2.0 > -- The CXX compiler identification is GNU 12.2.0 > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Check for working C compiler: /usr/bin/cc - skipped > -- Detecting C compile features > -- Detecting C compile features - done > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Check for working CXX compiler: /usr/bin/c++ - skipped > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found > components: Interpreter > -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE) > CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 > (message): > Reuse tool not found, skipping test generation > Call Stack (most recent call first): > CMakeLists.txt:30 (include) > > > -- Skipping execution of outbound license tests. > -- Installing in the same prefix as Qt, adopting their path scheme. > -- Setting build type to 'Debug' as none was specified. > -- Looking for __GLIBC__ > -- Looking for __GLIBC__ - found > -- Performing Test _OFFT_IS_64BIT > -- Performing Test _OFFT_IS_64BIT - Success > -- Performing Test HAVE_DATE_TIME > -- Performing Test HAVE_DATE_TIME - Success > -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake > (found version "5.99.0") > -- Found KF5Kirigami2: > /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version > "5.99.0") > -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1") > -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found > version "5.99.0") > -- Found KF5CoreAddons: > /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version > "5.99.0") > -- Found KF5Notifications: > /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found > version "5.99.0") > -- Found KF5: success (found suitable version "5.99.0", minimum required > is "5.90.0") found components: Config Kirigami2 I18n CoreAddons > Notifications > -- Found X11: /usr/include > -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so > -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - > found > -- Looking for gethostbyname > -- Looking for gethostbyname - found > -- Looking for connect > -- Looking for connect - found > -- Looking for remove > -- Looking for remove - found > -- Looking for shmat > -- Looking for shmat - found > -- Looking for IceConnectionNumber in ICE > -- Looking for IceConnectionNumber in ICE - found > -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake > (found version "5.99.0") > -- Found KF5: success (found suitable version "5.99.0", minimum required > is "5.90.0") found components: Plasma > -- Found org.kde.kholidays-QMLModule: TRUE (found version "") > -- The following RUNTIME packages have been found: > > * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime > dependency. > > -- The following OPTIONAL packages have been found: > > * Python3 > Required to run tests of module ECMCheckOutboundLicense > * Qt5QuickCompiler > * KF5Package (required version >= 5.99.0) > * KF5Service (required version >= 5.99.0) > * Freetype > * PkgConfig > * Fontconfig > > -- The following REQUIRED packages have been found: > > * ECM (required version >= 5.90.0) > * Qt5Network (required version >= 5.15.7) > * Qt5QmlModels (required version >= 5.15.7) > * Qt5Quick > * Qt5Test > * Qt5Svg > * Qt5QuickControls2 > * Qt5Charts > * KF5Kirigami2 (required version >= 5.90.0) > * Gettext > * KF5I18n (required version >= 5.90.0) > * KF5Notifications (required version >= 5.90.0) > * KF5KWeatherCore (required version >= 0.6.0) > * KF5CoreAddons (required version >= 5.99.0) > * Qt5Gui (required version >= 5.15.2) > * Qt5Widgets (required version >= 5.15.2) > * KF5Plasma (required version >= 5.90.0) > * KF5 (required version >= 5.90.0) > * Qt5Qml > * Qt5Core > * Qt5 > > -- The following features have been disabled: > > * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX > definitions (requires reuse tool) > > -- The following OPTIONAL packages have not been found: > > * ReuseTool > Required to run tests of module ECMCheckOutboundLicense > > -- Configuring done > -- Generating done > -- Build files have been written to: >
Re: New repo in kdereview: KWeather
Hi Jeremy, Looks like I forgot to add a CMake check for Kirigami Addons. It has been added now. KWeather has a runtime dependency on Kirigami Addons as well, not just Kirigami. Thanks, Devin On Wed, Nov 9, 2022 at 5:31 PM Jeremy Whiting wrote: > > Looks like it's got a runtime dependency on kirigami (Maybe that's expected > for plasma-mobile, not sure) > > Built it on laptop and got this from cmake: > > cmake .. > -- The C compiler identification is GNU 12.2.0 > -- The CXX compiler identification is GNU 12.2.0 > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Check for working C compiler: /usr/bin/cc - skipped > -- Detecting C compile features > -- Detecting C compile features - done > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Check for working CXX compiler: /usr/bin/c++ - skipped > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found > components: Interpreter > -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE) > CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 > (message): > Reuse tool not found, skipping test generation > Call Stack (most recent call first): > CMakeLists.txt:30 (include) > > > -- Skipping execution of outbound license tests. > -- Installing in the same prefix as Qt, adopting their path scheme. > -- Setting build type to 'Debug' as none was specified. > -- Looking for __GLIBC__ > -- Looking for __GLIBC__ - found > -- Performing Test _OFFT_IS_64BIT > -- Performing Test _OFFT_IS_64BIT - Success > -- Performing Test HAVE_DATE_TIME > -- Performing Test HAVE_DATE_TIME - Success > -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found > version "5.99.0") > -- Found KF5Kirigami2: /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake > (found version "5.99.0") > -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1") > -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version > "5.99.0") > -- Found KF5CoreAddons: > /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version > "5.99.0") > -- Found KF5Notifications: > /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version > "5.99.0") > -- Found KF5: success (found suitable version "5.99.0", minimum required is > "5.90.0") found components: Config Kirigami2 I18n CoreAddons Notifications > -- Found X11: /usr/include > -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so > -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found > -- Looking for gethostbyname > -- Looking for gethostbyname - found > -- Looking for connect > -- Looking for connect - found > -- Looking for remove > -- Looking for remove - found > -- Looking for shmat > -- Looking for shmat - found > -- Looking for IceConnectionNumber in ICE > -- Looking for IceConnectionNumber in ICE - found > -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found > version "5.99.0") > -- Found KF5: success (found suitable version "5.99.0", minimum required is > "5.90.0") found components: Plasma > -- Found org.kde.kholidays-QMLModule: TRUE (found version "") > -- The following RUNTIME packages have been found: > > * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime > dependency. > > -- The following OPTIONAL packages have been found: > > * Python3 > Required to run tests of module ECMCheckOutboundLicense > * Qt5QuickCompiler > * KF5Package (required version >= 5.99.0) > * KF5Service (required version >= 5.99.0) > * Freetype > * PkgConfig > * Fontconfig > > -- The following REQUIRED packages have been found: > > * ECM (required version >= 5.90.0) > * Qt5Network (required version >= 5.15.7) > * Qt5QmlModels (required version >= 5.15.7) > * Qt5Quick > * Qt5Test > * Qt5Svg > * Qt5QuickControls2 > * Qt5Charts > * KF5Kirigami2 (required version >= 5.90.0) > * Gettext > * KF5I18n (required version >= 5.90.0) > * KF5Notifications (required version >= 5.90.0) > * KF5KWeatherCore (required version >= 0.6.0) > * KF5CoreAddons (required version >= 5.99.0) > * Qt5Gui (required version >= 5.15.2) > * Qt5Widgets (required version >= 5.15.2) > * KF5Plasma (required version >= 5.90.0) > * KF5 (required version >= 5.90.0) > * Qt5Qml > * Qt5Core > * Qt5 > > -- The following features have been disabled: > > * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX definitions > (requires reuse tool) > > -- The following OPTIONAL packages have not been found: > > * ReuseTool > Required to run tests of module ECMCheckOutboundLicense > > -- Configuring done > -- Generating done > -- Build files have been written to: > /home/jeremy/data/devel/kde/src/kde/plasma-mobile/kweather/build > > then it built and installed fine, but trying to run failed with this: > > kweather > QQmlApplicationEngine failed to load component >
New repo in kdereview: KWeather
Hi everyone, I would like to put kweather through kdereview: https://invent.kde.org/plasma-mobile/kweather KWeather is an application that can give simple weather information for different weather locations. Please note that KWeatherCore (the library the app depends on) has already passed kdereview. Thanks, Devin
