Re: Porting to frameworks 2: libkcompactdisc

[Alexander Potashev]

2015-09-04 14:59 GMT+03:00 Friedrich W. H. Kossebau :
> Am Freitag, 4. September 2015, 02:28:49 schrieb Alexander Potashev:
>> I think the new fancy library naming scheme is
>> "libKF5Xxx.so.SOVERSION", regardless of it being part of KF5 or not.
>> Thus libKF5CompactDisc.so.5.
>
> If that really is the scheme (is that noted somewhere?), I would ask to
> reconsider it. For once, because it will result in clashes if a lib really
> becomes part of KF5 (and thus becomes part of other packages which might be
> installed together with a package where the lib was initially in, unless the
> lib is the only content of the package, so that can be completely replaced by
> the KF5 package)
>
> And also does it blur the hint by the name if something is part of KF5 or not.
> This lib may be using KF5, but it is not KF5. That namespace should be left to
> KF5 libs, like  libQt* is left to Qt libs.
>
> I would rather propose libkcompactdisc2.so.SOVERSION here, so namespacing by
> postfix number. There is also the pattern libkcompactdisc-qt5.so.SOVERSION,
> which strikes out the dep to qt5, but not my favourite due to that
> verboseness. :)

Hi Friedrich,

It won't clash when the library moves to KF5 if you bump the version
to the next KF5 version to be released (e.g. 5.15 at the moment). It's
even better to keep the same naming scheme when for the library when
it joins KF5 because dependent projects won't need adaptation to the
new library name.

And I guess library users won't care if the library is part of KF5 or not.

-- 
Alexander Potashev

Re: Porting to frameworks 2: libkcompactdisc

[Boudhayan Gupta]

Hi,

On 4 September 2015 at 04:58, Alexander Potashev  wrote:
> I think the new fancy library naming scheme is
> "libKF5Xxx.so.SOVERSION", regardless of it being part of KF5 or not.
> Thus libKF5CompactDisc.so.5.

As of now, the code in the frameworks branch builds libKF5CompactDisc.so.5.

I've set it this way for a few reasons:

1) From the perspective of a library user who's playing with and
getting to grips with how to use KDE libraries (and is not a seasoned
KDE dev), all he has to do is add "CompactDisc" to the
find_packages(KF5) line. Purely from the point of a library user, this
is much easier to do.

2) libKF5Screen does it this way and adding it to a project is a
breeze (see point 1).

3) This way, the library is co-installable with the KDE4 version.

The main plus point is number 1 - instead of thinking from the POV of
a KDE Multimedia developer, from the point of a guy who's just playing
with code this way is more intuitive, and we don't give up much in
order to keep it this way - all we need to ensure is that the version
number of this library stays equal to or greater than the minimum
required Frameworks version.

My two pennies.

-- Boudhayan

Re: Porting to frameworks 2: libkcompactdisc

[Friedrich W. H. Kossebau]

Am Freitag, 4. September 2015, 02:28:49 schrieb Alexander Potashev:
> 2015-09-04 0:49 GMT+03:00 Jeremy Whiting :
> > Second project I took a quick stab at libkcompactdisc which
> > audiocd-kio will need (which amarok will need for playing audio cds
> > once it's ported to qt5/kf5 too). I pushed to a frameworks branch and
> > it builds, but the resulting library is called
> > libkcompactdisc.so.SOVERSION. I guess we need to set a specific
> > version for this library, probably bumped from what the old
> > qt4/kdelibs4 version was?
> 
> Hi Jeremy,
> 
> I think the new fancy library naming scheme is
> "libKF5Xxx.so.SOVERSION", regardless of it being part of KF5 or not.
> Thus libKF5CompactDisc.so.5.

If that really is the scheme (is that noted somewhere?), I would ask to 
reconsider it. For once, because it will result in clashes if a lib really 
becomes part of KF5 (and thus becomes part of other packages which might be 
installed together with a package where the lib was initially in, unless the 
lib is the only content of the package, so that can be completely replaced by 
the KF5 package)

And also does it blur the hint by the name if something is part of KF5 or not. 
This lib may be using KF5, but it is not KF5. That namespace should be left to 
KF5 libs, like  libQt* is left to Qt libs.

I would rather propose libkcompactdisc2.so.SOVERSION here, so namespacing by 
postfix number. There is also the pattern libkcompactdisc-qt5.so.SOVERSION, 
which strikes out the dep to qt5, but not my favourite due to that 
verboseness. :)

Cheers
Friedrich

Porting to frameworks 2: libkcompactdisc

[Jeremy Whiting]

Hey all,

Second project I took a quick stab at libkcompactdisc which
audiocd-kio will need (which amarok will need for playing audio cds
once it's ported to qt5/kf5 too). I pushed to a frameworks branch and
it builds, but the resulting library is called
libkcompactdisc.so.SOVERSION. I guess we need to set a specific
version for this library, probably bumped from what the old
qt4/kdelibs4 version was?

This seems to be a pretty small library that would be a good fit for
anyone that wants to get started maintaining something useful but not
very complex. Any takers?

BR,
Jeremy

Re: Porting to frameworks 2: libkcompactdisc

[Boudhayan Gupta]

Hi Jeremy,

On 4 September 2015 at 03:19, Jeremy Whiting  wrote:
> This seems to be a pretty small library that would be a good fit for
> anyone that wants to get started maintaining something useful but not
> very complex. Any takers?

I'd like to get my feet wet in maintaining a project that I did not
code from scratch. I'd like to volunteer for this, but only if it's
fine if I make minor booboos along the way (of course I'll fix them
once someone gives me a heads up where I've gone wrong :-))

I did take a look at the code, it's not too overwhelming for me to get
up to speed with. I don't have any imaginative ideas for this library
though, so if anyone has grand plans for this, they should take up
maintainership instead, not me.

Cheers,
Boudhayan

Re: Porting to frameworks 2: libkcompactdisc

[Alexander Potashev]

2015-09-04 0:49 GMT+03:00 Jeremy Whiting :
> Second project I took a quick stab at libkcompactdisc which
> audiocd-kio will need (which amarok will need for playing audio cds
> once it's ported to qt5/kf5 too). I pushed to a frameworks branch and
> it builds, but the resulting library is called
> libkcompactdisc.so.SOVERSION. I guess we need to set a specific
> version for this library, probably bumped from what the old
> qt4/kdelibs4 version was?

Hi Jeremy,

I think the new fancy library naming scheme is
"libKF5Xxx.so.SOVERSION", regardless of it being part of KF5 or not.
Thus libKF5CompactDisc.so.5.

-- 
Alexander Potashev

Re: Porting to frameworks 2: libkcompactdisc

[Jeremy Whiting]

Boudhayan,

Welcome.

On Thu, Sep 3, 2015 at 4:43 PM, Boudhayan Gupta  wrote:
> Hi Jeremy,
>
> On 4 September 2015 at 03:19, Jeremy Whiting  wrote:
>> This seems to be a pretty small library that would be a good fit for
>> anyone that wants to get started maintaining something useful but not
>> very complex. Any takers?
>
> I'd like to get my feet wet in maintaining a project that I did not
> code from scratch. I'd like to volunteer for this, but only if it's
> fine if I make minor booboos along the way (of course I'll fix them
> once someone gives me a heads up where I've gone wrong :-))

Yep, KDE is a community. If something gets broken you'll find out
about it one way or another :)
>
> I did take a look at the code, it's not too overwhelming for me to get
> up to speed with. I don't have any imaginative ideas for this library
> though, so if anyone has grand plans for this, they should take up
> maintainership instead, not me.

Please do. If someone else has big plans for it they can come along
and help too.

BR,
Jeremy

>
> Cheers,
> Boudhayan

Re: Porting to frameworks 2: libkcompactdisc

[Boudhayan Gupta]

On 4 September 2015 at 04:17, Jeremy Whiting  wrote:
> Please do. If someone else has big plans for it they can come along
> and help too.

Right then. What next - do I file a sysadmin request for transfer of
maintainership at projects.k.o and bugs.k.o?

-- Boudhayan