Re: RKWard is in kdereview - again

2023-07-04 Thread Jonathan Riddell
I've created an issue for the kdereview process https://invent.kde.org/education/rkward/-/issues/23 Jonathan On Sat, 26 Mar 2022 at 20:34, Thomas Friedrichsmeier < thomas.friedrichsme...@kdemail.net> wrote: > Hi! > > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on

Re: RKWard is in kdereview - again

2022-04-27 Thread Thomas Friedrichsmeier
Hi, On Wed, 27 Apr 2022 16:09:51 +0200 Thierry Thomas wrote: > I just upgraded RKWard to 0.7.3 (just locally, not yet in the ports > tree), and the patch of FindR.cmake is no more necessary. > > It builds and installs clearly, but I noticed 2 problems: > > 1- the tests do not run: > > >

Re: RKWard is in kdereview - again

2022-04-27 Thread Thierry Thomas
Hello, Le lun. 28 mars 22 à 16:53:28 +0200, Adriaan de Groot écrivait : > > RKWard is used productively on Linux/BSD, Mac, and Windows. > > Congratulations! RKWard has been packaged on FreeBSD for a long time already > (although it's only at version 0.7.1, not the latest release -- cc'ing

Re: RKWard is in kdereview - again

2022-03-30 Thread Nicolas Fella
On 3/30/22 17:55, Thomas Friedrichsmeier wrote: An update and some questions: Am Mon, 28 Mar 2022 15:39:55 +0200 schrieb Nicolas Fella : [...] - Consider adding a color scheme selector (KColorSchemeManager) to the menu. On Windows that gives you dark mode support for free (this only really

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier
Am Wed, 30 Mar 2022 17:55:12 +0200 schrieb Thomas Friedrichsmeier : [...] > What's troubling me more is that QWebEngineView (used, among other > things, for Help->Help on RKWard) does not adapt to the color theme at > all. I tried adding CSS rules (@media (prefers-color-scheme: dark) > {...}), but

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier
An update and some questions: Am Mon, 28 Mar 2022 15:39:55 +0200 schrieb Nicolas Fella : [...] > - Consider adding a color scheme selector (KColorSchemeManager) to the > menu. On Windows that gives you dark mode support for free (this only > really works nicely when using Breeze QStyle). See >

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Monday, 28 March 2022 17:39:17 CEST Thomas Friedrichsmeier wrote: > On Mon, 28 Mar 2022 17:09:44 +0200 > Nicolas Fella wrote: > [...] > > > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > > presumably

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 17:09:44 +0200 Nicolas Fella wrote: [...] > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > presumably due to having a different tar implementation than Linux. Sweet! > I'd appreciate

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 00:09:38 +0200 Albert Astals Cid wrote: [...] > Results of running clang-tidy with some of my favorite options > attached. Thanks! > The first group [bugprone-integer-division] seems an actual bug since >double RKGraphicsDeviceFrontendTransmitter::lwdscale = 72/96; >

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella
On 3/28/22 16:53, Adriaan de Groot wrote: On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: KDE.org has been our home for a 7.5(!) years, now (after over a decade on sourceforge), but we still haven't left playground... After a lot of procrastination on that matter, a

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
Hi, On Mon, 28 Mar 2022 15:39:55 +0200 Nicolas Fella wrote: > I recently used RKWard for my Master Thesis, cool project! thanks! > A couple of observations: > > - CommitPolicy.txt still mentions Phabricator, that should point to > Gitlab instead Done. > - CommitPolicy.txt mentions Ubuntu

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on sourceforge), but we still haven't left playground... After a > lot of procrastination on that matter, a previous review failed due to > lack of time

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella
Hi, I recently used RKWard for my Master Thesis, cool project! A couple of observations: - CommitPolicy.txt still mentions Phabricator, that should point to Gitlab instead - CommitPolicy.txt mentions Ubuntu Trusty as base for requirements, that is *ancient* by now, maybe 20.04 would be a more

Re: RKWard is in kdereview - again

2022-03-27 Thread Albert Astals Cid
El dilluns, 28 de març de 2022, a les 0:09:38 (CEST), Albert Astals Cid va escriure: > El dissabte, 26 de març de 2022, a les 21:34:06 (CEST), Thomas > Friedrichsmeier va escriure: > > Hi! > > > > KDE.org has been our home for a 7.5(!) years, now (after over a > > decade on sourceforge), but we

Re: RKWard is in kdereview - again

2022-03-27 Thread Albert Astals Cid
El dissabte, 26 de març de 2022, a les 21:34:06 (CEST), Thomas Friedrichsmeier va escriure: > Hi! > > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on sourceforge), but we still haven't left playground... After a > lot of procrastination on that matter, a previous

RKWard is in kdereview - again

2022-03-26 Thread Thomas Friedrichsmeier
Hi! KDE.org has been our home for a 7.5(!) years, now (after over a decade on sourceforge), but we still haven't left playground... After a lot of procrastination on that matter, a previous review failed due to lack of time on my part. Sorry! Now, finally, I'd like to ask you to start reviewing

Re: RKWard is in kdereview

2019-04-22 Thread Jonathan Riddell
I've now moved this back to playground/edu/rkward as there had not been movement on all the issues people had brought up and kdereview should only last a couple months at most. It would be great to see RKWard brought back through kdereview and driven to release soon as it looks like a worthy

Re: RKWard is in kdereview

2018-11-14 Thread Lisandro Damián Nicanor Pérez Meyer
Hi, and sorry for the too late reply. El miércoles, 10 de octubre de 2018 11:53:59 -03 Thomas Friedrichsmeier escribió: [snip] > > It depends on WebKit which is not supported, could this be ported to > > WebEngine? > > We're in a somewhat uncomfortable situation, here, as we're currently >

Re: RKWard is in kdereview

2018-11-02 Thread Jonathan Riddell
There's no appstream metainfo file nor product-screenshot https://community.kde.org/Guidelines_and_HOWTOs/AppStream Jonathan On Sat, 6 Oct 2018 at 14:47, Thomas Friedrichsmeier wrote: > > Hi! > > KDE.org has been our home for a almost four years, now (after over a > decade on sourceforge), but

Re: RKWard is in kdereview

2018-10-18 Thread Scarlett Clark
Yes, I have already begun the process of taking this over in debian official. Cheers, Scarlett On Mon, Oct 15, 2018 at 2:24 AM Jonathan Riddell wrote: > On Fri, Oct 12, 2018 at 10:03:16PM +0200, Thomas Friedrichsmeier wrote: > > Ok, will do. It may take me a while, though, as I'll have to be

Re: RKWard is in kdereview

2018-10-15 Thread Jonathan Riddell
On Fri, Oct 12, 2018 at 10:03:16PM +0200, Thomas Friedrichsmeier wrote: > Ok, will do. It may take me a while, though, as I'll have to be careful > not to break our automated builds on our Ubuntu PPAs (as pointed out by > Meik). But ideally, I'd also like to combine this step with handing > over

Re: RKWard is in kdereview

2018-10-13 Thread meik michalke
hi, Am Freitag, 12. Oktober 2018, 22:03:16 CEST schrieb Thomas Friedrichsmeier: > 1. When invoking RKWard from the Application Menu, always start a new > instance. > 2. When invoking RKWard from Open With..., always open the file in an > existing RKWard instance (if any). > > We already have a

Re: RKWard is in kdereview

2018-10-13 Thread meik michalke
hi, just two small suggestions: Am Mittwoch, 10. Oktober 2018, 16:53:59 CEST schrieb Thomas Friedrichsmeier: > > The .desktop files call it a "GUI for R" which is not a great > > description, everything in the menu is a GUI. I recommend "R > > Statistical Programming" or "IDE for R" maybe. > >

Re: RKWard is in kdereview

2018-10-12 Thread Thomas Baumgart
Hi, On Freitag, 12. Oktober 2018 22:03:16 CEST Thomas Friedrichsmeier wrote: [...] > > QGuiApplication should include ability for single instance application > > rather than having separate .desktop files for it. > > Not quite what we want. Having several instances is quite ok (one for > each

Re: RKWard is in kdereview

2018-10-12 Thread Thomas Friedrichsmeier
Hi, On Fri, 12 Oct 2018 18:04:45 +0100 Jonathan Riddell wrote: > I added it into Neon > https://packaging.neon.kde.org/neon-packaging/rkward.git/ > https://build.neon.kde.org/view/1%20release%20⛰/job/bionic_release_neon-packaging_rkward/ thanks! > It's the norm for Debian packages to have

Re: RKWard is in kdereview

2018-10-12 Thread Jonathan Riddell
I added it into Neon https://packaging.neon.kde.org/neon-packaging/rkward.git/ https://build.neon.kde.org/view/1%20release%20⛰/job/bionic_release_neon-packaging_rkward/ It's the norm for Debian packages to have their packaging kept separate from the upstream source including for PPAs, keeping

Re: RKWard is in kdereview

2018-10-10 Thread Thomas Friedrichsmeier
On Wed, 10 Oct 2018 18:24:38 +0200 meik michalke wrote: > how would it affect our various PPAs if there was no debian/ > directory in the sources? In fact, we'd have to keep the debian packaging somewhere, and "merge" it into the sources while building (we do the same for translations in the

Re: RKWard is in kdereview

2018-10-10 Thread Thomas Friedrichsmeier
Hi! Thanks for your first feedback items. I'll try to respond to everything, eventually, but I'm probably not going to be too fast. (Albert: I'll get back to your items!) On Wed, 10 Oct 2018 11:21:05 +0100 Jonathan Riddell wrote: > It installs two desktop files which creates duplicate menu

Re: RKWard is in kdereview

2018-10-09 Thread Luca Beltrame
Il giorno Sat, 6 Oct 2018 15:45:39 +0200 Thomas Friedrichsmeier ha scritto: > final step: Today I'd like to ask you to start reviewing RKWard for > inclusion into exragear (coming from playground). As a longtime user of rkward (since the KDE 3 times) and as someone who still uses it for his day

Re: RKWard is in kdereview

2018-10-09 Thread Albert Astals Cid
El dissabte, 6 d’octubre de 2018, a les 15:45:39 CEST, Thomas Friedrichsmeier va escriure: > Hi! > > KDE.org has been our home for a almost four years, now (after over a > decade on sourceforge), but somehow I've kept procrastinating on the > final step: Today I'd like to ask you to start

RKWard is in kdereview

2018-10-06 Thread Thomas Friedrichsmeier
Hi! KDE.org has been our home for a almost four years, now (after over a decade on sourceforge), but somehow I've kept procrastinating on the final step: Today I'd like to ask you to start reviewing RKWard for inclusion into exragear (coming from playground). RKWard is an easy to use and easily