Re: Review Request: Apper on kdereview

2012-06-05 Thread Daniel Nicoletti
Hi, it's been 15 days since I've asked for the review, and we have fixed all the issues so far, should I ask kdesysadmin for the move now? Thanks, Daniel.

Re: Review Request: Apper on kdereview

2012-05-24 Thread Matthias Klumpp
Hi! @Albert: Isn't this the line? https://projects.kde.org/projects/kdereview/apper/repository/revisions/master/entry/AppSetup/main.cpp#L44 (please tell me if there's something wrong ^^) @Burkhard: The files have been moved - but I think I copied the location scheme from another project, so this

Re: Review Request: Apper on kdereview

2012-05-24 Thread Burkhard Lück
Am Donnerstag, 24. Mai 2012, 17:07:20 schrieb Matthias Klumpp: Hi! @Albert: Isn't this the line? https://projects.kde.org/projects/kdereview/apper/repository/revisions/mast er/entry/AppSetup/main.cpp#L44 (please tell me if there's something wrong ^^) Afaik the insertCatalog() call is done

Re: Review Request: Apper on kdereview

2012-05-24 Thread Matthias Klumpp
Hi! 2012/5/24 Burkhard Lück lu...@hube-lueck.de: Am Donnerstag, 24. Mai 2012, 17:07:20 schrieb Matthias Klumpp: Hi! @Albert: Isn't this the line? https://projects.kde.org/projects/kdereview/apper/repository/revisions/mast er/entry/AppSetup/main.cpp#L44 (please tell me if there's something

Re: Review Request: Apper on kdereview

2012-05-23 Thread Matthias Klumpp
Hi! This issue has been fixed some time ago. Thanks for the hint! :) Matthias 2012/5/23 Albert Astals Cid aa...@kde.org: El Dilluns, 21 de maig de 2012, a les 18:31:25, Daniel Nicoletti va escriure: Hi, Apper is on playground probably since 2008, it's widely used nowadays so it doesn't

Re: Review Request: Apper on kdereview

2012-05-23 Thread Albert Astals Cid
El Dimecres, 23 de maig de 2012, a les 13:58:27, Matthias Klumpp va escriure: Hi! This issue has been fixed some time ago. I can't find where the apper catalog loaded in AppSetup, can you point me to it? Cheers, Albert Thanks for the hint! :) Matthias 2012/5/23 Albert Astals Cid

Re: Review Request: Apper on kdereview

2012-05-23 Thread Burkhard Lück
Am Montag, 21. Mai 2012, 23:31:25 schrieb Daniel Nicoletti: Hi, Apper is on playground probably since 2008, it's widely used nowadays so it doesn't make sense to keep it there anymore. So please review the code, make suggestions and such... Right now the code is at (I've asked kde

Review Request: Apper on kdereview

2012-05-22 Thread Daniel Nicoletti
Hi, Apper is on playground probably since 2008, it's widely used nowadays so it doesn't make sense to keep it there anymore. So please review the code, make suggestions and such... Right now the code is at (I've asked kde sysadmin to move to kdereview, but afaik it will only reflect the projects

Re: Review Request: Apper on kdereview

2012-05-22 Thread Laszlo Papp
Right now the code is at (I've asked kde sysadmin to move to kdereview, but afaik it will only reflect the projects url): https://projects.kde.org/projects/playground/sysadmin/apper/repository Yes, the repository can be found here while reviewing:

Re: Review Request: Apper on kdereview

2012-05-22 Thread Daniel Nicoletti
Extragear, as I depend on PackageKit releases this would be more flexible for me :) Best, 2012/5/22 Anne-Marie Mahfouf annemarie.mahf...@free.fr: On 05/21/2012 11:31 PM, Daniel Nicoletti wrote: Hi, Apper is on playground probably since 2008, it's widely used nowadays so it doesn't make

Re: Review Request: Apper on kdereview

2012-05-22 Thread Albert Astals Cid
El Dilluns, 21 de maig de 2012, a les 18:31:25, Daniel Nicoletti va escriure: Hi, Apper is on playground probably since 2008, it's widely used nowadays so it doesn't make sense to keep it there anymore. So please review the code, make suggestions and such... AppSetup doesn't seem to be