Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-02-06 Thread David Faure
On Wednesday 01 February 2012 19:25:13 Dawit A wrote: On Mon, Jan 30, 2012 at 4:48 AM, Thiago Macieira thi...@kde.org wrote: On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: Diffs - kio/bookmarks/kbookmarkmanager.cc d8a9cb7 kio/kio/fileundomanager.cpp

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-02-02 Thread Frank Reininghaus
Hi, Am 30. Januar 2012 10:48 schrieb Thiago Macieira: On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: Diffs -   kio/bookmarks/kbookmarkmanager.cc d8a9cb7   kio/kio/fileundomanager.cpp f580c29   kio/kio/scheduler.cpp 6b36d9d Diff:

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-02-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/#review10296 --- A very general rule to software development is: don't commit

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-02-01 Thread Dawit A
On Mon, Jan 30, 2012 at 4:48 AM, Thiago Macieira thi...@kde.org wrote: On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: Diffs -   kio/bookmarks/kbookmarkmanager.cc d8a9cb7   kio/kio/fileundomanager.cpp f580c29   kio/kio/scheduler.cpp 6b36d9d Diff:

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-01-30 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/#review10221 --- I think this is the same crash that happens every time in

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-01-30 Thread Thiago Macieira
On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: Diffs - kio/bookmarks/kbookmarkmanager.cc d8a9cb7 kio/kio/fileundomanager.cpp f580c29 kio/kio/scheduler.cpp 6b36d9d Diff: http://git.reviewboard.kde.org/r/100577/diff/diff Do you have a valgrind trace of the

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-01-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/ --- (Updated Jan. 30, 2012, 6:35 a.m.) Review request for kdelibs and Thiago

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-04-13 Thread Thiago Macieira
I can't reproduce the crash anymore. I'm getting a different error with Qt 4.8. It seems VLC is now trying to closeAllWindows after QApplication is gone. Em terça-feira, 12 de abril de 2011, às 22:22:10, Dawit Alemayehu escreveu: --- This

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-04-13 Thread Dawit A
On Wed, Apr 13, 2011 at 4:10 AM, Thiago Macieira thi...@kde.org wrote: I can't reproduce the crash anymore. I'm getting a different error with Qt 4.8. I still get the crash on exit using Qt 4.7.2, KDE 4.6.41 (lastest master) and VLC v1.1.9 by following the steps outlined in the following bug

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-04-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/ --- (Updated April 12, 2011, 10:22 p.m.) Review request for kdelibs and

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-03-26 Thread Dawit A
On Sat, Feb 5, 2011 at 2:46 PM, Thiago Macieira thi...@kde.org wrote: On Saturday, 5 de February de 2011 14:15:03 Dawit A wrote: On Sat, Feb 5, 2011 at 12:57 PM, Thiago Macieira thi...@kde.org wrote: On Saturday, 5 de February de 2011 17:39:35 Dawit Alemayehu wrote: was that in both cases

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-03-26 Thread Thiago Macieira
On Saturday, 26 de March de 2011 12:46:29 Dawit A wrote: On Sat, Feb 5, 2011 at 2:46 PM, Thiago Macieira thi...@kde.org wrote: No need, I designed K_GLOBAL_STATIC with Matthias Kretz back in the day. Anyway, I can reproduce the crash on my office computer, even when running the

Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-02-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/ --- Review request for kdelibs. Summary --- As described in the bug

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-02-05 Thread Dawit A
On Sat, Feb 5, 2011 at 12:57 PM, Thiago Macieira thi...@kde.org wrote: On Saturday, 5 de February de 2011 17:39:35 Dawit Alemayehu wrote: was that in both cases the backtrace shows QtDBus attempting to invoke or access some method or slot in the object that was just destroyed. At this That's

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-02-05 Thread Thiago Macieira
On Saturday, 5 de February de 2011 14:15:03 Dawit A wrote: On Sat, Feb 5, 2011 at 12:57 PM, Thiago Macieira thi...@kde.org wrote: On Saturday, 5 de February de 2011 17:39:35 Dawit Alemayehu wrote: was that in both cases the backtrace shows QtDBus attempting to invoke or access some method