Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review20539 --- Ship it! You were modifying a *copy* of the FtpEntry, so a

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review20555 --- This review has been submitted with commit

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-17 Thread Dawit Alemayehu
On Oct. 16, 2012, 11:50 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 1491 http://git.reviewboard.kde.org/r/106636/diff/3/?file=88065#file88065line1491 This is slow iteration, since it has to modify the container every time. There's no reentrancy here, why use this

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- (Updated Oct. 17, 2012, 8:48 p.m.) Review request for kdelibs and David

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review20451 --- kioslave/ftp/ftp.cpp

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-10 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- (Updated Oct. 10, 2012, 3:55 p.m.) Review request for kdelibs and David

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-02 Thread David Faure
On Oct. 1, 2012, 8:30 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2639 http://git.reviewboard.kde.org/r/106636/diff/2/?file=87785#file87785line2639 Does this really work? This method is being called in the middle of the parsing of list command output, so the output of the

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-02 Thread Dawit Alemayehu
On Oct. 1, 2012, 8:30 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2639 http://git.reviewboard.kde.org/r/106636/diff/2/?file=87785#file87785line2639 Does this really work? This method is being called in the middle of the parsing of list command output, so the output of the

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review19675 --- kioslave/ftp/ftp.cpp

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-01 Thread Dawit Alemayehu
On Oct. 1, 2012, 8:30 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2639 http://git.reviewboard.kde.org/r/106636/diff/2/?file=87785#file87785line2639 Does this really work? This method is being called in the middle of the parsing of list command output, so the output of the

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- (Updated Oct. 2, 2012, 4:08 a.m.) Review request for kdelibs and David

Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-09-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- Review request for kdelibs and David Faure. Description --- The