Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104973/ --- (Updated May 24, 2012, 9:50 a.m.) Review request for kdelibs and Plasma.

Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104973/#review14082 --- Does this have unit tests? Would make sense to add a new one

Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-23 Thread Aurélien Gâteau
On May 23, 2012, 1:06 p.m., Albert Astals Cid wrote: Does this have unit tests? Would make sense to add a new one forcing this behaviour? What about docs? Should any doc be fixed/improved mentioning the behaviour? There is no test at the moment for the RunnerManager class. Docs does

Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104973/ --- Review request for kdelibs. Description --- When