Re: Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-21 Thread David Jarvie
On Nov. 20, 2011, 10:07 p.m., Albert Astals Cid wrote: This patch modifies the behaviour, maybe it is better if you change KDateComboBox::NoneKeyword to KDateComboBox::NoNoneKeyword And adapt the if accordingly? This way there is no behaviour change at all and makes old

Re: Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/#review8351 --- This patch modifies the behaviour, maybe it is better if you

Re: Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-17 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/#review8267 --- From a pure perspective of the code it is a +1 from me. I would

Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-09 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/ --- Review request for kdelibs and John Layt. Description ---