Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-29 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/#review6927 --- Ship it! Ship It! - Andreas Hartmetz On Sept. 25, 2011,

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-29 Thread Andreas Hartmetz
On Sept. 25, 2011, 2:20 p.m., Andreas Hartmetz wrote: I'd actually be interested to hear which testing you did. The ResolveHostNamesBeforeProxyCheck option seems strange. In which situations is this supposed to be set / not set? Dawit Alemayehu wrote: The

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/#review6937 --- This review has been submitted with commit

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-25 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/#review6796 --- I'd actually be interested to hear which testing you did. The

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/ --- (Updated Sept. 25, 2011, 4:15 p.m.) Review request for kdelibs. Changes

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-25 Thread Dawit Alemayehu
On Sept. 25, 2011, 2:20 p.m., Andreas Hartmetz wrote: I'd actually be interested to hear which testing you did. The ResolveHostNamesBeforeProxyCheck option seems strange. In which situations is this supposed to be set / not set? The ResolveHostNamesBeforeProxyCheck option is used to

Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/ --- Review request for kdelibs. Summary --- This patch is the 4th in the