Re: Review Request: data: protocol: don't treat fragments as part of the data

2012-04-26 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/ --- (Updated April 26, 2012, 4:31 p.m.) Review request for kdelibs. Changes

Re: Review Request: data: protocol: don't treat fragments as part of the data

2012-04-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/#review12933 --- Ship it! Ship It! - David Faure On April 26, 2012, 4:31

Re: Review Request: data: protocol: don't treat fragments as part of the data

2012-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/#review12940 --- This review has been submitted with commit

Re: Review Request: data: protocol: don't treat fragments as part of the data

2012-04-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/#review12612 --- kio/kio/dataprotocol.cpp

Re: Review Request: data: protocol: don't treat fragments as part of the data

2012-04-17 Thread Rolf Eike Beer
On April 17, 2012, 7:47 p.m., David Faure wrote: kio/kio/dataprotocol.cpp, line 181 http://git.reviewboard.kde.org/r/104624/diff/1/?file=56827#file56827line181 This looks wrong. If you call url.path(), you have a decoded string, so no need to call fromPercentEncoding on it. You