Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-28 Thread Christoph Feck
On Oct. 5, 2011, 11:30 a.m., David Faure wrote: Why the setMaxLength?? What if one wants to type in a long URL? Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large? Greg T wrote: indeed, the setmaxLength was

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-28 Thread Greg T
On Oct. 5, 2011, 11:30 a.m., David Faure wrote: Why the setMaxLength?? What if one wants to type in a long URL? Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large? Greg T wrote: indeed, the setmaxLength was

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread David Faure
On Oct. 5, 2011, 11:30 a.m., David Faure wrote: Why the setMaxLength?? What if one wants to type in a long URL? Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large? Greg T wrote: indeed, the setmaxLength was

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Peter Penz
On Oct. 5, 2011, 11:30 a.m., David Faure wrote: Why the setMaxLength?? What if one wants to type in a long URL? Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large? Greg T wrote: indeed, the setmaxLength was

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Christoph Feck
On Oct. 5, 2011, 11:30 a.m., David Faure wrote: Why the setMaxLength?? What if one wants to type in a long URL? Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large? Greg T wrote: indeed, the setmaxLength was

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 5, 2011, 6:22 p.m.) Review request for Dolphin and kdelibs.

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
On Oct. 5, 2011, 12:16 p.m., Christoph Feck wrote: Setting the width to 30+needed looks wrong, too. This means depending on the current URL, it could grow very big, or be too small. What I do in those cases is decide about a good average text length (for bookmarked Places URLs this

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
On Oct. 5, 2011, 8:53 p.m., Christoph Feck wrote: If you think 40 looks good, please commit :) Thanks. yeah it's fine. uhm...I don't have commit access. I'm a nobody ;). Can you do it for me? - Greg --- This is an automatically

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 4, 2011, 7:28 p.m.) Review request for kdelibs. Summary

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 4, 2011, 8:02 p.m.) Review request for Dolphin and kdelibs.

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/#review7119 --- Setting the width to 30+needed looks wrong, too. This means

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/#review7130 --- Ship it! If you think 40 looks good, please commit :) Thanks.