----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105155/ -----------------------------------------------------------
(Updated June 7, 2012, 2:44 p.m.) Review request for kdelibs and Konsole. Changes ------- Add kdelibs into groups Description (updated) ------- main change: 1. update the outdated inline document for kde_terminal_interface(which contained some signals that does not exist ever since KDE 4.0) 2. update the example code to make it really work and avoid using hardcoded library name 'libkonsolepart'. 3. update test/CMakeList.txt to make it stand-alone. I don't think that 'test' subfolder is ever used for building test case. Maybe it is more accurate to rename that folder to 'example'. But I could be wrong. This addresses bug 257350. http://bugs.kde.org/show_bug.cgi?id=257350 Diffs ----- interfaces/terminal/kde_terminal_interface.h 649d674 interfaces/terminal/test/CMakeLists.txt a0fa93a interfaces/terminal/test/main.h 8a3197a interfaces/terminal/test/main.cc 132cee1 Diff: http://git.reviewboard.kde.org/r/105155/diff/ Testing ------- The sample code works fine with kdelibs/4.8 and konsole built from master. Thanks, Jekyll Wu