Re: Review Request 106221: Mutex cleanup in KSharedDataCache

2014-06-30 Thread Vadim Zhukov

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106221/
---

(Updated July 1, 2014, 3:02 a.m.)


Status
--

This change has been discarded.


Review request for kdelibs and Michael Pyne.


Bugs: 305023
http://bugs.kde.org/show_bug.cgi?id=305023


Repository: kdelibs


Description
---

- Remove support for thread-shared-only locks: they do not help at all but 
makes app crash instead of slowly work; lack of decent locks to be resolved 
later.
- Add error checking with console printouts.
- Consistently use :: before global functions.

Probably failed mutexes should be destroyed in case of some errors, any 
thoughts?


Diffs
-

  kdecore/util/ConfigureChecks.cmake fe9f47e 
  kdecore/util/config-util.h.cmake 83ccdf7 
  kdecore/util/kshareddatacache.cpp 393902e 
  kdecore/util/kshareddatacache_p.h ec5a7a0 

Diff: https://git.reviewboard.kde.org/r/106221/diff/


Testing
---

On OpenBSD-CURRENT.


Thanks,

Vadim Zhukov



Re: Review Request 106221: Mutex cleanup in KSharedDataCache

2013-06-20 Thread Vadim Zhukov


 On April 7, 2013, 5:56 p.m., Albert Astals Cid wrote:
  Michael/Vadim what's the status of this?

This needs rebasing... I'm very busy those days, hope to have time for new 
patch at the weekend.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106221/#review30621
---


On Aug. 27, 2012, 12:50 p.m., Vadim Zhukov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/106221/
 ---
 
 (Updated Aug. 27, 2012, 12:50 p.m.)
 
 
 Review request for kdelibs and Michael Pyne.
 
 
 Description
 ---
 
 - Remove support for thread-shared-only locks: they do not help at all but 
 makes app crash instead of slowly work; lack of decent locks to be resolved 
 later.
 - Add error checking with console printouts.
 - Consistently use :: before global functions.
 
 Probably failed mutexes should be destroyed in case of some errors, any 
 thoughts?
 
 
 This addresses bug 305023.
 http://bugs.kde.org/show_bug.cgi?id=305023
 
 
 Diffs
 -
 
   kdecore/util/ConfigureChecks.cmake fe9f47e 
   kdecore/util/config-util.h.cmake 83ccdf7 
   kdecore/util/kshareddatacache.cpp 393902e 
   kdecore/util/kshareddatacache_p.h ec5a7a0 
 
 Diff: http://git.reviewboard.kde.org/r/106221/diff/
 
 
 Testing
 ---
 
 On OpenBSD-CURRENT.
 
 
 Thanks,
 
 Vadim Zhukov