Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2014-01-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/64/#review46953 --- This review has been submitted with commit

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2014-01-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/64/ --- (Updated Jan. 7, 2014, 5:50 a.m.) Status -- This change has been

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-08-15 Thread Albert Astals Cid
On June 21, 2013, 8:29 p.m., David Faure wrote: It's all commented out, but if that makes you happy, go for it :) (yes, make the function file-static first) Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? -

Review Request 111164: Create FavIconsModule namespace in kdebug

2013-06-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/64/ --- Review request for KDE Base Apps and David Faure. Description ---

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-06-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/64/ --- (Updated June 21, 2013, 6:55 p.m.) Review request for KDE Base Apps and

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-06-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/64/#review34836 --- lib/konq/favicons/favicons.cpp

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/64/#review34837 --- Ship it! It's all commented out, but if that makes you happy,