Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-22 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- (Updated Aug. 22, 2014, 3:31 p.m.) Status -- This change has been

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-18 Thread Hugo Pereira Da Costa
On June 26, 2014, 11:49 a.m., Hugo Pereira Da Costa wrote: Ship It! Ping ? Should I commit this myself ? - Hugo --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-18 Thread Bernd Steinhauser
On June 26, 2014, 11:49 a.m., Hugo Pereira Da Costa wrote: Ship It! Hugo Pereira Da Costa wrote: Ping ? Should I commit this myself ? Yes, please commit this. I don't have commit access myself. - Bernd --- This is an

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: looks good to me, +1. Please add Hugo Pereira Da Costa to the Review Request, though. The review request made me wonder whether we still need to find XLib in Oxygen, though. The parts shown only use XCB, so maybe we could just go

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017 --- Ship it! Ship It! - Hugo Pereira Da Costa On June 16,

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review60162 --- looks good to me, +1. Please add Hugo Pereira Da Costa to the

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-16 Thread Sebastian Kügler
On Sunday, June 15, 2014 12:47:57 Bernd Steinhauser wrote: No idea if kde-workspace is still the right group, if not, please change. You can use plasma as group. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-16 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- (Updated June 16, 2014, 2:07 p.m.) Review request for kde-workspace,

Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-15 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- Review request for kde-workspace. Repository: oxygen Description