Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75567 --- Ship it! Nice :) - David Faure On Feb. 6, 2015, 3:50

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-07 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/ --- (Updated Feb. 7, 2015, 8:56 p.m.) Status -- This change has been

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-07 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75577 ---

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-06 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/ --- (Updated Feb. 6, 2015, 3:50 p.m.) Review request for kde-workspace,

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-05 Thread David Narváez
On Feb. 1, 2015, 2:40 p.m., David Faure wrote: thumbnail/thumbnail.cpp, line 384 https://git.reviewboard.kde.org/r/122341/diff/1/?file=345985#file345985line384 Why this change? It's very wrong. The first arg is a mimetype, therefore you need KMimeTypeTrader.

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/ --- (Updated Feb. 5, 2015, 8:59 a.m.) Review request for kde-workspace,

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75469 --- thumbnail/thumbnail.cpp

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-02 Thread David Narváez
On Feb. 1, 2015, 2:40 p.m., David Faure wrote: thumbnail/thumbnail.cpp, line 384 https://git.reviewboard.kde.org/r/122341/diff/1/?file=345985#file345985line384 Why this change? It's very wrong. The first arg is a mimetype, therefore you need KMimeTypeTrader.

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-02 Thread David Faure
On fév. 1, 2015, 2:40 après-midi, David Faure wrote: thumbnail/thumbnail.cpp, line 384 https://git.reviewboard.kde.org/r/122341/diff/1/?file=345985#file345985line384 Why this change? It's very wrong. The first arg is a mimetype, therefore you need KMimeTypeTrader.

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75090 --- thumbnail/thumbnail.cpp

Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/ --- Review request for kde-workspace, Bhushan Shah and David Faure.

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75101 --- thumbnail/thumbnail.cpp

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/ --- (Updated Jan. 31, 2015, 11:07 p.m.) Review request for kde-workspace,