Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-18 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/ --- (Updated March 19, 2015, 2:20 a.m.) Status -- This change has been m

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review77642 --- Ship it! Ship It! - David Faure On March 17, 2015, 4:17 p.

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-17 Thread David Faure
> On March 17, 2015, 4:38 p.m., David Faure wrote: > > Ship It! Yes, both in kdelibs 4 and in the kio framework. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review776

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-16 Thread Luigi Toscano
> On Feb. 25, 2015, 6:57 p.m., Mark Gaiser wrote: > > I "think" this is OK, but just don't know. > > > > Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets > > another release. Either way, KIO frameworks [1] is where this should be > > applied to when you get a ship it.

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-16 Thread Stefan Brüns
> On Feb. 25, 2015, 5:57 p.m., Mark Gaiser wrote: > > I "think" this is OK, but just don't know. > > > > Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets > > another release. Either way, KIO frameworks [1] is where this should be > > applied to when you get a ship it.

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-02-27 Thread Stefan Brüns
> On Feb. 25, 2015, 5:57 p.m., Mark Gaiser wrote: > > I "think" this is OK, but just don't know. > > > > Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets > > another release. Either way, KIO frameworks [1] is where this should be > > applied to when you get a ship it.

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-02-25 Thread Luigi Toscano
> On Feb. 25, 2015, 6:57 p.m., Mark Gaiser wrote: > > I "think" this is OK, but just don't know. > > > > Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets > > another release. Either way, KIO frameworks [1] is where this should be > > applied to when you get a ship it.

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-02-25 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review76626 --- I "think" this is OK, but just don't know. Anyway, your diff

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-02-25 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review76619 --- Ping! - Stefan Brüns On Feb. 20, 2015, 9:28 p.m., Stefan Br

Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-02-21 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/ --- Review request for kdelibs. Bugs: 339193 http://bugs.kde.org/show_bug