Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Luigi Toscano
> On Dic. 30, 2015, 3:48 p.m., Luigi Toscano wrote: > > For the record: this was submitted to the knotifications frameworks, not to > > kdelibs. > > Martin Klapetek wrote: > Yes, sorry, I wrote it as a message here but now I see that it didn't get > through; I still have "Publish" here :S

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Luigi Toscano
> On Dic. 30, 2015, 3:48 p.m., Luigi Toscano wrote: > > For the record: this was submitted to the knotifications frameworks, not to > > kdelibs. > > Martin Klapetek wrote: > Yes, sorry, I wrote it as a message here but now I see that it didn't get > through; I still have "Publish" here :S

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
> On Dec. 30, 2015, 3:48 p.m., Luigi Toscano wrote: > > For the record: this was submitted to the knotifications frameworks, not to > > kdelibs. Yes, sorry, I wrote it as a message here but now I see that it didn't get through; I still have "Publish" here :S There are no more kdelibs

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
> On Dec. 30, 2015, 3:52 p.m., Kai Uwe Broulik wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 50 > > > > > > Note that this string can be shown to the user (we do this in Battery > >

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
> On Nov. 20, 2015, 8:51 p.m., Johannes Stefan wrote: > > Ping There are no more kdelibs releases planned, but I'll push this to frameworks for you. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
> On Dec. 30, 2015, 3:48 p.m., Luigi Toscano wrote: > > For the record: this was submitted to the knotifications frameworks, not to > > kdelibs. > > Martin Klapetek wrote: > Yes, sorry, I wrote it as a message here but now I see that it didn't get > through; I still have "Publish" here :S

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Kai Uwe Broulik
> On Dez. 30, 2015, 2:52 nachm., Kai Uwe Broulik wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 50 > > > > > > Note that this string can be shown to the user (we do this in Battery > >

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/#review90339 --- For the record: this was submitted to the knotifications

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/#review90341 --- kdeui/notifications/knotificationrestrictions.cpp (line 50)

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-29 Thread Johannes Stefan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/ --- (Updated Dec. 29, 2015, 8:54 p.m.) Status -- This change has been

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-20 Thread Johannes Stefan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/#review88660 --- Ping - Johannes Stefan On Nov. 1, 2015, 9:50 nachm.,

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/#review87941 --- Looks good to me

Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Johannes Stefan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/ --- Review request for kdelibs. Bugs: 334525

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Johannes Stefan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/ --- (Updated Nov. 1, 2015, 10:24 vorm.) Status -- This change has been

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Thomas Lübking
> On Nov. 1, 2015, 2:18 nachm., Christoph Feck wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 67 > > > > > > I am not sure all compilers support initialization of (non-static) > > members

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/#review87800 --- kdeui/notifications/knotificationrestrictions.cpp (line 67)

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Johannes Stefan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/ --- (Updated Nov. 1, 2015, 9:50 nachm.) Review request for kdelibs and