Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-23 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated Feb. 23, 2017, 1:12 p.m.) Status -- This change has been

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-22 Thread Pascal VITOUX
> On fév. 22, 2017, 12:31 matin, David Edmundson wrote: > > Ship It! I cannot commit myself (no account), so if everyone is ok, can someone do it for me ? I would be grateful - Pascal --- This is an automatically generated e-mail. To

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102571 --- Ship it! Ship It! - David Edmundson On Feb. 7, 2017,

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102567 --- Sebas can this be commited now or you have more concerns?

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-07 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated fév. 7, 2017, 10:20 matin) Review request for kde-workspace and

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102439 --- applets/systemloadviewer/package/contents/config/main.xml

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-06 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated fév. 6, 2017, 9:05 après-midi) Review request for kde-workspace

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102428 --- Could you please add screenshots of the new feature? This

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX
> On fév. 5, 2017, 10:07 après-midi, Dominik Haumann wrote: > > Looks good to me, would be nice to have another review by plasma > > developers. Can you commit yourself? > > > > Btw, this is unrelated, but maybe you are motivated to look into the bug > > list of the System Load Viewer applet:

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102422 --- Ship it! Looks good to me, would be nice to have another

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX
> On fév. 5, 2017, 2:52 après-midi, Dominik Haumann wrote: > > Essentially, the idea is good I think. Just tested this patch, and what I > > get looks like this: https://ibin.co/3BLqYW18K8p4.png > > In the "Compact Bar" mode, there are two bars for the cache monitors, and > > the right one

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated fév. 5, 2017, 7:11 après-midi) Review request for kde-workspace

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102413 --- Essentially, the idea is good I think. Just tested this

Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-03 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- Review request for kde-workspace and Plasma. Repository: