Ok, I cleaned this up, redid it basically with the suggestions from this
thread. I put a review request on reviewboard, and the code is in kdelibs
whiting/buildwithqt48 branch.
Enjoy,
Jeremy
On Mon, May 2, 2011 at 11:37 AM, Olivier Goffart ogoff...@kde.org wrote:
Le Monday 02 May 2011, David
Em Monday, 2 de May de 2011, às 14:59:02, David Faure escreveu:
+[...] XInternAtom( disp, QByteArray( QByteArray( msg_type_P ) + _BEGIN )
);
Ah it's because XInternAtom takes a const char*, so in theory this should
even be QByteArray( QByteArray( msg_type_P ) + _BEGIN ).constData()
You can
Le Monday 02 May 2011, David Faure a écrit :
Another one:
- envs QString::fromLatin1( QByteArray(DISPLAY=) + dpystring );
+envs QString::fromLatin1( QByteArray(QByteArray(DISPLAY=) +
dpystring) );
Should be QLatin1String(DISPLAY=) + QLatin1String(dpystring)
(Assuming dpystring
On Friday 29 April 2011, Jeremy Whiting wrote:
Since David added QT_USE_FAST_OPERATOR_PLUS to our build rules for kdelibs,
it wont build here.
Oops?
I've got a commit on the whiting/fixQByteArrays that
fixes this, but I'd like someone to review it before I merge to master.
Anyone got a
On Apr 29, 2011 6:26 PM, David Faure fa...@kde.org wrote:
On Friday 29 April 2011, Jeremy Whiting wrote:
Since David added QT_USE_FAST_OPERATOR_PLUS to our build rules for
kdelibs,
it wont build here.
Oops?
I've got a commit on the whiting/fixQByteArrays that
fixes this, but I'd like
