Re: Review of KGeoTag
You can change the metadata of your repository in repo-metadata[1] and make sure you send a mail to the translators mailing list and give them enough time to translate your application. See releasing software [2] Cheers, Carl [1]: https://invent.kde.org/sysadmin/repo-metadata [2]: https://community.kde.org/ReleasingSoftware Original Message On 27 Dec 2020, 2:18 PM, Tobias Leupold wrote: > Am Sonntag, 27. Dezember 2020, 00:21:14 CET schrieb Albert Astals Cid: >> El diumenge, 20 de desembre de 2020, a les 12:34:21 CET, Tobias Leupold va > escriure: >> > Dear core devs, >> > >> > is there anything left I can do so that KGeoTag can be moved to extragear/ >> > graphics? Thanks for supporting me and this project :-) >> >> I think no answer means you can assume everyone is happy :) >> > > This is nice :-) So KGeoTag can be moved? What di I have to do to request it? > Or can I even request it? ;-) > > I would tag a first release then soonish. > > Cheers, Tobias
Re: Review of KGeoTag
Am Sonntag, 27. Dezember 2020, 00:21:14 CET schrieb Albert Astals Cid: > El diumenge, 20 de desembre de 2020, a les 12:34:21 CET, Tobias Leupold va escriure: > > Dear core devs, > > > > is there anything left I can do so that KGeoTag can be moved to extragear/ > > graphics? Thanks for supporting me and this project :-) > > I think no answer means you can assume everyone is happy :) > This is nice :-) So KGeoTag can be moved? What di I have to do to request it? Or can I even request it? ;-) I would tag a first release then soonish. Cheers, Tobias
Re: Review of KGeoTag
El diumenge, 20 de desembre de 2020, a les 12:34:21 CET, Tobias Leupold va escriure: > Dear core devs, > > is there anything left I can do so that KGeoTag can be moved to extragear/ > graphics? Thanks for supporting me and this project :-) I think no answer means you can assume everyone is happy :) Cheers, Albert > > Merry Christmas for you all, > Tobias > > Am Dienstag, 1. Dezember 2020, 23:13:46 CET schrieb Albert Astals Cid: > > Awesome, thanks a lot for accommodating me :) > > > > Cheers, > > Albert > > > > >
Re: Review of KGeoTag
Dear core devs, is there anything left I can do so that KGeoTag can be moved to extragear/ graphics? Thanks for supporting me and this project :-) Merry Christmas for you all, Tobias Am Dienstag, 1. Dezember 2020, 23:13:46 CET schrieb Albert Astals Cid: > Awesome, thanks a lot for accommodating me :) > > Cheers, > Albert
Re: Review of KGeoTag
Wasn't too much effort ;-) Am Dienstag, 1. Dezember 2020, 23:13:46 CET schrieb Albert Astals Cid: > El dilluns, 30 de novembre de 2020, a les 0:01:26 CET, Tobias Leupold va escriure: > > Hi Albert :-) > > > > > > I can of course move to an KXmlGuiWindow if you think I really should. > > > > Please tell me! > > > > > > I'm a bit biased, but i think it's better to have, like what if i'm an > > > avid > > > user and want to set a shortcut to the add file or to Save images > > > actions? > > > > > > I can't because you're not using kxmlgui that gives me that for free. > > > > > > As said, it's not mandatory, but it gives niceties that makes apps "more > > > consistent" amongst eachother. > > > > Fair enough ;-) With 523fd1e4f0cf4853bb9a06ceea598e3d2b63ef33, I switched > > to a KXmlGuiWindow, and with 37bd97c9fc022ec2d6501d77049277833a87f927, I > > removed saving the window's geometry manually, as this is now handled > > automagically by the XML gui. > > > > > Also, you may want to add a KCrash::initialize call in your main to > > > initialize kcrash and get the nice "this thing crashed report a bug" > > > dialog. > > > > Added with cb2f3c4575872b95897ccff94d666a81484ea9c9 > > > > Cheers, Tobias > > Awesome, thanks a lot for accommodating me :) > > Cheers, > Albert
Re: Review of KGeoTag
El dilluns, 30 de novembre de 2020, a les 0:01:26 CET, Tobias Leupold va escriure: > Hi Albert :-) > > > > I can of course move to an KXmlGuiWindow if you think I really should. > > > Please tell me! > > > > I'm a bit biased, but i think it's better to have, like what if i'm an avid > > user and want to set a shortcut to the add file or to Save images actions? > > > > I can't because you're not using kxmlgui that gives me that for free. > > > > As said, it's not mandatory, but it gives niceties that makes apps "more > > consistent" amongst eachother. > > Fair enough ;-) With 523fd1e4f0cf4853bb9a06ceea598e3d2b63ef33, I switched to a > KXmlGuiWindow, and with 37bd97c9fc022ec2d6501d77049277833a87f927, I removed > saving the window's geometry manually, as this is now handled automagically by > the XML gui. > > > Also, you may want to add a KCrash::initialize call in your main to > > initialize kcrash and get the nice "this thing crashed report a bug" > > dialog. > > Added with cb2f3c4575872b95897ccff94d666a81484ea9c9 > > Cheers, Tobias Awesome, thanks a lot for accommodating me :) Cheers, Albert > > > >
Re: Review of KGeoTag
PS: With 64b932c4aba723868d58f6038a940cfe2342dbba to a487686da06ea76224144b362ec0704c8e506a5d, I also moved the configuration implementation from QSettings to KConfig, so that ~/.config/kgeotag/ kgeotag.conf isn't used anymore in favor of also and only using ~/.config/ kgeotagrc.
Re: Review of KGeoTag
Hi Albert :-) > > I can of course move to an KXmlGuiWindow if you think I really should. > > Please tell me! > > I'm a bit biased, but i think it's better to have, like what if i'm an avid > user and want to set a shortcut to the add file or to Save images actions? > > I can't because you're not using kxmlgui that gives me that for free. > > As said, it's not mandatory, but it gives niceties that makes apps "more > consistent" amongst eachother. Fair enough ;-) With 523fd1e4f0cf4853bb9a06ceea598e3d2b63ef33, I switched to a KXmlGuiWindow, and with 37bd97c9fc022ec2d6501d77049277833a87f927, I removed saving the window's geometry manually, as this is now handled automagically by the XML gui. > Also, you may want to add a KCrash::initialize call in your main to > initialize kcrash and get the nice "this thing crashed report a bug" > dialog. Added with cb2f3c4575872b95897ccff94d666a81484ea9c9 Cheers, Tobias
Re: Review of KGeoTag
El diumenge, 29 de novembre de 2020, a les 12:26:01 CET, Tobias Leupold va escriure: > Hi Albert! > > Thanks for your feedback :-) > > > It would be good if you could add a OARS https://hughsie.github.io/oars/ > > definition on the appdata.xml there's some stuff out there like flathub > > that enforces having one. > > I didn't know about this yet, but it surely won't hurt! Added with > b826d11b1099540879a7a5ca00d5fe1da9694a22. > > I don't think one would need anything but the empty tag here, as locations are > possibly exchanged with a server (when requesting altitude values), but not > necessarily the local address or such, and even if so, the server doesn't know > this and can't/doesn't relate it with any personal data, right? sounds reasonable. > > Would it make sense to make File->Add Images also accept folders in addition > > to individual files? > > Added an additional action to load all images from a directory with > c4f2c5e2ac7b776c63afb644a35bcd70f52fcd0c. > > Correct me if I'm wrong, but choosing either a directory or multiple files > from the same QFileDialog seems to be impossible or at least only achieveable > via hacks ... > > Is the "Add all images from directory" option okay for you? That's nice, thanks :) > > > I'd suggest using KStandardAction::preferences to create your configure > > action, so you get the default icon all apps get, same for > > KStandardAction::quit i guess. > > Changed with b9fddfe0ce04552e9286f55264d63e459efccf3f. > > I also added some more standard icons to the menu with > 18e305067ccaa1af78c24c7d97129def7fa67cc5. Cool, icons in menus make the app look a bit less dull :) > > > It's not mandatory, something for the future maybe? but i think it'd be > > nicer if you make your app use kxmlgui, so you don't have to create your > > own KHelpMenu by hand, and you get one one those configure shortcuts by > > free, etc. > > I thought about doing this, but the menu is quite small and most probably > won't grow much, also, there's no toolbar or such. > > So I was wondering if adding another abstraction level here would make things > actually more simple or more complicated ... I ended up with "for those few > actions, I can as well write it by hand". > > I can of course move to an KXmlGuiWindow if you think I really should. Please > tell me! I'm a bit biased, but i think it's better to have, like what if i'm an avid user and want to set a shortcut to the add file or to Save images actions? I can't because you're not using kxmlgui that gives me that for free. As said, it's not mandatory, but it gives niceties that makes apps "more consistent" amongst eachother. Also, you may want to add a KCrash::initialize call in your main to initialize kcrash and get the nice "this thing crashed report a bug" dialog. Cheers, Albert > > > You have a few signals marked as const, that is a bit weird > > > > https://invent.kde.org/sdk/clazy/-/blob/master/docs/checks/README-const-sig > > nal-or-slot.md > > Const declarations for signals are removed with > 042631ebc763ae704d067dfacc98a5979d357205. > > After quite some years with C++ and Qt, I still don't grasp all concepts ;-) > > > You also have a few methods marked as virtual and override, which is also a > > bit weird, since all overriden methods are virtual, so you don't need the > > virtual to be specified. > > Fixed with 77d7485ef7a3abab1495f93605d8235b7b5f80e3. > > After having read some docs about this (apparently for the first time), I's > clear that "virtual" is for the real initial virtual declaration and not for > the actual override function implementing it. > > Thanks for pointing this out! Maybe someday, I'll really know what I do when > coding C++ ;-) > > If there's still work to do, please let me know! > > Cheers, Tobias > > >
Re: Review of KGeoTag
Hi Albert! Thanks for your feedback :-) > It would be good if you could add a OARS https://hughsie.github.io/oars/ > definition on the appdata.xml there's some stuff out there like flathub > that enforces having one. I didn't know about this yet, but it surely won't hurt! Added with b826d11b1099540879a7a5ca00d5fe1da9694a22. I don't think one would need anything but the empty tag here, as locations are possibly exchanged with a server (when requesting altitude values), but not necessarily the local address or such, and even if so, the server doesn't know this and can't/doesn't relate it with any personal data, right? > Would it make sense to make File->Add Images also accept folders in addition > to individual files? Added an additional action to load all images from a directory with c4f2c5e2ac7b776c63afb644a35bcd70f52fcd0c. Correct me if I'm wrong, but choosing either a directory or multiple files from the same QFileDialog seems to be impossible or at least only achieveable via hacks ... Is the "Add all images from directory" option okay for you? > I'd suggest using KStandardAction::preferences to create your configure > action, so you get the default icon all apps get, same for > KStandardAction::quit i guess. Changed with b9fddfe0ce04552e9286f55264d63e459efccf3f. I also added some more standard icons to the menu with 18e305067ccaa1af78c24c7d97129def7fa67cc5. > It's not mandatory, something for the future maybe? but i think it'd be > nicer if you make your app use kxmlgui, so you don't have to create your > own KHelpMenu by hand, and you get one one those configure shortcuts by > free, etc. I thought about doing this, but the menu is quite small and most probably won't grow much, also, there's no toolbar or such. So I was wondering if adding another abstraction level here would make things actually more simple or more complicated ... I ended up with "for those few actions, I can as well write it by hand". I can of course move to an KXmlGuiWindow if you think I really should. Please tell me! > You have a few signals marked as const, that is a bit weird > > https://invent.kde.org/sdk/clazy/-/blob/master/docs/checks/README-const-sig > nal-or-slot.md Const declarations for signals are removed with 042631ebc763ae704d067dfacc98a5979d357205. After quite some years with C++ and Qt, I still don't grasp all concepts ;-) > You also have a few methods marked as virtual and override, which is also a > bit weird, since all overriden methods are virtual, so you don't need the > virtual to be specified. Fixed with 77d7485ef7a3abab1495f93605d8235b7b5f80e3. After having read some docs about this (apparently for the first time), I's clear that "virtual" is for the real initial virtual declaration and not for the actual override function implementing it. Thanks for pointing this out! Maybe someday, I'll really know what I do when coding C++ ;-) If there's still work to do, please let me know! Cheers, Tobias
Re: Review of KGeoTag
El dissabte, 28 de novembre de 2020, a les 14:02:28 CET, Tobias Leupold va escriure: > Dear KDE devs, > > two weeks ago, KGeoTag has been moved to kdereview. I would be very happy if > this could become an extragear/graphics app, just like KPhotoAlbum (I also > work on KPA). > > The purpose of KGeoTag is to be a convenient, stand-alone geotagging program > (but not more than this). Imo, we lack such an app at the latest since > Digikam's "geolocation" KIPI plugin has been gone (which was usable from > within KPA back then), without real nice alternatives for the Linux desktop. > > A description of the program can be found in the README at > https://invent.kde.org/graphics/kgeotag -- it's quite overseeable, but it > should be feature-complete (at least for a first release). > > I'm only a hobby programmer but I did my best to implement it in a decent way. > So ... if anybody wants to review it ... :-) It would be good if you could add a OARS https://hughsie.github.io/oars/ definition on the appdata.xml there's some stuff out there like flathub that enforces having one. Would it make sense to make File->Add Images also accept folders in addition to individual files? I'd suggest using KStandardAction::preferences to create your configure action, so you get the default icon all apps get, same for KStandardAction::quit i guess. It's not mandatory, something for the future maybe? but i think it'd be nicer if you make your app use kxmlgui, so you don't have to create your own KHelpMenu by hand, and you get one one those configure shortcuts by free, etc. You have a few signals marked as const, that is a bit weird https://invent.kde.org/sdk/clazy/-/blob/master/docs/checks/README-const-signal-or-slot.md You also have a few methods marked as virtual and override, which is also a bit weird, since all overriden methods are virtual, so you don't need the virtual to be specified. Cheers, Albert > > Cheers, Tobias > > > >
Review of KGeoTag
Dear KDE devs, two weeks ago, KGeoTag has been moved to kdereview. I would be very happy if this could become an extragear/graphics app, just like KPhotoAlbum (I also work on KPA). The purpose of KGeoTag is to be a convenient, stand-alone geotagging program (but not more than this). Imo, we lack such an app at the latest since Digikam's "geolocation" KIPI plugin has been gone (which was usable from within KPA back then), without real nice alternatives for the Linux desktop. A description of the program can be found in the README at https://invent.kde.org/graphics/kgeotag -- it's quite overseeable, but it should be feature-complete (at least for a first release). I'm only a hobby programmer but I did my best to implement it in a decent way. So ... if anybody wants to review it ... :-) Cheers, Tobias
