Re: Tokodon in KDE Review

2022-12-02 Thread Carl Schwan


On mardi 29 novembre 2022 à 12:28 AM, Albert Astals Cid  wrote:


> El dijous, 24 de novembre de 2022, a les 15:00:44 (CET), Carl Schwan va
> escriure:
> 
> > Hello everyone,
> > 
> > I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I
> > have been working for some time already. I already did some unstable
> > release and I would like to soon release the first stable release. The
> > source code is available here: https://invent.kde.org/network/tokodon/
> > 
> > It is still missing a lot of Mastodon features (lists, support for custom
> > emojies, displaying and sending polls, ...) but the current feature sets
> > make it usable already. And I am slowly adding more features.
> > 
> > Cheers,
> > Carl
> > 
> > PS: if someone has insight about this crash deep in the QML engine, I would
> > be welcome some help https://bugs.kde.org/show_bug.cgi?id=461882
> 
> 
> Crashes
> 
> $ tokodon
> Loading any accounts from settings.
> qrc:/content/ui/main.qml:74: TypeError: Cannot read property 'instanceName' of
> null
> Violació de segment (s'ha bolcat la memòria)
> 
> Backtrace https://pst.klgrth.io/paste/s87zy
> 
> You can see that if you add
> onCheckedChanged: console.log("BLO", checked);
> to notificationAction it will switch infinitely from true to false and and
> crash.

Thanks for the very helpful pointer and to Antonio for testing the fix,
this has now been fixed with 
https://invent.kde.org/network/tokodon/-/merge_requests/69

Cheers,
Carl

> 
> Cheers,
> Albert


Re: Tokodon in KDE Review

2022-12-02 Thread Carl Schwan
On mardi 29 novembre 2022 à 9:23 AM, Christophe Giboudeaux  
wrote:


> Hello,
> 
> On jeudi 24 novembre 2022 15:00:44 CET Carl Schwan wrote:
> 
> > Hello everyone,
> > 
> > I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I
> > have been working for some time already. I already did some unstable
> > release and I would like to soon release the first stable release. The
> > source code is available here: https://invent.kde.org/network/tokodon/
> 
> 
> The access token is leaked (along with a qdebug leftover):
> 8:53:15 - tokodon(11616) - unknown: XXX
> 8:53:15 - tokodon(11616) - unknown: [WEBSOCKET] Connecting to QUrl("wss://
> framapiaf.org/api/v1/streaming?access_token=p9M... [redacted] =user

Fixed and I also added a qdebug message handler in 
src/messagefiltercontainer.cpp
to filter any secret token from the logs.

> 
> tokodon currently crashes on startup, but the last time I tried, the
> spellchecking settings were not saved.

Spellchecking seems to be saved for me but I probably fixed it accidentally
a few weeks ago when porting to the MobileForm components.

Regarding the crash on startup, this might fix it:
https://invent.kde.org/network/tokodon/-/merge_requests/69

Unfortunately I still can't reproduce the bug, so I if you could test the MR
and tell me if this still crashes, I would be grateful.

Cheers,
Carl
 
> 
> Christophe
>


Re: Tokodon in KDE Review

2022-12-02 Thread Carl Schwan
On jeudi 24 novembre 2022 à 4:19 PM, Tobias Fella  wrote:

> Hi,
>
> - Reuse lint is almost happy, would be nice to complete that and have it in 
> the CI
>
> - As reported in 461846, some icons aren't visible

Should be fixed now too :)

> - The "Global" view doesn't open for me and complains
>
> qrc:/content/ui/main.qml:162: ReferenceError: TimelineType is not defined
>
> Other than that it works well :)
>
> Cheers,
>
> Tobias
>
> On 11/24/22 15:00, Carl Schwan wrote:
>
>> Hello everyone,
>>
>> I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I have
>> been working for some time already. I already did some unstable release and I
>> would like to soon release the first stable release. The source code
>> is available here:
>> https://invent.kde.org/network/tokodon/
>> It is still missing a lot of Mastodon features (lists, support for custom 
>> emojies,
>> displaying and sending polls, ...) but the current feature sets make it 
>> usable
>> already. And I am slowly adding more features.
>>
>> Cheers,
>> Carl
>>
>> PS: if someone has insight about this crash deep in the QML engine, I would 
>> be
>> welcome some help
>> https://bugs.kde.org/show_bug.cgi?id=461882

Re: Tokodon in KDE Review

2022-11-30 Thread Christophe Giboudeaux
Hello,

On jeudi 24 novembre 2022 15:00:44 CET Carl Schwan wrote:
> Hello everyone,
> 
> I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I
> have been working for some time already. I already did some unstable
> release and I would like to soon release the first stable release. The
> source code is available here: https://invent.kde.org/network/tokodon/
> 

The access token is leaked (along with a qdebug leftover):
8:53:15 - tokodon(11616) -  unknown: XXX
8:53:15 - tokodon(11616) -  unknown: [WEBSOCKET] Connecting to QUrl("wss://
framapiaf.org/api/v1/streaming?access_token=p9M... [redacted] =user

tokodon currently crashes on startup, but the last time  I tried, the 
spellchecking settings were not saved.

Christophe





Re: Tokodon in KDE Review

2022-11-28 Thread Albert Astals Cid
El dijous, 24 de novembre de 2022, a les 15:00:44 (CET), Carl Schwan va 
escriure:
> Hello everyone,
> 
> I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I
> have been working for some time already. I already did some unstable
> release and I would like to soon release the first stable release. The
> source code is available here: https://invent.kde.org/network/tokodon/
> 
> It is still missing a lot of Mastodon features (lists, support for custom
> emojies, displaying and sending polls, ...) but the current feature sets
> make it usable already. And I am slowly adding more features.
> 
> Cheers,
> Carl
> 
> PS: if someone has insight about this crash deep in the QML engine, I would
> be welcome some help https://bugs.kde.org/show_bug.cgi?id=461882

Crashes 

$ tokodon 
Loading any accounts from settings.
qrc:/content/ui/main.qml:74: TypeError: Cannot read property 'instanceName' of 
null
Violació de segment (s'ha bolcat la memòria)

Backtrace https://pst.klgrth.io/paste/s87zy

You can see that if you add 
onCheckedChanged: console.log("BLO", checked);
to notificationAction it will switch infinitely from true to false and and 
crash.

Cheers,
  Albert




Re: Tokodon in KDE Review

2022-11-25 Thread Carl Schwan
Le jeudi 24 novembre 2022 à 4:19 PM, Tobias Fella  a écrit :


> Hi,
> 
> - Reuse lint is almost happy, would be nice to complete that and have it in 
> the CI

Done :)

> 
> - As reported in 461846, some icons aren't visible

I can't reproduce :( the missing icons are in the qrc file, could you check
with gammaray if you can find them in the resources tab?
 
> - The "Global" view doesn't open for me and complains
> 
> qrc:/content/ui/main.qml:162: ReferenceError: TimelineType is not defined

Done :) This was caused by a recent refactor
> 
> Other than that it works well :)

Thanks :)
Cheers,
Carl
> 
> Cheers,
> 
> Tobias
> 
> 
> 
> On 11/24/22 15:00, Carl Schwan wrote:
> 
> > Hello everyone,
> > 
> > I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I 
> > have
> > been working for some time already. I already did some unstable release and 
> > I
> > would like to soon release the first stable release. The source code
> > is available here: https://invent.kde.org/network/tokodon/
> > 
> > It is still missing a lot of Mastodon features (lists, support for custom 
> > emojies,
> > displaying and sending polls, ...) but the current feature sets make it 
> > usable
> > already. And I am slowly adding more features.
> > 
> > Cheers,
> > Carl
> > 
> > PS: if someone has insight about this crash deep in the QML engine, I would 
> > be
> > welcome some help https://bugs.kde.org/show_bug.cgi?id=461882


Re: Tokodon in KDE Review

2022-11-24 Thread Tobias Fella

Hi,

- Reuse lint is almost happy, would be nice to complete that and have it 
in the CI


- As reported in 461846, some icons aren't visible

- The "Global" view doesn't open for me and complains

qrc:/content/ui/main.qml:162: ReferenceError: TimelineType is not defined



Other than that it works well :)

Cheers,

Tobias


On 11/24/22 15:00, Carl Schwan wrote:

Hello everyone,

I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I have
been working for some time already. I already did some unstable release and I
would like to soon release the first stable release. The source code
is available here:https://invent.kde.org/network/tokodon/

It is still missing a lot of Mastodon features (lists, support for custom 
emojies,
displaying and sending polls, ...) but the current feature sets make it usable
already. And I am slowly adding more features.

Cheers,
Carl

PS: if someone has insight about this crash deep in the QML engine, I would be
welcome some helphttps://bugs.kde.org/show_bug.cgi?id=461882

Tokodon in KDE Review

2022-11-24 Thread Carl Schwan
Hello everyone,

I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I have
been working for some time already. I already did some unstable release and I
would like to soon release the first stable release. The source code 
is available here: https://invent.kde.org/network/tokodon/

It is still missing a lot of Mastodon features (lists, support for custom 
emojies,
displaying and sending polls, ...) but the current feature sets make it usable
already. And I am slowly adding more features.

Cheers,
Carl

PS: if someone has insight about this crash deep in the QML engine, I would be
welcome some help https://bugs.kde.org/show_bug.cgi?id=461882