Re: kdelibs-4.14.35 bug report

2017-08-18 Thread Albert Astals Cid
El divendres, 18 d’agost de 2017, a les 7:25:44 CEST, David Binderman va escriure: > Hello there, > > Some suspicious code: > > [kdelibs-4.14.35/kde3support/kdeui/k3listview.cpp:505]: (style) Same > expression on both sides of '||'. > > Source code is > > if ( ca == Qt::AlignLeft || ca ==

kdelibs-4.14.35 bug report

2017-08-18 Thread David Binderman
Hello there, Some suspicious code: [kdelibs-4.14.35/kde3support/kdeui/k3listview.cpp:505]: (style) Same expression on both sides of '||'. Source code is if ( ca == Qt::AlignLeft || ca == Qt::AlignLeft ) { Maybe better code if ( ca == Qt::AlignLeft || ca == Qt::AlignRight ) {