Hey all,
In updating some frameworks I took a look at the kdelibs coding style
(Is there a frameworks coding style, if not maybe it should be
created?) and especially the Qt Includes section seems a bit backwards
from what I see in actual code in frameworks.
https://techbase.kde.org/Policies
not need to support both Qt4 and Qt5 and
thus to use module-less Qt includes?
For now it supports both, but it's very likely that by the end of january it
will be Qt5 only.
Or will the includes be if-def'ed? So will projects which refer to the
Kdelibs Coding Style need to add an exception
Kevin Ottens wrote:
We should push to use the class name only includes I think.
I agree.
We have a buildsystem that is good enough that we can specify the
directories to look for the 'class name' headers in, and it is in the
buildsystem that that stuff belongs.
See the kinds of practical
statements.
So will projects which refer to the Kdelibs Coding Style need to
add an exception to their rules for the includes, if they want to prepare
for Qt5?
Or does the rule need adaption?
Well, for frameworks that intend to be as close to Qt as possible they
should do the same
it
will be Qt5 only.
Or will the includes be if-def'ed? So will projects which refer to the
Kdelibs Coding Style need to add an exception to their rules for the
includes, if they want to prepare for Qt5?
Or does the rule need adaption?
With what I wrote above I think the natural conclusion
On Saturday, December 29, 2012 04:25:54 PM Albert Astals Cid wrote:
Would there be any chance to have the style check done by a pre-commit hook?
Or at least have a command-line tool that checks it for me?
Wouldn't that typically be a Krazy thing to check (and you can run Krazy
checks from the
On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote:
Would there be any chance to have the style check done by a pre-commit hook?
Or at least have a command-line tool that checks it for me?
yeah that should be possible. At my old day-job I created a pre-commit hook to
basically grep
On Saturday 29 December 2012 07:11:17 PM Martin Gräßlin wrote:
On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote:
Would there be any chance to have the style check done by a pre-commit hook?
Or at least have a command-line tool that checks it for me?
yeah that should be
On Saturday 29 December 2012 19:11:17 Martin Gräßlin wrote:
On Saturday 29 December 2012 16:25:54 Albert Astals Cid wrote:
Would there be any chance to have the style check done by a pre-commit
hook? Or at least have a command-line tool that checks it for me?
yeah that should be possible.
On Sat, Dec 29, 2012 at 7:50 PM, Allen Winter win...@kde.org wrote:
If you have the Krazy command line tool installed (
https://gitorious.org/krazy)
then you could write a pre-commit hook that runs 'krazy2 --style' on the
files
being committed.
./krazy2 --style
Unknown option: style
-less Qt includes?
For now it supports both, but it's very likely that by the end of january
it will be Qt5 only.
Or will the includes be if-def'ed? So will projects which refer to the
Kdelibs Coding Style need to add an exception to their rules for the
includes, if they want
On Saturday 29 December 2012 11:06:30 David Faure wrote:
Well, for frameworks that intend to be as close to Qt as possible they
should do the same (for the convenience of developers who don't use
qmake/cmake but set up their project configuration in their IDE by hand, for
instance Visual
Thiago Macieira wrote:
On sábado, 29 de dezembro de 2012 22.58.49, Kevin Ottens wrote:
On Saturday 29 December 2012 11:06:30 David Faure wrote:
Well, for frameworks that intend to be as close to Qt as possible
they should do the same (for the convenience of developers who don't
use
Hi,
what about adapting the Kdelibs Coding Style to the upcoming preparations for
the porting to Qt5? A lot of (KDE) projects follow that kdelibs one, but there
is (at least?) one rule which seems to conflict with the recommendations for
the preparations:
--- 8 ---
Qt Includes
If you add
14 matches
Mail list logo
