Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-08 Thread Rolf Eike Beer
Am Dienstag, 7. Mai 2013, 22:21:46 schrieb Àlex Fiestas: Would be nice to have some kind of unittests on this, that will make a different with the current implementation (which afaik it has none) Even better would be to have them first to prove that nothing changed afterwards ;) Eike

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-07 Thread Àlex Fiestas
Would be nice to have some kind of unittests on this, that will make a different with the current implementation (which afaik it has none) On Mon, May 6, 2013 at 4:14 PM, Martin Briza mbr...@redhat.com wrote: Well, as I said last week, I started working on it. First few commits are in branch

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-06 Thread Martin Briza
Well, as I said last week, I started working on it. First few commits are in branch mbriza/kdisplaymanager-split. Currently, PLEASE, don't judge me for the KDMBackendPrivate class stuff. :) I have just cut that out of KDisplayManager, not really knowing what to do with it further. I'll try to

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-02 Thread Martin Briza
On Tue, 30 Apr 2013 17:33:57 +0200, Aaron J. Seigo ase...@kde.org wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: I would leave creating the CK module to somebody who is experienced with how exactly the whole system works and knows if it is safe. if it is a refactor, this

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-02 Thread Martin Briza
On Tue, 30 Apr 2013 17:35:01 +0200, Aaron J. Seigo ase...@kde.org wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: - The KDisplayManager class is used only on a few places so replacing its constructions with calls to the factory will be easy. oh, btw.. the LightDM code

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-30 Thread Aaron J. Seigo
On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: I would leave creating the CK module to somebody who is experienced with how exactly the whole system works and knows if it is safe. if it is a refactor, this should be a matter of moving the CK code as-is into a new file. if the

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-30 Thread Aaron J. Seigo
On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: - The KDisplayManager class is used only on a few places so replacing its constructions with calls to the factory will be easy. oh, btw.. the LightDM code there is also shared by SDDM. calling it LightDM is a bit of a misnomer now as

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Oswald Buddenhagen
On Thu, Apr 25, 2013 at 03:11:25PM +0200, Martin Bříza wrote: after fixing a bit in the $subj file I've realized it (in my opinion) should be split into one abstract class with a factory handling the back-ends provided by the current session managers such as ConsoleKit and systemd-logind while

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Martin Briza
Hi, On Fri, 26 Apr 2013 23:30:43 +0200, Albert Astals Cid aa...@kde.org wrote: El Dijous, 25 d'abril de 2013, a les 15:11:25, Martin Briza va escriure: after fixing a bit in the $subj Which repo is that? Are we installing that file header? The systemd support fix is now in master

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Oswald Buddenhagen
On Mon, Apr 29, 2013 at 03:48:35PM +0200, Martin Briza wrote: On Mon, 29 Apr 2013 09:17:15 +0200, Oswald Buddenhagen o...@kde.org wrote: note that partial works (be it regressions or just a highly asymmetrical code structure) will not be accepted. if you don't find somebody to do the

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Aurélien Gâteau
Le Monday 29 April 2013 15:47:40 Martin Briza a écrit : Hi, On Fri, 26 Apr 2013 23:30:43 +0200, Albert Astals Cid aa...@kde.org wrote: El Dijous, 25 d'abril de 2013, a les 15:11:25, Martin Briza va escriure: after fixing a bit in the $subj Which repo is that? Are we installing that

libs/kworkspace/kdisplaymanager.cpp mess

2013-04-26 Thread Martin Briza
Hi everyone, after fixing a bit in the $subj file I've realized it (in my opinion) should be split into one abstract class with a factory handling the back-ends provided by the current session managers such as ConsoleKit and systemd-logind while providing one module for the legacy DMs with

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-26 Thread Albert Astals Cid
El Dijous, 25 d'abril de 2013, a les 15:11:25, Martin Briza va escriure: Hi everyone, after fixing a bit in the $subj Which repo is that? Are we installing that file header? Cheers, Albert file I've realized it (in my opinion) should be split into one abstract class with a factory