Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Jakob Gruber
On 08/04/2012 09:24 AM, Laszlo Papp wrote: Are there any objections or requested changes before Picmi can proceed to kdegames? Yes, you have ignored my comments for more than a week with a cross-platform issue, and not just on Windows. Support for the old libkdegames will be removed soon,

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Laszlo Papp
It *should* work logically and correctly until a new refactor, thus I cannot buy this argument, I am afraid. This is a few-liner change to make this operation right... Just to clarify, this statement means that you either support the old kde games library properly, or you do not support at

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Jakob Gruber
On 08/04/2012 10:02 AM, Laszlo Papp wrote: It *should* work logically and correctly until a new refactor, thus I cannot buy this argument, I am afraid. This is a few-liner change to make this operation right... Just to clarify, this statement means that you either support the old kde games

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Ben Cooksley
On Wed, Jul 25, 2012 at 5:10 PM, Laszlo Papp lp...@kde.org wrote: I'd like to clarify that all of the points mentioned in this mail concern libkdegames (and compilation thereof on Windows) and not picmi in particular, therefore I'm forwarding this to kde-games-devel. Just to clarify this: the

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Albert Astals Cid
--- El mié, 25/7/12, Ben Cooksley escribió: On Wed, Jul 25, 2012 at 5:10 PM, Laszlo Papp lp...@kde.org wrote: I'd like to clarify that all of the points mentioned in this mail concern libkdegames (and compilation thereof on Windows) and not picmi in particular, therefore I'm forwarding

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Andras Mantia
On Wednesday, July 25, 2012 06:10:21 AM Laszlo Papp wrote: (sorry for sounding blunt but Windows should not really be considered as something unimportnat for KDE in my opinion). There was never a requirement for software that wants to be part of KDE to work on Windows, and I'd like to keep

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Laszlo Papp
There was never a requirement for software that wants to be part of KDE to work on Windows, and I'd like to keep this as it is. Perhaps, but I can still raise my personal opinion, just as you can. Although, it is a bit more here than does not work. It does even compile. :-) I do think a

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Andras Mantia
On Wednesday, July 25, 2012 08:57:13 AM Laszlo Papp wrote: There was never a requirement for software that wants to be part of KDE to work on Windows, and I'd like to keep this as it is. Perhaps, but I can still raise my personal opinion, just as you can Sure. :) . Although, it is a bit

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Laszlo Papp
Although, it is a bit more here than does not work. It does even compile. :-) The usual reason is that the developer doesn't even have a MS compiler or Windows. And nobody can be forced to have one. ;) You could theoritically say the same for Linux (or certain softwares, versions etc). I

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Patrick Spendrin
Am 25.07.2012 10:13, schrieb Andras Mantia: On Wednesday, July 25, 2012 08:57:13 AM Laszlo Papp wrote: There was never a requirement for software that wants to be part of KDE to work on Windows, and I'd like to keep this as it is. Perhaps, but I can still raise my personal opinion, just as

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Laszlo Papp
Sure, but you have to admit, that there is a subtle difference between Linux different versions and Linux vs. Windows. I am just saying that, it can happen someone is unable to have an access to Linux for some reasons. This is for instance the situation at my company without finding

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Rolf Eike Beer
Am 25.07.2012 10:50, schrieb Patrick Spendrin: Am 25.07.2012 10:13, schrieb Andras Mantia: I keep telling to Patrick to just use Linux, but he is hard headed, so he has to leave with the pain and fix our mess. ;) :-D If I ever stop working on KDE on Windows I will switch. Looks like we

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Laszlo Papp
Some of the content may be familiar from irc, but just for the record. This is basically a convenience makefile and is not part of the actual cmake build system (= it can be ignored). Following SaroEngels' suggestion, it has been renamed to GNUmakefile - this way it should only be executed by

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Andrius da Costa Ribas
add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with RC.exe when I try to add a kde4_add_app_icon. fatal error RC1106: invalid option: -EHsc any hint with that? -- Andrius. 2012/7/26 Andrius da Costa Ribas andrius...@gmail.com Hello, In src/systemexception.h: return

Re: playground/games/picmi moved to KDE Review

2012-07-24 Thread Laszlo Papp
With the latest push to master, all of these points should be addressed (except the icon, I'm still looking). Does the game work on Windows? Best Regards, Laszlo Papp

Re: playground/games/picmi moved to KDE Review

2012-07-24 Thread Laszlo Papp
Does the game work on Windows? I have just put some effort into testing this, but it is quite broken. I would like to see improvements in this front since Windows is an important platform for Qt and KDE. I am here for helping with that, if needed. The issues so far (until I found enough to not

Re: playground/games/picmi moved to KDE Review

2012-07-24 Thread Jakob Gruber
On 07/24/2012 11:35 PM, Laszlo Papp wrote: Does the game work on Windows? I have just put some effort into testing this, but it is quite broken. I would like to see improvements in this front since Windows is an important platform for Qt and KDE. I am here for helping with that, if needed.

Re: playground/games/picmi moved to KDE Review

2012-07-24 Thread Laszlo Papp
I'd like to clarify that all of the points mentioned in this mail concern libkdegames (and compilation thereof on Windows) and not picmi in particular, therefore I'm forwarding this to kde-games-devel. Just to clarify this: the kdegames stack is broken on Windows, and I have not continued the

Re: playground/games/picmi moved to KDE Review

2012-07-23 Thread Jakob Gruber
On 07/22/2012 07:10 PM, Albert Astals Cid wrote: My comments: * You think you could give it a somehow bigger initial size? It starts very small the first time * Do you have a bigger res icon? Otherwise looks quite bad in my alt+tab switcher * Can you disable the ... in the settings

Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Albert Astals Cid
El Divendres, 20 de juliol de 2012, a les 11:53:28, Jakob Gruber va escriure: Hi all, I'd like to announce the move of Picmi to KDE Review [1] with the intended destination being kdegames. Picmi is a nonogram logic game [2] I've been working on for around two years. It includes both a

Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Jakob Gruber
On 07/22/2012 07:10 PM, Albert Astals Cid wrote: My comments: * You think you could give it a somehow bigger initial size? It starts very small the first time A default size of 700x560 is now set (I had it at at first 800x650 but tsdgeos reminded me about netbooks). * Do you have a bigger

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Jakob Gruber
On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote: Jakob Gruber jakob.gru...@gmail.com writes: Building with KDE trunk will require the patch from http://lists.kde.org/?l=kde-games-develm=134201653803914w=2. BTW, the config.h part of the patch should go in regardless of the rest, as

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Rolf Eike Beer
Am Samstag 21 Juli 2012, 10:48:47 schrieb Jakob Gruber: On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote: Jakob Gruber jakob.gru...@gmail.com writes: Building with KDE trunk will require the patch from http://lists.kde.org/?l=kde-games-develm=134201653803914w=2. BTW, the config.h

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Adriaan de Groot
On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote: One other question: three of the included levels are small pictograms of Disney characters up to 31x32 px in size. I'm not sure if that could be a legal issue? I'd suggest being on the safe side and dropping those: the characters

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Jakob Gruber
On 07/21/2012 11:16 AM, Adriaan de Groot wrote: On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote: One other question: three of the included levels are small pictograms of Disney characters up to 31x32 px in size. I'm not sure if that could be a legal issue? I'd suggest being on the

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Raphael Kubo da Costa
Jakob Gruber jakob.gru...@gmail.com writes: I've replaced all std::shared_pointers with QSharedPointers this morning and removed the -std=c++11 flag. I'm now getting a few errors and warnings when trying to build picmi with g++ 4.2.1, 4.6.3 and clang 3.1: some of them are related to -pedantic

playground/games/picmi moved to KDE Review

2012-07-20 Thread Jakob Gruber
Hi all, I'd like to announce the move of Picmi to KDE Review [1] with the intended destination being kdegames. Picmi is a nonogram logic game [2] I've been working on for around two years. It includes both a random mode (with low completion times as the goal) and 51 preset puzzles which turn

Re: playground/games/picmi moved to KDE Review

2012-07-20 Thread Raphael Kubo da Costa
Jakob Gruber jakob.gru...@gmail.com writes: Building with KDE trunk will require the patch from http://lists.kde.org/?l=kde-games-develm=134201653803914w=2. BTW, the config.h part of the patch should go in regardless of the rest, as config.h should be the first header included by the source