Re: The hidden problem with using QProcess/KProcess in kdelibs...

2011-01-23 Thread Thiago Macieira
On Saturday, 22 de January de 2011 17:16:10 Dawit A wrote: The above snippet of code is something I clipped from http://git.videolan.org/?p=vlc.git;a=blob;f=bin/vlc.c;h=70eeed0d2299e2f3cf0c 2f6819120f02d0703152;hb=HEAD One cannot easily tell where QCoreApplication's ctor is getting called,

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6405/ --- (Updated Jan. 23, 2011, 1:24 p.m.) Review request for kdelibs, Pino Toscano

Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6410/ --- Review request for kdelibs, Frederik Gladhorn and Jeremy Whiting. Summary

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Ivan Čukić
Example: [KDevPlatform] fafd165: Don't completely ignore the retrieved top-context For me, this is more useful, so +1 Maybe adding a keyword 'commit' before the short hash like this [KDevPlatform] Commit fafd165: Don't completely ignore the retrieved top-context -- Cheerio, Ivan -- While

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Stephen Kelly
On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_extractor.py, line 358 http://svn.reviewboard.kde.org/r/6405/diff/2/?file=1#file1line358 Is it guaranteed that the order of messages in the output file is

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Boudewijn Rempt, 23.01.2011: On Sunday 23 January 2011, Milian Wolff wrote: Hey all, I've brought this discussion to the sysadmins recently and they asked me to ask for feedback here. So there it goes: Recently, the format of the subject of git commit emails was adapted to use the

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/23/2011 9:30 PM, Milian Wolff wrote: What was broken? Nothing as far as Commitfilter is concerned. Commitfilter actually acts on the X-Commit-Directories headers, not the mail subject. This header was actually somewhat broken in the old mails, it has been fixed now as part of the hooks

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Eike Hein, 23.01.2011: On 1/23/2011 9:30 PM, Milian Wolff wrote: What was broken? Nothing as far as Commitfilter is concerned. Commitfilter actually acts on the X-Commit-Directories headers, not the mail subject. This header was actually somewhat broken in the old mails, it has been fixed

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Eike Hein, 23.01.2011: @sysadmins: would it be possible to change the format for some repos or is this not possible? I.e. leave the decision to the project maintainers? Would you be OK with this hybrid format that we discussed a few days ago: [repo sans git/branch*] common root path:

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Allan Sandfeld Jensen
On Sunday 23 January 2011, Eike Hein wrote: @sysadmins: would it be possible to change the format for some repos or is this not possible? I.e. leave the decision to the project maintainers? Would you be OK with this hybrid format that we discussed a few days ago: [repo sans

Re: splitting up kdebase in git

2011-01-23 Thread Allen Winter
On Tuesday 18 January 2011 6:15:04 pm Aaron J. Seigo wrote: On Tuesday, January 18, 2011, Allen Winter wrote: On Tuesday 18 January 2011 4:34:21 pm Aaron J. Seigo wrote: hi all ... when looking at migrating kdebase to git (thanks to Ian Monroe for his efforts there and for the

Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6410/#review9696 --- Ship it! Looks good to me, please commit. - Frederik On Jan.

Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6410/#review9697 --- Please add the @since tag for the right version (4.6 if you

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Tom Albers
- Oorspronkelijk bericht - On 1/23/2011 9:30 PM, Milian Wolff wrote: What was broken? Nothing as far as Commitfilter is concerned. Commitfilter actually acts on the X-Commit-Directories headers, not the mail subject. This header was actually somewhat broken in the old mails, it has

Re: The hidden problem with using QProcess/KProcess in kdelibs...

2011-01-23 Thread Thiago Macieira
On Sunday, 23 de January de 2011 23:20:37 Dawit A wrote: Anyhow, after reading the response of one of the VLC developers in bug report I listed in the original email, I am convinced that the reliance on signals, which can so easily get cleared or worse blocked, in a library class seems a