Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52293 --- I wonder if you're being too much verbose with the debugs.

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-06 Thread Luigi Toscano
On March 5, 2014, 3:36 p.m., Burkhard Lück wrote: src/meinproc.cpp, lines 170-179 https://git.reviewboard.kde.org/r/116604/diff/1/?file=252003#file252003line170 How does this affect this code in KHelpcenter: kde-runtime/khelpcenter/glossary.cpp:149:KProcess

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-06 Thread Àlex Fiestas
On March 6, 2014, 7:52 p.m., Albert Astals Cid wrote: kwalletd/main.cpp, line 100 https://git.reviewboard.kde.org/r/116555/diff/2/?file=251596#file251596line100 Make this function static like the other ones? You are right, I will fix it tomorrow morning. - Àlex

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52294 --- I tested your patch, no trailing slash is added whether the

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-06 Thread Àlex Fiestas
On March 6, 2014, 7:52 p.m., Albert Astals Cid wrote: I wonder if you're being too much verbose with the debugs. Since it is a beta I want to take the most of it in case any issue appears, I can remove verbosity before release if needed (think that this debug only happens once on session

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52298 --- For the release time, since this is really like I would like

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Andrea Iacovitti
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: I tested your patch, no trailing slash is added whether the request refers to a collection or resource (as it was before commit 58294ac). Dawit Alemayehu wrote: Right, but now the webdav server should redirect to the right

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Dawit Alemayehu
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: I tested your patch, no trailing slash is added whether the request refers to a collection or resource (as it was before commit 58294ac). Dawit Alemayehu wrote: Right, but now the webdav server should redirect to the right

Review Request 116570: Ask user for confirmation before doing POST - POST redirection in KIO

2014-03-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116570/ --- Review request for kdelibs, Andrea Iacovitti and David Faure.

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-06 Thread Dawit Alemayehu
On March 5, 2014, 7:47 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2275 https://git.reviewboard.kde.org/r/116524/diff/2/?file=251597#file251597line2275 This is surely wrong. If you're in /home/dfaure (as the CWD would be, by default, on non-anonymous FTP)