Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-09-29 Thread Søren Holm
Giv en that my change will be accepted, but is it applied. I have not commit right. Søndag den 28. september 2014 15:07:51 skrev Søren Holm: --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-09-29 Thread Frederic Sheedy
Hi Ian, Review is to reopened! I also use Buzilla_token as param for login request. But use of token as param for attachement works. Frédéric On Fri, Sep 26, 2014 at 7:11 PM, Ian Wadham iandw...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-29 Thread Thomas Lübking
On Sept. 28, 2014, 3:13 nachm., Thomas Lübking wrote: kdeui/widgets/kmenu.cpp, line 182 https://git.reviewboard.kde.org/r/120403/diff/1/?file=315609#file315609line182 try to avoid negated bools unless for performance or readability reasons (ie. you'd need !flag a lot otherwise)

Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Christoph Feck
Hi, I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. -- Forwarded Message -- Subject: PVS-Studio KDE analysis Date: Monday 29 September 2014, 18:04:24 From: Boris Egorov ego...@linux.com To:

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Ivan Čukić
I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. If the report is not separated into components, then I'd guess kde-devel is the right place for it. Lets see what the others will say. A question that I'd have for Boris is

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Ingo Klöcker
On Monday 29 September 2014 18:55:18 Ivan Čukić wrote: I got this question from Boris, but do not feel qualified to answer, so forwarding it here. Please CC Boris in reply. If the report is not separated into components, then I'd guess kde-devel is the right place for it. I think it

Re: Fwd: PVS-Studio KDE analysis

2014-09-29 Thread Jan Kundrát
On Monday, 29 September 2014 18:39:08 CEST, Christoph Feck wrote: Russian folks behind PVS-Studio static analyzer (http://www.viva64.com/en/pvs-studio/) made analysis of KDE project. Hi, can we make them run it on extragear (and especially extragear/pim/trojita)? Cheers, Jan -- Trojitá,

Re: libkface

2014-09-29 Thread Vishesh Handa
Hey Tobias Some comments about the code - 1. The code seems to be licensed under GPL. In order to make it into a framework, it will need to be re-licensed. This library seems like an ideal candidate for becoming a framework. 2. The copyright header seems to say Part of the Digikam Project. You

Re: libkface

2014-09-29 Thread Gilles Caulier
2014-09-30 3:06 GMT+02:00 Vishesh Handa m...@vhanda.in: Hey Tobias Some comments about the code - 1. The code seems to be licensed under GPL. In order to make it into a framework, it will need to be re-licensed. This library seems like an ideal candidate for becoming a framework. libkface