Re: AtCore on KDE Review

Thank you for clarifying that as I did misunderstand. I should hopefully have a patch for this today . I will tag you for review. On Jul 16, 2017 11:31 AM, "Luigi Toscano" wrote: sithlord48 ha scritto: > Atcore is a kde framework library So we used the KF5 prefix. If

Re: AtCore on KDE Review

Atcore is a kde framework library So we used the KF5 prefix. If this is still incorrect then I can remove it On Jul 16, 2017 9:51 AM, "Luigi Toscano" wrote: > Lays Rodrigues ha scritto: > > Well, choosed to maintain the translation. > > Diff with the script merged: > >

Re: AtCore on KDE Review

sithlord48 ha scritto: > Atcore is a kde framework library So we used the KF5 prefix. If this is still > incorrect then I can remove it I think that there is a misunderstanding: AtCore is a library based on Qt and ECM. Even if it used some libraries from Frameworks, it would not make it part of

Re: AtCore on KDE Review

Lays Rodrigues ha scritto: > Well, choosed to maintain the translation. > Diff with the script merged: > https://phabricator.kde.org/D6692 > That's solved, but there is another issue that I noticed now: atcore uses the same pattern as Frameworks libraries, and this should be fixed. For example,