Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Adriaan de Groot
On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote: One other question: three of the included levels are small pictograms of Disney characters up to 31x32 px in size. I'm not sure if that could be a legal issue? I'd suggest being on the safe side and dropping those: the characters

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Adriaan de Groot
On Saturday, December 29, 2012 04:25:54 PM Albert Astals Cid wrote: Would there be any chance to have the style check done by a pre-commit hook? Or at least have a command-line tool that checks it for me? Wouldn't that typically be a Krazy thing to check (and you can run Krazy checks from the

Re: Moving Baloo forward

2014-01-20 Thread Adriaan de Groot
On Friday 17 January 2014 01:47:17 Albert Astals Cid wrote: Thus my suggestion is that after we get the wiki done and we explain clearly the situation as Thomas Lübking suggested (i.e. if you really really really really need what Nepomuk provides and can't accept a single regression in that

Re: KDiagram libs (KChart, KGantt) in KDE Review

2015-02-11 Thread Adriaan de Groot
On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. I've tried

Re: Adding further modules to api.kde.org

2015-09-10 Thread Adriaan de Groot
On Thursday 10 September 2015 06:07:40 Jeremy Whiting wrote: > It would be awesome to have what used to be in KDE SC on api.kde.org > again. We have many libraries that aren't frameworks that are Qt5/KF5 > based which would be good to show on there imo. Perhaps half of this is figuring out what

Re: Policy regarding QtWebKit and QtScript

2015-12-29 Thread Adriaan de Groot
On Wednesday 30 December 2015 01:34:46 Vadim Zhukov wrote: > There is a little chance QtWebEngine will be ported on OpenBSD: if > someone will come in and fix Chromium and QtWebEngine to bundle less, > at least. I won't volunteer: handling a few hundreds of KDE ports + > ports of Qt itself is

Re: Policy regarding QtWebKit and QtScript

2016-01-06 Thread Adriaan de Groot
Kevin, first off thank you for responding so carefully to Vadim and to me. It does make a difference to porting efforts. On Wednesday 06 January 2016 18:11:25 Kevin Kofler wrote: > unbundling doesn't seem to be the main focus. And the reason there are so > many patches is because they produced a

Re: Policy regarding QtWebKit and QtScript

2015-12-25 Thread Adriaan de Groot
On Friday 25 December 2015 12:42:26 you wrote: > On Donnerstag, 24. Dezember 2015 12:14:06 CET Adriaan de Groot wrote: > > On Tuesday 22 December 2015 16:07:06 Lisandro Damián Nicanor Pérez Meyer > > > > wrote: > > > > The idea that users may have remaind

Re: Policy regarding QtWebKit and QtScript

2015-12-26 Thread Adriaan de Groot
On Friday 25 December 2015 13:34:01 Allan Sandfeld Jensen wrote: > Does Chromium build on FreeBSD already? In know in QtWebEngine we have > several qmake conditions that would need to be changed from linux to > posix:!mac, but I haven't tried because I wasn't sure if FreeBSD was even > support by

Re: Policy regarding QtWebKit and QtScript

2015-12-24 Thread Adriaan de Groot
On Tuesday 22 December 2015 16:07:06 Lisandro Damián Nicanor Pérez Meyer wrote: > > The idea that users may have remainders of QtWebKit 5.5 on their disk (or > > not and thus unresolvable linkage) and install Qt 5.6 and still have (not > > recompiled) client code that is now gonna crash scares me

Re: CI Requirements - Lessons Not Learnt?

2017-01-17 Thread Adriaan de Groot
On Monday, January 16, 2017 05:32:12 PM Eike Hein wrote: > I'll be working up a new draft today taking some of the comments > so far into account, and giving sysadmin the latitude to remove > projects from CI at their decision if the guidelines are violated > and maintaining a project on CI

Re: Test your applications on Wayland

2016-10-13 Thread Adriaan de Groot
On Thursday, October 13, 2016 01:12:27 PM Martin Graesslin wrote: > Just an example of an issue I run into today: > https://git.reviewboard.kde.org/ r/129171/ > > Application just crashed on startup due to a missing nullptr check exposed > by a different windowing systems. This intrigued me,

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Adriaan de Groot
On Friday, January 13, 2017 09:35:51 PM Eike Hein wrote: > Quick follow-up notes: I improved the formatting a little more, > please refresh if you were reading already - now waiting for > comments, though. I like it in general, although near the end I think I would prefer to have (c) maintainer

Re: CI Requirements - Lessons Not Learnt?

2017-01-05 Thread Adriaan de Groot
I think there's a middle ground to be found between dog-piling on Martin and letting things slide; a middle ground between dependency-creep and sticking to a stale platform. So let's step back for a moment and ask "what went wrong?" (and try to answer that carefully!), "what is the impact?" and

Re: Latte Dock in review phase

2017-10-06 Thread Adriaan de Groot
On Friday, 6 October 2017 09:47:26 CEST Jonathan Riddell wrote: > Looks good from a brief look around I did from a packagers point of > view (so not looking at the code). The licensing is a funky (not bad, just .. unusual) mix of LGPL v2+ and GPL v2+; for instance app/ contains 7 files licensed

Re: Latte : make_unique for gcc <=4.8

2017-11-09 Thread Adriaan de Groot
On Thursday, 9 November 2017 09:58:26 CET Tomaz Canabrava wrote: > On Sun, Nov 5, 2017 at 4:12 PM, Michail Vourlakos > > > during the review phase in Latte we removed the following code in case it > > would conflict in some cases: > > > > #if __GLIBCXX__ <= 20150623 > >

Re: Importing kdiff3 - was - Re: Aw: Re: KDE inclusion

2018-01-26 Thread Adriaan de Groot
On Wednesday, January 24, 2018 6:08:03 PM EST Albert Astals Cid wrote: > El dimecres, 24 de gener de 2018, a les 17:34:16 CET, Kevin Funk va escriure: > > On Wednesday, 24 January 2018 16:24:10 CET Michael Reeves wrote: > > > A little confused on where to start with this sponsor thing. > > > >

Re: Falkon in kdereview

2018-02-28 Thread Adriaan de Groot
On Wednesday, February 28, 2018 6:10:36 AM EST David Rosca wrote: > There are also some autotests, although they are rather unstable on > FreeBSD build. It looks like crash in QtWebEngine, but the backtrace > from CI is without symbols, so it is unfortunately useless. The KDE-FreeBSD developers

Re: Symmy in kde-review

2019-04-12 Thread Adriaan de Groot
On Friday, April 12, 2019 10:13:10 AM CEST Jonathan Riddell wrote: > On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio wrote: > > symmy has been moved to kde-review for the usual review process. > > > > It's a tiny frontend for the symmetric encryption functionality of GPG. It > > doesn't handle

Re: liquidshell in kdereview

2019-04-12 Thread Adriaan de Groot
On Sunday, March 10, 2019 1:25:14 PM CEST Martin Koller wrote: > since some time has already passed and there was no conclusion, I'll try > once again to announce liquidshell. # Documentation issues The features list, both in German and English, lists a bunch of features that distinguish it

Re: liquidshell in kdereview

2019-04-14 Thread Adriaan de Groot
On Saturday, 13 April 2019 14:08:18 CEST Martin Koller wrote: > > # License issues > > > > None, actually. Well done. Consistent use of GPLv3+ everywhere. You might > > want to add SPDX identifiers, but that would be the icing on the cake. > > Where, which and how would I need to add SPDX

Maintainence status of Kooka?

2019-05-26 Thread Adriaan de Groot
Kooka had its last release in 2011, as a KDE3 application. However, master is a KF5-based application, with version number 0.90 in CMakeLists.txt. Is there any intention to do a release? (That's mostly a question for Jonathan) We revived it in FreeBSD packaging, calling current master 0.61.296

Re: KIOFuse in kdereview

2019-11-05 Thread Adriaan de Groot
On Monday, 4 November 2019 23:08:44 CET Alexander Saoutkin wrote: > Currently, KIOFuse has been tested to work on Linux, although there are no > technical reasons why it can’t work on FreeBSD. I'm working on this, and Fabian Vogt has been a tremendous help in moving that forward; we can say "it

Re: KTimeTracker in kdereview

2019-11-19 Thread Adriaan de Groot
On Tuesday, 19 November 2019 05:20:23 CET Alexander Potashev wrote: > KTimeTracker is a time tracker desktop application which is well > suited for tracking labor time you spend on a specific > project/feature/customer. Builds clean on FreeBSD; that's a +1. I ran it once, it works nicely .. I'd

Re: Work Branches

2019-10-05 Thread Adriaan de Groot
On Saturday, 5 October 2019 04:11:11 CEST Ben Cooksley wrote: > 2) Protect all branches, aside from a given prefix (proposed to be work/) +1 for a simple and clear policy. [ade] signature.asc Description: This is a digitally signed message part.

Re: Kup in KDE Review

2020-04-06 Thread Adriaan de Groot
On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote: > Please help to review kup. - It's probably worthwhile looking at REUSE licensing compliance (see reuse.software, or ask on IRC #kde-devel) so that the license is machine- readable and checkable. - Although you find_package(LibGit2) you

Re: Type=FSDevice desktop files

2020-04-27 Thread Adriaan de Groot
On 2020 prilula d. 26id 23:45:09 CEST David Faure wrote: > This was useful back then, for USB keys and CDROMs (kids, ask your parents > what that was), before Solid, before the plasma device notification popup... I have a CDRom drive. It contains an OpenBSD 6.3 install CD, even -- that's for

Re: Information regarding upcoming Gitlab Migration

2020-05-01 Thread Adriaan de Groot
On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > > objections raised so far: > > > > - Projects will be allowed to live in--or at least appear in--multiple > >

Re: Information regarding upcoming Gitlab Migration

2020-04-28 Thread Adriaan de Groot
There are a whole bunch of considerations and use-cases being discussed at once in this thread, and Leinir's post made me think a bit about different actors can interact with "the collection of repositories". One actor is "tooling", as Albert has pointed out. Whatever the resulting structure

Re: Information regarding upcoming Gitlab Migration

2020-04-29 Thread Adriaan de Groot
On 2020 prilula d. 28id 13:35:22 CEST Ben Cooksley wrote: > Would some form of git alias/custom command script that works similar > to the following be suitable? > > git kde-clone skrooge > > That script would then search the appropriate groups (ignoring any > personal repositories including

Re: CI Breakage in Solid on FreeBSD

2020-10-15 Thread Adriaan de Groot
On Thursday, 15 October 2020 11:22:02 CEST Ben Cooksley wrote: > Yesterday changes were landed to Solid, allowing it to make use of new > libimobiledevice API. Unfortunately these changes failed to handle the > situation where an older version of libimobiledevice is in use, causing a > build

Re: plasma-systemmonitor in kdereview

2020-10-19 Thread Adriaan de Groot
On 2020 tobula d. 19id 00:28:38 CEST Albert Astals Cid wrote: > El dijous, 1 d’octubre de 2020, a les 11:36:12 CEST, Arjen Hiemstra va escriure: > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor . >

Re: KDE Frameworks 5.74.0 released

2020-09-17 Thread Adriaan de Groot
On Sunday, 13 September 2020 13:16:47 CEST Andreas Müller wrote: > On Sat, Sep 12, 2020 at 1:33 PM David Faure wrote: > > 12th September 2020. KDE today announces the release of KDE Frameworks > > 5.74.0. > Not mentioned here: Many (All?) licenses are now according to REUSE > policy [1]. Reading

Re: Introducing KDE Activity Filter

2020-07-19 Thread Adriaan de Groot
On Tuesday, 14 July 2020 10:57:41 CEST Ingo Klöcker wrote: > On Dienstag, 14. Juli 2020 10:20:33 CEST Kåre Särs wrote: > > Is there a way to verify that the yaml file is syntactically correct > > before > > pushing the change? > > There are loads of YAML linters/validators, online and offline. In

Re: Move Koko to KDEReview

2020-06-15 Thread Adriaan de Groot
On Friday, 12 June 2020 18:05:36 CEST Carl Schwan wrote: > > I'm kind of unsure how i feel about it downloading things on cmake time. > > I asked a few packagers I know and for them, since the packagers can > download the files and put them into the tarball, it should be fine. But > they also

Re: Shift for parts of the CI system to Qt 5.15

2020-06-21 Thread Adriaan de Groot
On Saturday, 20 June 2020 10:11:04 CEST Volker Krause wrote: > On Saturday, 20 June 2020 08:20:18 CEST Ben Cooksley wrote: > > - kaffeine > > This doesn't look like something caused by Qt 5.15, more like an issue with > the FreeBSD DVB headers, builds on Linux.

Re: Move Koko to KDEReview

2020-06-11 Thread Adriaan de Groot
On Thursday, 11 June 2020 23:43:52 CEST Albert Astals Cid wrote: > I'm kind of unsure how i feel about it downloading things on cmake time. A fair number of distro's / packagers will go "um nope" (if the package building machines even *have* an internet connection during configure / build

Re: NeoChat in KDEReview

2020-11-22 Thread Adriaan de Groot
On Sunday, 22 November 2020 21:16:53 CET Adriaan de Groot wrote: > Thanks Carl for chasing Albert's comments so quickly. Here's my review > comments on neochat 5316e32004fcfa60d72f373e2e55b44b8fecf2c7 (master HEAD as > of right now). I should add that, in spite of all my gripes, this is

Re: NeoChat in KDEReview

2020-11-22 Thread Adriaan de Groot
Thanks Carl for chasing Albert's comments so quickly. Here's my review comments on neochat 5316e32004fcfa60d72f373e2e55b44b8fecf2c7 (master HEAD as of right now). On Sunday, 22 November 2020 12:40:16 CET Carl Schwan wrote: > Le samedi, novembre 21, 2020 1:26 AM, Albert Astals Cid a écrit : >

Re: RFC: suffix ".in" instead of ".cmake" for template files to substitution processing

2021-01-05 Thread Adriaan de Groot
On Monday, 4 January 2021 08:21:57 CET Friedrich W. H. Kossebau wrote: > And the proposal is to use ".in". > > Pros: I would support just consistently adding ".in" (which, in the case of producing Config files for cmake, means foo.cmake.in). [ade] signature.asc Description: This is a

Re: Progress is good for us but bad for documentation

2021-06-14 Thread Adriaan de Groot
On Wednesday, 9 June 2021 01:20:23 CEST Frederik Schwarzer wrote: > I would like to ask you to report such documentation to me. We see the > topic come up here and there but it then sometimes sinks into oblivion > again because it was part of a merge request that has then been merged > or so.

Re: Kirigami Addons in KDEReview

2021-05-01 Thread Adriaan de Groot
On Friday, 30 April 2021 23:39:17 CEST Nate Graham wrote: > I would like to see > https://invent.kde.org/libraries/kirigami-addons/-/issues/2 fixed first > as the date picker is sort of almost unusable right now. A good date picker would be most enthusiastically received by the myGNUHealth

Re: Koko in KDEReview

2021-05-04 Thread Adriaan de Groot
On Tuesday, 4 May 2021 15:50:27 CEST Halla Rempt wrote: > On Tuesday, 4 May 2021 15:28:30 CEST Nate Graham wrote: > > I don't see anyone really trying to argue otherwise. > > I have certainly made that argument many times. Since only developers can > add tags, it will be impossible for ordinary

Re: Koko in KDEReview

2021-03-16 Thread Adriaan de Groot
On Tuesday, 16 March 2021 20:10:46 CET Carl Schwan wrote: > > > - on the topic of licensing: since the code base is really close to > > > complete reuse coverage it might be nice to push it over the finishing > > > line and then `reuse lint` it to not have it fall behind again > > This will be

Re: Towards Excellent Defect Management

2021-09-16 Thread Adriaan de Groot
On Friday, 17 September 2021 00:46:33 CEST Aleix Pol wrote: > On Tue, Sep 14, 2021 at 5:23 PM Harald Sitter wrote: > > server-side retracing. I've spent many afternoons reading up on and > > poking demo instances of every somewhat suitable software I could > > find, and Sentry looks like the best

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on sourceforge), but we still haven't left playground... After a > lot of procrastination on that matter, a previous review failed due to > lack of time

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Monday, 28 March 2022 17:39:17 CEST Thomas Friedrichsmeier wrote: > On Mon, 28 Mar 2022 17:09:44 +0200 > Nicolas Fella wrote: > [...] > > > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > > presumably

Re: Review request for MpvQt

2023-08-25 Thread Adriaan de Groot
On Friday, 25 August 2023 21:56:45 CEST Florea Banus George wrote: > please review https://invent.kde.org/libraries/mpvqt, a libmpv wrapper > library for qtquick/qml (no widgets). Builds, and the example runs and can play a .webm file, on FreeBSD. There's a handful of warnings which I'll add to

Re: drkonqi's many debuggers

2023-08-28 Thread Adriaan de Groot
On Monday, 28 August 2023 17:23:00 CEST Harald Sitter wrote: > I am wondering: does anyone actually use anything besides the default > gdb debugger? We have a lot of code just for supporting multiple > debuggers and I am wondering if we couldn't just focus on one debugger > and get less code with

Re: Move Licentia to KDEREVIEW

2022-07-10 Thread Adriaan de Groot
On Friday, 8 July 2022 07:36:57 CEST Felipe Kinoshita wrote: > Hey, I'd like to move Licentia to > KDEREVIEW. > > Licentia is a simple app targeted at developers/creators who need to decide > which license is suited to their projects, Licentia helps with that

Re: KDE Review: Skladnik (t.g.f.k.a. KSokoban), returning a KDE1-KDE3 age dino

2023-11-14 Thread Adriaan de Groot
On Sunday, 12 November 2023 22:57:55 CET Friedrich W. H. Kossebau wrote: > Would the file COPYING (GPLv2) in the toplevel dir then default the license > for these files? > See https://phabricator.kde.org/source/svn/browse/trunk/kdegames/;10132 > In short, what to do here for reuse checks? Ignore,