---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
Review request for KDE Software on Mac OS X and kdelibs.
Repository:
On July 27, 2014, 1:32 p.m., Thomas Lübking wrote:
kdeui/util/kcrash.cpp, line 316
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293441#file293441line316
is libdispatch OSX only or is it also used on FreeBSD?
The question (more to Michael ;-) is whether
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 15, 2014, 1:03 p.m.)
Review request for KDE Software on
On Sept. 15, 2014, 2:45 a.m., Ian Wadham wrote:
I cannot see how static void setTextWithCorrectMenuRole() could work in
all languages.
Does not the text parameter come translated into the user's language, not
necessarily English? So how can the .contains checks work with all
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 188
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line188
given KAction, KMenu and KMenuBar are all deprecated in KF5, is this
actually of any upstream relevance?
I
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 164
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line164
would this eg. work with kwrite (Configure Editor...)? - or other
kpart driven things?
René J.V. Bertin wrote:
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 174
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312033#file312033line174
this is *utterly* wrong - you're manipulating a QAction reference just
because it (at this very time!) hints it
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 164
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line164
would this eg. work with kwrite (Configure Editor...)? - or other
kpart driven things?
René J.V. Bertin wrote:
On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote:
kinit/kinit.cpp, line 1481
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481
do you need $DISPLAY in OS X?
René J.V. Bertin wrote:
Nope. It can be set if the user has XQuartz installed and
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 174
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312033#file312033line174
this is *utterly* wrong - you're manipulating a QAction reference just
because it (at this very time!) hints it
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 164
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line164
would this eg. work with kwrite (Configure Editor...)? - or other
kpart driven things?
René J.V. Bertin wrote:
On Tuesday September 16 2014 11:31:30 Ian Wadham wrote:
The socket name is generated in 3 or 4 places, I am not sure how many. All of
these must line up if KCrash, kdeinit4, klauncher, kded4 and kwrapper are
to run as and when required and interact correctly on Apple OS X. And I am
not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 17, 2014, 7:48 p.m.)
Review request for KDE Software on
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/notifications/kstatusnotifieritem.cpp, lines 728-730
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312870#file312870line728
What is this used for?
If it is not used, please remove it, otherwise just include it
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
Review request for KDE Software on Mac OS X and kde-workspace.
On Sept. 19, 2014, 8:40 p.m., Thomas Lübking wrote:
kcontrol/krdb/krdb.cpp, line 581
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line581
Xlib call?
Why do you need krdb at all?
(gtk+ Qt should align to OSX anyway and you're skipping
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 19, 2014, 10:43 p.m.)
Review request for KDE Software on
On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote:
overall I rather tend to -1 for these changes. I consider changing the
build system in a long term release as way too risky considering that the
core development doesn't use this iteration any more. Any unintended
breakage (e.g. a
On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, lines 544-548
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line544
this looks like an inintended change
René J.V. Bertin wrote:
No, I often do this when conditionals get
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 12:05 a.m.)
Review request for KDE Software on
On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote:
You added APPLE to the if() but not always to the matching endif()...
True. But that's optional, no?
- René J.V.
---
This is an automatically generated e-mail. To reply, visit:
On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote:
You added APPLE to the if() but not always to the matching endif()...
René J.V. Bertin wrote:
True. But that's optional, no?
On Saturday September 20 2014, Rolf Eike Beer wrote regarding Re: Review
Request 120287: [OS X] make
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
I looked into those yesterday, and cannot find tabs on my end. No idea where
they'd come
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
Ah, the famous German rigor ... is this really an issue, shouldn't that empty
line have been there in
On Sept. 20, 2014, 10:25 a.m., René J.V. Bertin wrote:
While we're discussing krdb's function on non-X11 systems:
I seem to recall that the colour theme selector kcm had an effect like it
has under X11: applying the new theme to running applications instantly. I
can no longer
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
René J.V. Bertin wrote:
I looked into those yesterday, and cannot find tabs on my
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 12:51 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 12:54 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 12:53 p.m.)
Review request for KDE Software on
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
René J.V. Bertin wrote:
I looked into those yesterday, and cannot find tabs on my
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
René J.V. Bertin wrote:
I looked into those yesterday, and cannot find tabs on my
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 2:52 p.m.)
Review request for KDE Software on
On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote:
kinit/kinit.cpp, line 1481
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481
do you need $DISPLAY in OS X?
René J.V. Bertin wrote:
Nope. It can be set if the user has XQuartz installed and
On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 223-239
https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223
out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
blocks. If I see correctly, what remains being
On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 21, 2014, 1:53 p.m., Gilles Caulier wrote:
Martin,
Since this file is openn, you can considerate this entry as obsolete :
https://git.reviewboard.kde.org/r/112991/
Gilles, you seemed to have issues with the standard 'macintosh' Qt theme for
digikam's GUI. What's your
On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 223-239
https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223
out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
blocks. If I see correctly, what remains being
On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 223-239
https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223
out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
blocks. If I see correctly, what remains being
On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 223-239
https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223
out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
blocks. If I see correctly, what remains being
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120319/
---
Review request for Kate, KDE Software on Mac OS X and kdelibs.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 22, 2014, 6:17 p.m.)
Review request for KDE Software on
On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote:
I assume you did not want to include those debug messages in
qguiplatformplugin_kde.cpp?
Oooops, no ...
On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote:
CMakeLists.txt, line 249
On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote:
CMakeLists.txt, line 249
https://git.reviewboard.kde.org/r/120287/diff/6/?file=314531#file314531line249
just as a note: kinfocenter shold(tm) work on macos. at least there is
a source file called info_osx.cpp
René J.V. Bertin
On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote:
Qt cannot distiguish because there's nothing to distinguish - the driver
generates synthetic wheel event for the inertia.
You can btw. turn that censored off.
Seems an issue with inertial scrolling on X11 as well
On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote:
Qt cannot distiguish because there's nothing to distinguish - the driver
generates synthetic wheel event for the inertia.
You can btw. turn that censored off.
Seems an issue with inertial scrolling on X11 as well
On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote:
Qt cannot distiguish because there's nothing to distinguish - the driver
generates synthetic wheel event for the inertia.
You can btw. turn that censored off.
Seems an issue with inertial scrolling on X11 as well
On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 24, 2014, 5 p.m.)
Review request for KDE Software on Mac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
---
Review request for KDE Software on Mac OS X, KDE Runtime and kdelibs.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120355/
---
Review request for KDE Base Apps, KDE Software on Mac OS X and kdelibs.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
---
(Updated Sept. 24, 2014, 7:23 p.m.)
Review request for KDE Software on
On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote:
Please watch coding style and please also have a look at the frameworks
variant. It still needs porting to MacOS *hint,hint* and that would be
very, very appreciated. I recently sent a mail to frameworks-devel
concerning moving the
On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote:
I assume you'd be better off altering KMenu::addTitle() - or even patch Qt
(QMenu on mach cannot deal w/ widget actions, at least if used on the
global menubar)
I agree totally, but for that
- I'd have to understand exactly what the
On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote:
I assume you'd be better off altering KMenu::addTitle() - or even patch Qt
(QMenu on mach cannot deal w/ widget actions, at least if used on the
global menubar)
René J.V. Bertin wrote:
I agree totally, but for that
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120363/
---
Review request for KDE Software on Mac OS X and kdelibs.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Sept. 25, 2014, 3:58 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120355/
---
(Updated Sept. 25, 2014, 4 p.m.)
Review request for KDE Base Apps, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
---
(Updated Sept. 25, 2014, 4:02 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 25, 2014, 4:03 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120195/
---
(Updated Sept. 25, 2014, 4:06 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
---
(Updated Sept. 25, 2014, 4:58 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
---
(Updated Sept. 25, 2014, 5:22 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
---
(Updated Sept. 25, 2014, 6:14 p.m.)
Review request for KDE Software on
On Sept. 25, 2014, 5:58 p.m., Martin Gräßlin wrote:
kglobalaccel/main.cpp, lines 48-55
https://git.reviewboard.kde.org/r/120354/diff/4/?file=315460#file315460line48
now there are two deleted lines...
My bad, I could so hardly believe that one might want 2 empty lines there that
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote:
Aside Thiagos concern, what actually causes the menubar/docker item stuff?
Quoting QApplication (4.8):
On X11, the window system is initialized if GUIenabled is true. If
GUIenabled is false, the application does not connect to
On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote:
I assume you'd be better off altering KMenu::addTitle() - or even patch Qt
(QMenu on mach cannot deal w/ widget actions, at least if used on the
global menubar)
René J.V. Bertin wrote:
I agree totally, but for that
-
On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote:
I assume you'd be better off altering KMenu::addTitle() - or even patch Qt
(QMenu on mach cannot deal w/ widget actions, at least if used on the
global menubar)
René J.V. Bertin wrote:
I agree totally, but for that
-
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote:
Aside Thiagos concern, what actually causes the menubar/docker item stuff?
Quoting QApplication (4.8):
On X11, the window system is initialized if GUIenabled is true. If
GUIenabled is false, the application does not connect to
On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote:
I assume you'd be better off altering KMenu::addTitle() - or even patch Qt
(QMenu on mach cannot deal w/ widget actions, at least if used on the
global menubar)
René J.V. Bertin wrote:
I agree totally, but for that
-
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote:
Aside Thiagos concern, what actually causes the menubar/docker item stuff?
Quoting QApplication (4.8):
On X11, the window system is initialized if GUIenabled is true. If
GUIenabled is false, the application does not connect to
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote:
Aside Thiagos concern, what actually causes the menubar/docker item stuff?
Quoting QApplication (4.8):
On X11, the window system is initialized if GUIenabled is true. If
GUIenabled is false, the application does not connect to
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote:
Aside Thiagos concern, what actually causes the menubar/docker item stuff?
Quoting QApplication (4.8):
On X11, the window system is initialized if GUIenabled is true. If
GUIenabled is false, the application does not connect to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120355/
---
(Updated Sept. 26, 2014, 7:28 p.m.)
Review request for KDE Base Apps,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120355/#review67495
---
changing this patch to prevent just the call to
On Sept. 26, 2014, 7:40 p.m., René J.V. Bertin wrote:
changing this patch to prevent just the call to
invalidateBuffer_resizeHelper (and setting isResize=false when that
function cannot be called) shows something in place of the menu's title
exactly once. All other times the menu is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120355/#review67533
---
How about this modification if I were to modify
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120403/
---
Review request for KDE Software on Mac OS X, kdelibs and Qt KDE.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120403/
---
(Updated Sept. 28, 2014, 2:46 p.m.)
Review request for KDE Software on
On Sept. 28, 2014, 5:13 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 182
https://git.reviewboard.kde.org/r/120403/diff/1/?file=315609#file315609line182
try to avoid negated bools unless for performance or readability
reasons (ie. you'd need !flag a lot otherwise)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120431/#review67656
---
Great, it's been ... bugging me that the bug reporter hasn't
On Sept. 28, 2014, 5:13 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 220
https://git.reviewboard.kde.org/r/120403/diff/1/?file=315609#file315609line220
mehhh: branched exits.
you realise that the 2 exits don't return the exact same kind of symbol? Using
1 exit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120403/
---
(Updated Sept. 30, 2014, 10:42 p.m.)
Review request for KDE Software on
On Sept. 28, 2014, 5:13 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 220
https://git.reviewboard.kde.org/r/120403/diff/1/?file=315609#file315609line220
mehhh: branched exits.
René J.V. Bertin wrote:
you realise that the 2 exits don't return the exact same
1 - 100 of 321 matches
Mail list logo
