Re: RKWard is in kdereview - again

2023-07-04 Thread Jonathan Riddell
I've created an issue for the kdereview process https://invent.kde.org/education/rkward/-/issues/23 Jonathan On Sat, 26 Mar 2022 at 20:34, Thomas Friedrichsmeier < thomas.friedrichsme...@kdemail.net> wrote: > Hi! > > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on

Re: RKWard is in kdereview - again

2022-04-27 Thread Thomas Friedrichsmeier
Hi, On Wed, 27 Apr 2022 16:09:51 +0200 Thierry Thomas wrote: > I just upgraded RKWard to 0.7.3 (just locally, not yet in the ports > tree), and the patch of FindR.cmake is no more necessary. > > It builds and installs clearly, but I noticed 2 problems: > > 1- the tests do not run: > > >

Re: RKWard is in kdereview - again

2022-04-27 Thread Thierry Thomas
Hello, Le lun. 28 mars 22 à 16:53:28 +0200, Adriaan de Groot écrivait : > > RKWard is used productively on Linux/BSD, Mac, and Windows. > > Congratulations! RKWard has been packaged on FreeBSD for a long time already > (although it's only at version 0.7.1, not the latest release -- cc'ing

Re: RKWard is in kdereview - again

2022-03-30 Thread Nicolas Fella
On 3/30/22 17:55, Thomas Friedrichsmeier wrote: An update and some questions: Am Mon, 28 Mar 2022 15:39:55 +0200 schrieb Nicolas Fella : [...] - Consider adding a color scheme selector (KColorSchemeManager) to the menu. On Windows that gives you dark mode support for free (this only really

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier
Am Wed, 30 Mar 2022 17:55:12 +0200 schrieb Thomas Friedrichsmeier : [...] > What's troubling me more is that QWebEngineView (used, among other > things, for Help->Help on RKWard) does not adapt to the color theme at > all. I tried adding CSS rules (@media (prefers-color-scheme: dark) > {...}), but

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier
An update and some questions: Am Mon, 28 Mar 2022 15:39:55 +0200 schrieb Nicolas Fella : [...] > - Consider adding a color scheme selector (KColorSchemeManager) to the > menu. On Windows that gives you dark mode support for free (this only > really works nicely when using Breeze QStyle). See >

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Monday, 28 March 2022 17:39:17 CEST Thomas Friedrichsmeier wrote: > On Mon, 28 Mar 2022 17:09:44 +0200 > Nicolas Fella wrote: > [...] > > > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > > presumably

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 17:09:44 +0200 Nicolas Fella wrote: [...] > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > presumably due to having a different tar implementation than Linux. Sweet! > I'd appreciate

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 00:09:38 +0200 Albert Astals Cid wrote: [...] > Results of running clang-tidy with some of my favorite options > attached. Thanks! > The first group [bugprone-integer-division] seems an actual bug since >double RKGraphicsDeviceFrontendTransmitter::lwdscale = 72/96; >

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella
On 3/28/22 16:53, Adriaan de Groot wrote: On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: KDE.org has been our home for a 7.5(!) years, now (after over a decade on sourceforge), but we still haven't left playground... After a lot of procrastination on that matter, a

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
Hi, On Mon, 28 Mar 2022 15:39:55 +0200 Nicolas Fella wrote: > I recently used RKWard for my Master Thesis, cool project! thanks! > A couple of observations: > > - CommitPolicy.txt still mentions Phabricator, that should point to > Gitlab instead Done. > - CommitPolicy.txt mentions Ubuntu

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on sourceforge), but we still haven't left playground... After a > lot of procrastination on that matter, a previous review failed due to > lack of time

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella
Hi, I recently used RKWard for my Master Thesis, cool project! A couple of observations: - CommitPolicy.txt still mentions Phabricator, that should point to Gitlab instead - CommitPolicy.txt mentions Ubuntu Trusty as base for requirements, that is *ancient* by now, maybe 20.04 would be a more

Re: RKWard is in kdereview - again

2022-03-27 Thread Albert Astals Cid
El dilluns, 28 de març de 2022, a les 0:09:38 (CEST), Albert Astals Cid va escriure: > El dissabte, 26 de març de 2022, a les 21:34:06 (CEST), Thomas > Friedrichsmeier va escriure: > > Hi! > > > > KDE.org has been our home for a 7.5(!) years, now (after over a > > decade on sourceforge), but we

Re: RKWard is in kdereview - again

2022-03-27 Thread Albert Astals Cid
El dissabte, 26 de març de 2022, a les 21:34:06 (CEST), Thomas Friedrichsmeier va escriure: > Hi! > > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on sourceforge), but we still haven't left playground... After a > lot of procrastination on that matter, a previous

RKWard is in kdereview - again

2022-03-26 Thread Thomas Friedrichsmeier
Hi! KDE.org has been our home for a 7.5(!) years, now (after over a decade on sourceforge), but we still haven't left playground... After a lot of procrastination on that matter, a previous review failed due to lack of time on my part. Sorry! Now, finally, I'd like to ask you to start reviewing