---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8378
---
Ship it!
this is massively bad on the part of qt :/ what a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8379
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---
plasma/private/containment_p.h
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
plasma/private/containment_p.h, line 71
http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71
ibeg your pardon?
to me this looks like you delete the same entry forever (what *will*
crash at a point)
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
plasma/private/containment_p.h, line 71
http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71
ibeg your pardon?
to me this looks like you delete the same entry forever (what *will*
crash at a point)
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
plasma/private/containment_p.h, line 71
http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71
ibeg your pardon?
to me this looks like you delete the same entry forever (what *will*
crash at a point)
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
plasma/private/containment_p.h, line 71
http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71
ibeg your pardon?
to me this looks like you delete the same entry forever (what *will*
crash at a point)
On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
plasma/private/containment_p.h, line 71
http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71
ibeg your pardon?
to me this looks like you delete the same entry forever (what *will*
crash at a point)
On Tuesday, 22 de November de 2011 09.57.32, Thomas Lübking wrote:
is there any detailed (official) explanation on this?
Yes.
In Qt, we declared code that accessed the list in question *while* the items
are being deleted as broken by design, so we felt free to optimise qDeleteAll
by ignoring
On Tuesday, November 22, 2011 13:27:53 Thomas =?ISO-8859-1?Q?L=FCbking?=
Given a simple mutex and a qWarning() -if hit- would not only have told
people but also prevented crashes by implementation rather than by
convention, I feel required to mention that this change of
implications -as done-
10 matches
Mail list logo