Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/ --- (Updated Sept. 19, 2016, 11:46 a.m.) Status -- This change has been

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread David Faure
> On Sept. 19, 2016, 6:32 a.m., Sune Vuorela wrote: > > konqueror/src/CMakeLists.txt, line 18 > > > > > > I think the comment is wrong. I can't find any zlib references in > > konqueror itself. Also note that

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/#review99271 --- Ship it! I cleaned up the toplevel CMakeLists.txt

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/#review99267 --- I don't get the review description and its relevance to the

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread Andreas Sturmlechner
> On Sept. 19, 2016, 5:19 a.m., Rolf Eike Beer wrote: > > konqueror/src/CMakeLists.txt, line 18 > > > > > > If Konqueror directly uses these symbols it needs to explicitely link > > to it, even if libkonq does.

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-18 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/#review99266 --- konqueror/src/CMakeLists.txt

Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-18 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/ --- Review request for KDE Base Apps and David Faure. Repository: