On Monday 12 August 2013 18:06:41 Àlex Fiestas wrote:
Hi there
One of the tasks that I'm working on is Make QToolBar use KDE settings,
which include the buttonStyle.
For those that don't know, the buttonStyle is whether the QToolButton
created by QToolBar will have text along side,
On Aug. 9, 2013, 8:34 p.m., David Faure wrote:
The Qt patch is in for some time now, so we can use the new styleHint.
However this patch should be updated to pass a pointer to the widget in the
styleHint call.
Once that's done, we can finally move KGlobalSettings to kde4support
On Aug. 9, 2013, 11:49 a.m., Kevin Ottens wrote:
tier1/sonnet/src/ui/highlighter.cpp, line 237
http://git.reviewboard.kde.org/r/111912/diff/4/?file=177521#file177521line237
I still don't see what the changes in this file have to do with the
rest of the patch. Could you explain it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111943/#review37640
---
Ship it!
Ship It!
- Kevin Ottens
On Aug. 12, 2013, 5:02
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/#review37641
---
kfile/kdirselectdialog.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review37643
---
Ship it!
Ship It!
- Kevin Ottens
On Aug. 12, 2013, 10:15
On Aug. 12, 2013, 2:43 p.m., Kevin Ottens wrote:
khtml/khtml_part.cpp, line 3590
http://git.reviewboard.kde.org/r/111916/diff/3/?file=178130#file178130line3590
For extra safety I'd keep the ok here.
David Faure wrote:
No, you want to enter this branch for broken symlinks
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112032/#review37644
---
tier1/kwidgetsaddons/src/kpassivepopup.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111985/
---
(Updated Aug. 13, 2013, 8:50 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/
---
Review request for KDE Frameworks.
Description
---
ItemViews use
See http://build.kde.org/job/kdelibs_frameworks_qt5/1021/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111985/#review37660
---
Ship it!
Ship It!
- Kevin Ottens
On Aug. 13, 2013, 8:50
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/
---
(Updated Aug. 13, 2013, 9:31 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/#review37661
---
Ship it!
Ship It!
- Kevin Ottens
On Aug. 13, 2013, 9:31
On Aug. 12, 2013, 9:24 a.m., Kevin Ottens wrote:
tier1/kconfig/src/gui/CMakeLists.txt, line 15
http://git.reviewboard.kde.org/r/111945/diff/2/?file=177623#file177623line15
You will have to rebase your patch because of a commit I've pushed just
now. It should use Qt5::Gui (as
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111943/
---
(Updated Aug. 13, 2013, 9:44 a.m.)
Status
--
This change has been
On Aug. 9, 2013, 1:49 p.m., Kevin Ottens wrote:
tier1/sonnet/src/ui/highlighter.cpp, line 237
http://git.reviewboard.kde.org/r/111912/diff/4/?file=177521#file177521line237
I still don't see what the changes in this file have to do with the
rest of the patch. Could you explain it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/
---
(Updated Aug. 13, 2013, 12:25 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/#review37673
---
Ship it!
Ship It!
- Kevin Ottens
On Aug. 13, 2013, 10:25
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/
---
Review request for KDE Frameworks.
Description
---
port
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/
---
(Updated Aug. 13, 2013, 11:06 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/#review37676
---
Can it maybe even be a QCoreApplication?
- Albert Astals Cid
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/
---
Review request for KDE Frameworks.
Description
---
Proper
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/#review37681
---
Interesting: Copyright 2009 Marco Martin notm...@gmail.com. I
So, last thing to discuss about Make QToolBar follow KDE settings is the
differentiation we do between Main Toolbar and just Toolbar.
Effectively a Main Toolbar is usually a toolbar that is a child of QMainWindow
while a ToolBar is a toolbar who's parent is another QWidget.
While Qt doesn't
On Aug. 13, 2013, 2:01 p.m., Mark Gaiser wrote:
Interesting: Copyright 2009 Marco Martin notm...@gmail.com. I think you
need to adjust the license part in those new files.
why? The copyright is still correct. Marco has been the one who wrote that code
back in 2009. What I just changed is
On Aug. 13, 2013, 12:01 p.m., Mark Gaiser wrote:
Interesting: Copyright 2009 Marco Martin notm...@gmail.com. I think you
need to adjust the license part in those new files.
Martin Gräßlin wrote:
why? The copyright is still correct. Marco has been the one who wrote
that code back
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/
---
(Updated Aug. 13, 2013, 12:16 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/#review37685
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/#review37683
---
Finding dependencies in config files is a
See http://build.kde.org/job/kdelibs_frameworks_qt5/1025/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Aug. 13, 2013, 2:01 p.m., Mark Gaiser wrote:
Interesting: Copyright 2009 Marco Martin notm...@gmail.com. I think you
need to adjust the license part in those new files.
Martin Gräßlin wrote:
why? The copyright is still correct. Marco has been the one who wrote
that code back
On Tuesday 13 August 2013 14:00:37 Àlex Fiestas wrote:
Effectively a Main Toolbar is usually a toolbar that is a child of
QMainWindow while a ToolBar is a toolbar who's parent is another
QWidget.
A secondary toolbar is every toolbar not called the Main Toolbar.
For example in Konqueror, the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112054/
---
Review request for KDE Frameworks.
Description
---
Request
On Tuesday 13 August 2013 15:05:46 Christoph Feck wrote:
On Tuesday 13 August 2013 14:00:37 Àlex Fiestas wrote:
Effectively a Main Toolbar is usually a toolbar that is a child of
QMainWindow while a ToolBar is a toolbar who's parent is another
QWidget.
A secondary toolbar is every
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112054/#review37694
---
Ship it!
Ship It!
- Kevin Ottens
On Aug. 13, 2013, 1:14
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112054/
---
(Updated Aug. 13, 2013, 1:57 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112054/#review37695
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/
---
(Updated Aug. 13, 2013, 2:12 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/
---
(Updated Aug. 13, 2013, 2:28 p.m.)
Review request for KDE Frameworks and
See http://build.kde.org/job/kdelibs_frameworks_qt5/1027/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hello everyone,
This is the minutes of the Week 33 KF5 meeting. As usual it has been held on
#kde-devel at 4pm Paris time.
Were present: afiestas, agateau, apol, d_ed, mck182, mgraesslin, sebas,
shadeslayer, vHanda, wojtask9 and myself.
Announcement:
* Focus for the coming week is on closing
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/#review37699
---
Ship it!
Ship It!
- Stephen Kelly
On Aug. 13, 2013, 2:28
So this open email has been lingering in my inbox for more than a week. Fail.
During Akademy, we talked about quite some strategical stuff, as opposed to
the below more applied items.
Devajah, since you have all the notes and wrote up a good part of it already,
would you send this material
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/#review37702
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/
---
(Updated Aug. 13, 2013, 3:35 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kdelibs_frameworks_qt5/1028/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112064/
---
Review request for KDE Frameworks.
Description
---
Port S_IS*(x)
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/
---
(Updated Aug. 13, 2013, 5:18 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/
---
Review request for KDE Frameworks.
Description
---
Everything in
On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote:
Can it maybe even be a QCoreApplication?
Probably yes :) Kevin?
- Wojciech
---
This is an automatically generated e-mail. To reply, visit:
FindDBusMenuQt5.cmake is staging/knotifications
kf5libs finds DBusMenuQt5
-- DBusMenuQt5_INCLUDE_DIR=/opt/qt5/include/dbusmenu-qt5
DBusMenuQt5_LIBRARY=/opt/qt5/lib/libdbusmenu-qt5.so DBusMenuQt5_VERSION=0.9.2
but kwin5 does not
CMake Warning at CMakeLists.txt:82 (find_package):
By not
On Aug. 13, 2013, 12:53 a.m., Patrick Spendrin wrote:
Patrick Spendrin wrote:
In general of course: thanks for your review request, one of the small
nice overdue features!
How does this work on Linux, e.g. do the changes to the .desktop file
affect Linux here?
In desktop
On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote:
Patrick Spendrin wrote:
In general of course: thanks for your review request, one of the small
nice overdue features!
How does this work on Linux, e.g. do the changes to the .desktop file
affect Linux here?
Pali Rohár
On Aug. 13, 2013, 12:53 a.m., Patrick Spendrin wrote:
Patrick Spendrin wrote:
In general of course: thanks for your review request, one of the small
nice overdue features!
How does this work on Linux, e.g. do the changes to the .desktop file
affect Linux here?
Pali Rohár
On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote:
Patrick Spendrin wrote:
In general of course: thanks for your review request, one of the small
nice overdue features!
How does this work on Linux, e.g. do the changes to the .desktop file
affect Linux here?
Pali Rohár
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37672
---
Looks good to me.
Wait for Marco or Sebas to tell you to Ship
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37675
---
It's looking good already, a few stylistic remarks inline, and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/
---
(Updated Aug. 13, 2013, 12:37 p.m.)
Review request for kde-workspace and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37698
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/
---
(Updated Aug. 13, 2013, 3:16 p.m.)
Review request for kde-workspace and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37700
---
Ship it!
Ship It!
- Sebastian Kügler
On Aug. 13, 2013,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/
---
(Updated Aug. 13, 2013, 3:31 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111953/
---
(Updated Aug. 13, 2013, 5:57 p.m.)
Review request for kdelibs and Stephen
On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote:
Have you tried kdepim applications with this patch too? Many of them use
this class.
I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks
like it's working, but I am not familiar with this application so I am
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111953/
---
(Updated Aug. 13, 2013, 5:59 p.m.)
Review request for kdelibs, Michael
On Aug. 9, 2013, 12:59 p.m., Stephen Kelly wrote:
Have you tried kdepim applications with this patch too? Many of them use
this class.
Aurélien Gâteau wrote:
I just grepped in kdepim, it seems only kmail-mobile makes use of it. It
looks like it's working, but I am not familiar
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111952/#review37713
---
Ship it!
Ship It!
- Gabi Sarkis
On Aug. 8, 2013, 7:12
On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote:
Ship It!
Sorry about that. How do I go about Shipping it?
Thanks
- Gabi
---
This is an automatically generated e-mail. To reply, visit:
On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote:
Ship It!
Gabi Sarkis wrote:
Sorry about that. How do I go about Shipping it?
Thanks
Just commit it into the repo or ask someone to do it for you.
Commit message should contain a separate string REVIEW: 111952 to close this
On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote:
Ship It!
Gabi Sarkis wrote:
Sorry about that. How do I go about Shipping it?
Thanks
Yuri Chornoivan wrote:
Just commit it into the repo or ask someone to do it for you.
Commit message should contain a
On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote:
Ship It!
Gabi Sarkis wrote:
Sorry about that. How do I go about Shipping it?
Thanks
Yuri Chornoivan wrote:
Just commit it into the repo or ask someone to do it for you.
Commit message should contain a
On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote:
Ship It!
Gabi Sarkis wrote:
Sorry about that. How do I go about Shipping it?
Thanks
Yuri Chornoivan wrote:
Just commit it into the repo or ask someone to do it for you.
Commit message should contain a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112068/
---
Review request for kdelibs and KDE Utils.
Description
---
Attached
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112068/#review37740
---
Don't put QChar in your structures. That makes them non-POD.
hello,
i am intrested in your project localization team management tool and
want to contribute to open source software.
regards
Abhishek
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Hello Abhishek,
You need to contact the sub-project maintainers as it is mentioned on the
idea page itself. Their email IDs are given ( '@' is replaced by 'at' for
safety of the email IDs). They will be able to guide you more closely.
I am assuming that you want to apply to Season of KDE (SoK) to
El Dilluns, 12 d'agost de 2013, a les 10:03:54, Abhishek gupta va escriure:
hello,
Hello-
i am intrested in your project localization team management tool and
want to contribute to open source software.
Please send e-mails with subject next time.
Cheers,
Albert
regards
Abhishek
78 matches
Mail list logo
