Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

2013-11-08 Thread David Faure
On Friday 08 November 2013 08:23:52 Aurélien Gâteau wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initially

Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

2013-11-08 Thread Martin Klapetek
On Fri, Nov 8, 2013 at 9:23 AM, Aurélien Gâteau agat...@kde.org wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I

Re: Review Request 113701: Fix KBookmarks standalone build

2013-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/#review43248 --- Ship it! Ship It! - David Faure On Nov. 7, 2013, 10:38

Re: Review Request 113686: Fix KParts standalone build

2013-11-08 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43252 --- Ship it! Tested, it builds both independently and with the

Re: Review Request 113695: Fix KDEWebKit standalone build

2013-11-08 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/#review43253 --- Ship it! Tested, it builds and looks good. - Àlex Fiestas

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-08 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/#review43254 --- Ship it! I think this can go in once the comment is changed.

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

2013-11-08 Thread Alex Merry
On Nov. 8, 2013, 5:38 a.m., Martin Gräßlin wrote: tier2/knotifications/tests/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/113712/diff/1/?file=211813#file211813line22 do you need to link XLib? From the code changes you did it looks like you don't use any XLib call at

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

2013-11-08 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 8, 2013, 12:12 p.m.) Review request for KDE Frameworks.

Re: Review Request 113694: Fix KNewStuff standalone build

2013-11-08 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/#review43256 --- Ship it! Looks good, builds standalone and with frameworks.

Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build

2013-11-08 Thread Aurélien Gâteau
On Fri, 8 Nov 2013 09:59:37 +0100, Martin Klapetek wrote: On Fri, Nov 8, 2013 at 9:23 AM, Aurélien Gâteau wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Aurélien Gâteau
On Nov. 7, 2013, 1:47 p.m., Aurélien Gâteau wrote: superbuild/CMakeLists.txt, line 34 http://git.reviewboard.kde.org/r/113702/diff/1/?file=211375#file211375line34 kemoticons should be listed after kservice, otherwise superbuild won't pick up the standalone version of it.

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43260 --- Ship it! Ship It! - Aurélien Gâteau On Nov. 7, 2013, 11:47

Re: Review Request 113701: Fix KBookmarks standalone build

2013-11-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/ --- (Updated Nov. 8, 2013, 3:13 p.m.) Status -- This change has been

Re: Review Request 113701: Fix KBookmarks standalone build

2013-11-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/#review43263 --- This review has been submitted with commit

Re: Review Request 112896: Rework NETWM classes

2013-11-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Nov. 8, 2013, 4:14 p.m.) Review request for KDE Frameworks.

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

2013-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43271 --- Please use X11 stuff conditionally (Q_WS_X11). - Andrius da

Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43278 --- This review has been submitted with commit

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 8, 2013, 7:41 p.m.) Status -- This change has been

Re: Review Request 113703: Fix KRoss standalone build

2013-11-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43280 --- This review has been submitted with commit

Re: Review Request 113703: Fix KRoss standalone build

2013-11-08 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/ --- (Updated Nov. 8, 2013, 8:16 p.m.) Status -- This change has been

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

2013-11-08 Thread Alex Merry
On Nov. 8, 2013, 4:25 p.m., Andrius da Costa Ribas wrote: Please use X11 stuff conditionally (Q_WS_X11). There's no need to put conditionals in the file (since the whole thing is conditionally compiled), but the linking should be done conditionally. Specifically, you should take

kdelibs/interfaces/khexedit

2013-11-08 Thread David Faure
Hi Friedrich, I'm looking at interfaces/khexedit in kdelibs-frameworks, and wondering what to do with it. Are you still happy with it? Should we bring it into the KF5 world? If so, we need to find a place for it. It's only header files so it could be installed by any framework without any

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43285 --- staging/kio/CMakeLists.txt

Question about kimproxy

2013-11-08 Thread David Faure
Hi Will, I'm looking at interfaces/kimproxy in kdelibs, which has your copyright. http://lxr.kde.org/ident?i=KIMProxy says that it's now unused in all of KDE SC, the only user is playground/pim/leute/services/imaddress/ but an interface requires a provider and a user anyway, so surely this

the kspeech interface

2013-11-08 Thread David Faure
Hi Jeremy, I'm looking at kdelibs-frameworks/interface/kspeech, and trying to find a home for it, in the KF5 reorganization. I see that it's actually used in a number of places (http://lxr.kde.org/ident?i=soPlainText for instance). and that it's basically just a header file that depends only on

Re: the kspeech interface

2013-11-08 Thread Jeremy Whiting
I was actually wondering that myself the other day as I added to it in kdelibs master (that got branched into KDE/4.12) for a feature that hit jovie in KDE SC 4.12. It's used but really only needed to expose jovie's dbus interface for applications to use. Interestingly, knotify uses jovie but

Re: the kspeech interface

2013-11-08 Thread Jeremy Whiting
Oops, that link was just users of soPlainText. It seems http://lxr.kde.org/ident?i=KSpeech the class itself is used in quite a few places, and is how any application uses speech capabilities. I guess kdbusaddons is as good a place as any for it and it will need to stay in kdelibs itself. On Fri,

Re: Review Request 113714: Call KXMLGUIFactory::reset() before we start building the UI in createGUI()

2013-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113714/#review43251 --- Ship it! The analysis and patch seem correct. I was

Re: Can we make api.kde.org search better?

2013-11-08 Thread Allen Winter
On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: Hi, yesterday i was talking with someone about the desktop file class we have in KDE, he tried to find its api by going to api.kde.org and typing desktop in the Search bar. If you do that

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review43272 --- ping? may I ship it? - Andrius da Costa Ribas On Aug. 17,

Re: Adopting AppData in KDE?

2013-11-08 Thread Todd
On Tue, Nov 5, 2013 at 6:21 PM, Richard Hughes hughsi...@gmail.com wrote: On 5 November 2013 17:12, Todd toddr...@gmail.com wrote: For project_group/, I think it would be good to allow arbitrary groups rather than limiting it to only a few recognized groups. I think restricting it to the

Re: Can we make api.kde.org search better?

2013-11-08 Thread Michael Reeves
On Nov 5, 2013 6:44 PM, Albert Astals Cid aa...@kde.org wrote: Well Michael Reeves volunteered, no? Allen are you sending him the data? Cheers, Albert Aleix I got the data.

Re: Adopting AppData in KDE?

2013-11-08 Thread Todd
On Nov 5, 2013 6:42 PM, Richard Hughes hughsi...@gmail.com wrote: On 5 November 2013 17:37, Todd toddr...@gmail.com wrote: Define ChangeLog? You mean what changed between versions? Yes, as well as the version number and date, probably. I'd be open to ideas about this. Can you file an issue

Re: Adopting AppData in KDE?

2013-11-08 Thread Todd
On Tue, Nov 5, 2013 at 9:49 PM, Matthias Klumpp matth...@tenstral.netwrote: 2013/11/5 Todd toddr...@gmail.com: [...] Looking at the spec, I have a few suggestions: (I assume you mean the AppStream spec) For project_group/, I think it would be good to allow arbitrary groups rather than

Re: Adopting AppData in KDE?

2013-11-08 Thread T.C. Hollingsworth
On Tue, Nov 5, 2013 at 1:53 PM, Matthias Klumpp matth...@tenstral.net wrote: Hi! In order to solve the translation-issues: I think KDE could very well use Scripty to insert translations into the AppData files. I wrote a draft patch to do this already:

Re: Adopting AppData in KDE?

2013-11-08 Thread T.C. Hollingsworth
On Wed, Nov 6, 2013 at 1:40 AM, Richard Hughes hughsi...@gmail.com wrote: I'm not sure how well this will work, at least in gnome-software we allow the user to match on a keyword cache using the C name, and also the UTF8 and normalized versions of their current locale. Nah, I meant for the

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Ralf Habacker
On Nov. 8, 2013, 5:31 p.m., Andrius da Costa Ribas wrote: ping? may I ship it? I can confirm that this patch works on linux opensuse 12.2 with kde 4.11. Exe and windows thumbnail are visible in dolphin with installed icoutils package and enabled preview. - Ralf

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review43284 --- Ship it! Because of the icoutils requirement on non windows

CMake 2.8.12.1 Released

2013-11-08 Thread Robert Maynard
Some serious problems were reported with the 2.8.12 release. Thanks to the swift work of Brad King, Stephen Kelly, Modestas Vainius and Vladislav Vinogradov, those problems have been fixed. We've prepared a 2.8.12.1 bug fix release to address those issues. Some of the notable changes in this

Re: Network Applet

2013-11-08 Thread Lindsay Mathieson
Using my VPN connection with the new applet - it provides zero feed back on connection failures. Just goes italic briefly. Is it possible to use the old one? -- Lindsay signature.asc Description: This is a digitally signed message part. Visit