Re: Review Request 120438: improve baloo file indexing overhead by ~2.5x

2015-02-04 Thread Vishesh Handa
On Oct. 14, 2014, 10:50 a.m., Vishesh Handa wrote: Oh, also. You might want to rebase your patch on top of master. Many things have changed. Vishesh Handa wrote: Ping? In Baloo, we're currently in the process of moving away from both xapian and sqlite. This patch is no longer

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

2015-02-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122359/#review75428 --- Ship it! kde-modules/KDECMakeSettings.cmake

Re: KDE backward compatibility issue

2015-02-04 Thread Sebastian Kügler
On Friday, January 30, 2015 13:41:42 Vasily Khoruzhick wrote: There're some proprietary applications using xembed tray and Qt5 5.4, for example - dropbox and viber. There's no way to fix them. There are patches for Qt 5.4 around which are have been shipped by various distributions for quite

Re: Review Request 120939: [OS X] turn baloo services into proper background agents and use IOPOL_THROTTLE for lower priority IO

2015-02-04 Thread Vishesh Handa
On Nov. 19, 2014, 10:15 a.m., Vishesh Handa wrote: Hey. Thanks a lot for doing this. I didn't manage to have a look at it over the last 2 weeks. I don't think we're going to be having any more releases for Baloo for KDE4. If you want I can forward port this to Qt5? René J.V.

Re: Review Request 120939: [OS X] turn baloo services into proper background agents and use IOPOL_THROTTLE for lower priority IO

2015-02-04 Thread René J . V . Bertin
On Nov. 19, 2014, 11:15 a.m., Vishesh Handa wrote: Hey. Thanks a lot for doing this. I didn't manage to have a look at it over the last 2 weeks. I don't think we're going to be having any more releases for Baloo for KDE4. If you want I can forward port this to Qt5? René J.V.

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/#review75430 --- src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

Re: Framework Categories

2015-02-04 Thread Jeremy Whiting
Ok, I've changed knewstuff to a solution type. Should all frameworks that depend on kio be also changed to solution type ? On Tue, Feb 3, 2015 at 11:54 PM, Kevin Ottens er...@kde.org wrote: On Tuesday 03 February 2015 12:53:08 Jeremy Whiting wrote: Hey frameworks developers, Albert wrote

Re: KDE backward compatibility issue

2015-02-04 Thread Vasily Khoruzhick
Hi Sebastian, On Wed, Feb 4, 2015 at 8:15 PM, Sebastian Kügler se...@kde.org wrote: There are patches for Qt 5.4 around which are have been shipped by various distributions for quite some time. Martin's blog, which you linked from your initial email, links them:

Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/ --- (Updated Feb. 4, 2015, 5:46 p.m.) Review request for KDE Frameworks and

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/#review75432 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 5:46

Re: Review Request 117829: do not raise unknown signal on windows

2015-02-04 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117829/ --- (Updated Feb. 4, 2015, 4:09 p.m.) Status -- This change has been

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2015-02-04 Thread Vishesh Handa
On Aug. 7, 2014, 4:57 p.m., Vishesh Handa wrote: src/pim/agent/collectionindexer.cpp, line 89 https://git.reviewboard.kde.org/r/119441/diff/1/?file=292237#file292237line89 Be careful with this. Indexing phrases nearly doubles the size of the index. Considering the amount people

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Martin Sandsmark
On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE software, Qt libraries, xorg libraries, or the keyboard layout definition files.

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Martin Sandsmark
On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE software, Qt libraries, xorg libraries, or the keyboard layout definition files.

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread Marco Martin
On Feb. 4, 2015, 5:18 p.m., David Edmundson wrote: src/qmlcontrols/kquickcontrolsaddons/plotter.cpp, line 363 https://git.reviewboard.kde.org/r/122430/diff/1/?file=347017#file347017line363 to match the docs this possibly wants a || autoRange otherwise it is

Re: Moving KDE Telepathy to kdenetwork

2015-02-04 Thread Pali Rohár
On Wednesday 04 February 2015 01:51:49 Albert Astals Cid wrote: El Dimarts, 3 de febrer de 2015, a les 00:49:17, Martin Klapetek va escriure: Hi, so we decided with KDE Telepathy to join the big guys and become part of KDE Applications 15.04. So I'd like to request a move of KDE

Jenkins build became unstable: kservice_master_qt5 #231

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/kservice_master_qt5/231/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #986

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_stable_qt5 » All,LINBUILDER #96

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=All,label=LINBUILDER/96/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kde-baseapps_master_qt5 #221

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_master_qt5/221/changes Changes: [emmanuelpescosta099] Port KonqCopyToMenu to KFileCopyToMenu -- [...truncated 3027 lines...] QProcess::execute(KGlobal::dirs()-findExe(KBUILDSYCOCA_EXENAME));

Re: [Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

2015-02-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122414/#review75361 --- daemon/actions/dpms/powerdevildpmsaction.cpp

Build failed in Jenkins: kde-baseapps_master_qt5 #222

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_master_qt5/222/changes Changes: [emmanuelpescosta099] Solved TODO: KWindowConfig::saveWindowSize/restoreWindowSize in DolphinSettingsDialog [emmanuelpescosta099] Port away from KGlobal::mainComponent() --

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 --- startkde/kcminit/CMakeLists.txt

Build failed in Jenkins: kde-baseapps_master_qt5 #223

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_master_qt5/223/changes Changes: [emmanuelpescosta099] Port Dolphin away from KApplication, KCmdLineArgs and K4AboutData [emmanuelpescosta099] Add dolphin dbus service -- [...truncated 3009 lines...] ^

Re: KDE backward compatibility issue

2015-02-04 Thread Milian Wolff
On Wednesday 04 February 2015 20:42:53 Vasily Khoruzhick wrote: Hi Sebastian, On Wed, Feb 4, 2015 at 8:15 PM, Sebastian Kügler se...@kde.org wrote: There are patches for Qt 5.4 around which are have been shipped by various distributions for quite some time. Martin's blog, which you

Re: KDE backward compatibility issue

2015-02-04 Thread Vasily Khoruzhick
On Wed, Feb 4, 2015 at 9:57 PM, Milian Wolff m...@milianw.de wrote: Every application? You mention two. Well, at least these two are affected. I can also mention tuxguitar which uses Java and SWT, however I don't care about its tray icon. And if they, or others, don't care about us, why

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/#review75439 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 7:52

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75433 --- Can you explain why the count is different and why XCB's

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-04 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 4, 2015, 7:18 p.m.) Status -- This change has been

Re: make uninstall

2015-02-04 Thread Alex Merry
On Monday 02 February 2015 21:49:22 Albert Astals Cid wrote: El Divendres, 30 de gener de 2015, a les 10:47:22, Alex Merry va escriure: On Friday 30 January 2015 10:44:23 Alex Merry wrote: Over on kde-frameworks-devel, there have been several requests to bring back `make uninstall` for

Re: KDE backward compatibility issue

2015-02-04 Thread Vasily Khoruzhick
Hi Milian, On Wed, Feb 4, 2015 at 9:04 PM, Milian Wolff m...@milianw.de wrote: If these apps link against Qt5 statically (which they can, assuming they pay the license fees to Digia), then they will need to recompile and release an updated version. If otoh they just ship they own set of libs

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- (Updated Feb. 4, 2015, 7:52 p.m.) Review request for KDE Frameworks and

Re: KDE backward compatibility issue

2015-02-04 Thread Milian Wolff
On Wednesday 04 February 2015 21:49:15 Vasily Khoruzhick wrote: Hi Milian, On Wed, Feb 4, 2015 at 9:04 PM, Milian Wolff m...@milianw.de wrote: If these apps link against Qt5 statically (which they can, assuming they pay the license fees to Digia), then they will need to recompile and

Re: make uninstall

2015-02-04 Thread Milian Wolff
On Wednesday 04 February 2015 18:33:42 Alex Merry wrote: On Monday 02 February 2015 21:49:22 Albert Astals Cid wrote: El Divendres, 30 de gener de 2015, a les 10:47:22, Alex Merry va escriure: On Friday 30 January 2015 10:44:23 Alex Merry wrote: Over on kde-frameworks-devel, there have

Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/#review75438 --- src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Albert Astals Cid
El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE

Re: LibRingClient has moved to extragear/network

2015-02-04 Thread Luigi Toscano
Elv1313 . ha scritto: Hi, After going through kdereview for the last few weeks, libringclient (formerly the sflphone-kde client logic library) is now moving to KDE extragear. I am currently starting to remove the legacy Qt4 support still required by the KDE4 client (and porting it to kf5)

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Albert Astals Cid
El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Feb. 4, 2015, 8:59 p.m.) Status -- This change has been

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Christoph Feck
On Wednesday 04 February 2015 21:51:53 Albert Astals Cid wrote: El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some

Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

2015-02-04 Thread Christoph Feck
On Dec. 8, 2014, 2:15 p.m., Sebastian Kügler wrote: solid-device-automounter/kcm/DeviceAutomounterKCM.ui, line 45 https://git.reviewboard.kde.org/r/121361/diff/1/?file=331961#file331961line45 Well, with this change, the whatsthis and I suppose the function of this checkbox does

kross: src/core/metafunction.h:89 char* to QByteArrayData*

2015-02-04 Thread Maximiliano Curia
Hi, As part of the packaging efforts in Debian we are testing the installed headers to check that they compile correctly and have all their dependencies installed. Testing kross we found this: // static metaobject staticMetaObject.d.superdata = QObject::staticMetaObject;

a problem with kdesktopfile.cpp

2015-02-04 Thread Guy Maurel
Hello! I wonder about the code of kdesktopfile.cpp at line 80: ... QString KDesktopFile::locateLocal(const QString path) { QString relativePath; // Relative to config? (e.g. for autostart) Q_FOREACH (const QString dir,

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Christoph Feck
On Wednesday 04 February 2015 21:51:53 Albert Astals Cid wrote: El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Martin Sandsmark
On Wed, Feb 04, 2015 at 09:51:53PM +0100, Albert Astals Cid wrote: Even if it's an upstream bug, in my opinion the BugOfTheMonth+GardeningEffort is showing the users that we care, and if they are affected by a severe bug we're going to try to make as much as we can to fix it, not just toss it

Re: Help solving this month's Bug of the Month

2015-02-04 Thread Martin Sandsmark
On Wed, Feb 04, 2015 at 09:51:53PM +0100, Albert Astals Cid wrote: Even if it's an upstream bug, in my opinion the BugOfTheMonth+GardeningEffort is showing the users that we care, and if they are affected by a severe bug we're going to try to make as much as we can to fix it, not just toss it

Re: Re: KDE backward compatibility issue

2015-02-04 Thread Martin Gräßlin
On Wednesday 04 February 2015 22:15:54 Vasily Khoruzhick wrote: On Wed, Feb 4, 2015 at 9:57 PM, Milian Wolff m...@milianw.de wrote: Every application? You mention two. Well, at least these two are affected. I can also mention tuxguitar which uses Java and SWT, however I don't care about its

Re: KDE Frameworks Sprint

2015-02-04 Thread Mark Gaiser
On Wed, Feb 4, 2015 at 1:33 AM, Aleix Pol aleix...@kde.org wrote: Hello, Do we want a KDE Frameworks sprint? I think it could be interesting, at least to recapitulate about the first year of KF5, find what we liked and decide how to keep going. Who would be interested? Me :) I would

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
On Фев. 4, 2015, 9:16 д.п., Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6 you forgot to git add the config-xcb.h.cmake i know. its contents is the following: /* Define if you have XCB at

Jenkins build is still unstable: plasma-framework_stable_qt5 » All,LINBUILDER #97

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75386 --- Ship it! looks better, tough i think the setPaintRect() can

Re: Moving KDE Telepathy to kdenetwork

2015-02-04 Thread Martin Klapetek
On Wed, Feb 4, 2015 at 1:51 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 3 de febrer de 2015, a les 00:49:17, Martin Klapetek va escriure: Hi, so we decided with KDE Telepathy to join the big guys and become part of KDE Applications 15.04. So I'd like to request a move of

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #987

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/987/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kde-baseapps_master_qt5 #224

2015-02-04 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_master_qt5/224/changes Changes: [bhush94] add debug message to check CI failure -- [...truncated 2741 lines...] #pragma message(TODO KF5: Port Sonnet::ConfigDialog usage somehow)

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-04 Thread Marco Martin
On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote: src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115 https://git.reviewboard.kde.org/r/122413/diff/4/?file=346726#file346726line115 i'm not sure setting the panted rect in paint changes anything. since it's done

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Martin Gräßlin
On Feb. 4, 2015, 10:16 a.m., Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6 you forgot to git add the config-xcb.h.cmake Nick Shaforostoff wrote: i know. its contents is the

Help solving this month's Bug of the Month

2015-02-04 Thread Christoph Feck
Hi developers! The KDE Gardening Team nominates one particular annoying bug as “The Bug of the Month”, see https://community.kde.org/Gardening This time, we need someone who can investigate a problem with keyboard shortcuts when a certain order of keyboard layouts is used:

Help solving this month's Bug of the Month

2015-02-04 Thread Christoph Feck
Hi developers! The KDE Gardening Team nominates one particular annoying bug as “The Bug of the Month”, see https://community.kde.org/Gardening This time, we need someone who can investigate a problem with keyboard shortcuts when a certain order of keyboard layouts is used:

Re: a problem with kdesktopfile.cpp

2015-02-04 Thread Nicolás Alvarez
2015-02-04 15:54 GMT-03:00 Guy Maurel guy.mau...@kde.org: Hello! I wonder about the code of kdesktopfile.cpp at line 80: ... QString KDesktopFile::locateLocal(const QString path) { QString relativePath; // Relative to config? (e.g. for autostart) Q_FOREACH (const QString dir,