On 04/15/2017 10:53 PM, Luca Beltrame wrote:
> I can't understand the error thrown by ki18n (when it does not build) or I'd
> have attempted to fix it myself...
Hi, sorry for my delayed response.
Should we disable the ki18n bindings at this point? I'm fine with doing
that until someone can
rjvbb added a comment.
I was going to reflect that it would be better to set `init` in an atomic
operation, but:
In https://phabricator.kde.org/D5966#111735, @tfry wrote:
> On further investigation, I see that qsrand() would probably have to be
called for //each// thread, in any
tfry added a comment.
On further investigation, I see that qsrand() would probably have to be
called for //each// thread, in any case. So that would mean keeping track of
initialization state in a QThreadStorage?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R271:8b79a5374afc: Don't include the pid in the dbus path when
on flatpak (authored by apol).
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5775?vs=14782=14825
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R271 KDBusAddons
BRANCH
arcpatch-D5775
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich, aacid
Cc: dfaure, davidedmundson, aacid
tfry created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Consider the following scenario: Thread A calls KRandom::random(), for the
first time.
It will now go through a (relatively) expensive
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D5912
REVISION DETAIL
https://phabricator.kde.org/D5912
To: mart, #plasma, hein, davidedmundson
Cc: broulik, davidedmundson, plasma-devel,
davidedmundson added a comment.
Offtopic, but in future can you adjust the summary when rewriting a patch
rather than leaving a comment, it's easier to read. Phab still keeps the
history if we need it.
So this is for fixing when we have a mainItem whose size is bigger/smaller
than its
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:487
> +}
> +Q_ASSERT(mainItem);
> +Q_ASSERT(mainItemLayout);
Those asserts are redundant now
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5912
To: mart, #plasma, hein,
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in tooltipdialog.cpp:45
> Calling set flags explicitly and set type explicitly is conflicting.
now just uses settype, tested on x11, still works and tooltip windows still has
_NET_WM_WINDOW_TYPE_TOOLTIP
settype is needed in
mart updated this revision to Diff 14809.
mart added a comment.
- use settype, not setflags
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5912?vs=14690=14809
BRANCH
arcpatch-D5912
REVISION DETAIL
https://phabricator.kde.org/D5912
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> tooltipdialog.cpp:45
> setLocation(Plasma::Types::Floating);
> +setType(Dialog::WindowType::Tooltip);
>
Calling set flags
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/dialogresize
REVISION DETAIL
https://phabricator.kde.org/D5912
To: mart, #plasma, hein
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
mart added a comment.
ping?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5912
To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored
by mart).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14582=14807
REVISION DETAIL
I finally got annoyed with the obscenely large xml file we had for
projects and wrote a RESTful api to replace it.
https://projects.kde.org/api/
https://cgit.kde.org/sysadmin/projects-api.git/
Usage example
https://cgit.kde.org/releaseme.git/commit?id=d5ae8f9b3a56b0521e84b6e5955faecb6e6099c0
On Tue, May 23, 2017 at 6:31 PM, Aleix Pol wrote:
> On Sun, Apr 23, 2017 at 12:52 PM, Volker Krause wrote:
>> Hi,
>>
>> we have talked about the above topics a couple of times in the past, from
>> what
>> I remember usually agreeing it would be nice to have
intelfx added a comment.
In https://phabricator.kde.org/D5802#109416, @mwolff wrote:
> Then I can also apply the patch locally and try it out myself and maybe
come up with a concrete idea to fix this all.
So, do you have any ideas?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
18 matches
Mail list logo