Re: Problems with Python bindings in KF5

2017-05-24 Thread Stephen Kelly
On 04/15/2017 10:53 PM, Luca Beltrame wrote: > I can't understand the error thrown by ki18n (when it does not build) or I'd > have attempted to fix it myself... Hi, sorry for my delayed response. Should we disable the ki18n bindings at this point? I'm fine with doing that until someone can

D5966: Fix race-condition in KRandom-seeding.

2017-05-24 Thread René J . V . Bertin
rjvbb added a comment. I was going to reflect that it would be better to set `init` in an atomic operation, but: In https://phabricator.kde.org/D5966#111735, @tfry wrote: > On further investigation, I see that qsrand() would probably have to be called for //each// thread, in any

D5966: Fix race-condition in KRandom-seeding.

2017-05-24 Thread Thomas Friedrichsmeier
tfry added a comment. On further investigation, I see that qsrand() would probably have to be called for //each// thread, in any case. So that would mean keeping track of initialization state in a QThreadStorage? REPOSITORY R244 KCoreAddons REVISION DETAIL

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-24 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R271:8b79a5374afc: Don't include the pid in the dbus path when on flatpak (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5775?vs=14782=14825

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-24 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH arcpatch-D5775 REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich, aacid Cc: dfaure, davidedmundson, aacid

D5966: Fix race-condition in KRandom-seeding.

2017-05-24 Thread Thomas Friedrichsmeier
tfry created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Consider the following scenario: Thread A calls KRandom::random(), for the first time. It will now go through a (relatively) expensive

D5912: minimize dialog resizes/moves

2017-05-24 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein, davidedmundson Cc: broulik, davidedmundson, plasma-devel,

D5912: minimize dialog resizes/moves

2017-05-24 Thread David Edmundson
davidedmundson added a comment. Offtopic, but in future can you adjust the summary when rewriting a patch rather than leaving a comment, it's easier to read. Phab still keeps the history if we need it. So this is for fixing when we have a mainItem whose size is bigger/smaller than its

D5912: minimize dialog resizes/moves

2017-05-24 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > dialog.cpp:487 > +} > +Q_ASSERT(mainItem); > +Q_ASSERT(mainItemLayout); Those asserts are redundant now REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein,

D5912: minimize dialog resizes/moves

2017-05-24 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in tooltipdialog.cpp:45 > Calling set flags explicitly and set type explicitly is conflicting. now just uses settype, tested on x11, still works and tooltip windows still has _NET_WM_WINDOW_TYPE_TOOLTIP settype is needed in

D5912: minimize dialog resizes/moves

2017-05-24 Thread Marco Martin
mart updated this revision to Diff 14809. mart added a comment. - use settype, not setflags REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14690=14809 BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D5912

D5912: minimize dialog resizes/moves

2017-05-24 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tooltipdialog.cpp:45 > setLocation(Plasma::Types::Floating); > +setType(Dialog::WindowType::Tooltip); > Calling set flags

D5912: minimize dialog resizes/moves

2017-05-24 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/dialogresize REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,

D5912: minimize dialog resizes/moves

2017-05-24 Thread Marco Martin
mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D5757: add requestToggleKeepAbove/below

2017-05-24 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14582=14807 REVISION DETAIL

projects api alpha

2017-05-24 Thread Harald Sitter
I finally got annoyed with the obscenely large xml file we had for projects and wrote a RESTful api to replace it. https://projects.kde.org/api/ https://cgit.kde.org/sysadmin/projects-api.git/ Usage example https://cgit.kde.org/releaseme.git/commit?id=d5ae8f9b3a56b0521e84b6e5955faecb6e6099c0

Re: Application usage statistics and targeted user surveys

2017-05-24 Thread Aleix Pol
On Tue, May 23, 2017 at 6:31 PM, Aleix Pol wrote: > On Sun, Apr 23, 2017 at 12:52 PM, Volker Krause wrote: >> Hi, >> >> we have talked about the above topics a couple of times in the past, from >> what >> I remember usually agreeing it would be nice to have

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

2017-05-24 Thread Ivan Shapovalov
intelfx added a comment. In https://phabricator.kde.org/D5802#109416, @mwolff wrote: > Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all. So, do you have any ideas? REPOSITORY R39 KTextEditor REVISION DETAIL