D8284: Don't duplicate connect to wl_display_flush

2017-10-13 Thread David Edmundson
davidedmundson created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY When using the QPA's wl_display, we don't need to also flush when the event dispatcher blocks, as

Re: Passing arguments to application when using KRun::runApplication

2017-10-13 Thread Nate Graham
Don't thank me, thank Kai; he wrote it! Nate On 10/13/2017 05:52 PM, Rodrigo Pelorosso wrote: That's amazing, thank you Nate! On Fri, Oct 13, 2017 at 10:35 PM, Nate Graham > wrote: You probably want KIO::highlightInFileManager(),

Re: Passing arguments to application when using KRun::runApplication

2017-10-13 Thread Rodrigo Pelorosso
That's amazing, thank you Nate! On Fri, Oct 13, 2017 at 10:35 PM, Nate Graham wrote: > You probably want KIO::highlightInFileManager(), which was made for > exactly this purpose. > > Nate > > > > On 10/13/2017 03:55 PM, Rodrigo Pelorosso wrote: > >> Hi! >> >> I have a

Re: Passing arguments to application when using KRun::runApplication

2017-10-13 Thread Nate Graham
You probably want KIO::highlightInFileManager(), which was made for exactly this purpose. Nate On 10/13/2017 03:55 PM, Rodrigo Pelorosso wrote: Hi! I have a KService that I've found using KMimeTypeTrader::self()->preferredService and let's say I know it's Dolphin. I'd like to run Dolphin

D8281: Allow to use IcoTool for Windows icons

2017-10-13 Thread Vincent Pinon
vpinon created this revision. vpinon added reviewers: dfaure, apol, kfunk. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY ECM to creating application icons asks for png2ico on Windows target.

Passing arguments to application when using KRun::runApplication

2017-10-13 Thread Rodrigo Pelorosso
Hi! I have a KService that I've found using KMimeTypeTrader::self()->preferredService and let's say I know it's Dolphin. I'd like to run Dolphin telling it to open a folder and select a file in particular. I know that from the command line I could do dolphin --select /home/silencer/lines.svg So

Re: Is there interest in participating in Google Code-in this year?

2017-10-13 Thread vijay krishnavanshi
Hi, Kopete has tasks that can be done by GCI candidates. Yes, people are busy. Other new members of KDE should take the initiatives for their projects and participate to mentor GCI students. It's a great way to get potential enthusiastic contributors for your projects. It takes effort to be

D7736: Not-to-be-merged review of Python bindings generator

2017-10-13 Thread Jason Tibbitts
jasontibbitts added a comment. Thanks for the update; I'll follow the bindings list and work on getting cppyy into Fedora. Hopefully that will be relatively uncomplicated. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7736 To: shaheed, lbeltrame Cc:

D7736: Not-to-be-merged review of Python bindings generator

2017-10-13 Thread Shaheed Haque
shaheed added a comment. In https://phabricator.kde.org/D7736#154948, @jasontibbitts wrote: > I hate to add a ping without any useful review, but I'm quite interested in this effort as I have a pykde4-based application which I would really like to get ported to the modern frameworks.

D7736: Not-to-be-merged review of Python bindings generator

2017-10-13 Thread Jason Tibbitts
jasontibbitts added a comment. I hate to add a ping without any useful review, but I'm quite interested in this effort as I have a pykde4-based application which I would really like to get ported to the modern frameworks. Current distro packages of pykde4 are increasingly broken, and

D8243: Implement support for categories on KfilesPlacesView

2017-10-13 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 20675. renatoo added a comment. Updated unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=20674=20675 BRANCH model-hide-row REVISION DETAIL https://phabricator.kde.org/D8243 AFFECTED FILES

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-10-13 Thread Henrik Fehlauer
rkflx added subscribers: dfaure, rkflx. rkflx added a comment. Unfortunately, this two year old patch does not apply for me anymore to the current git master (while it did apply to v5.15.0, it would not compile then). In addition, I'm not convinced this should be changed at the

D8243: Implement support for categories on KfilesPlacesView

2017-10-13 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 20674. renatoo marked 8 inline comments as done. renatoo edited the summary of this revision. renatoo added a comment. updated comit summary renamed m_dragModeCount to m_dragStart refactory 'KFilePlacesItem::data' function REPOSITORY R241 KIO

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.7 - Build # 33 - Fixed!

2017-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.7/33/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 13 Oct 2017 10:43:31 + Build duration: 1 min 31 sec and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 52 - Still Unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/52/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Fri, 13 Oct 2017 10:30:37 + Build duration: 9 min 16 sec and counting JUnit Tests

KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Still unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.9/10/ Project: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 13 Oct 2017 10:12:43 + Build duration: 25 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 39 - Fixed!

2017-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/39/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 13 Oct 2017 10:09:47 + Build duration: 25 min and counting

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 3 - Fixed!

2017-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/3/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 Date of build: Fri, 13 Oct 2017 10:32:53 + Build duration: 1 min 11 sec and counting

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 119 - Still Unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/119/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Fri, 13 Oct 2017 10:09:47 + Build duration: 23 min and counting JUnit Tests Name: (root)

D8264: Fix build of breeze-icons on the Android CI

2017-10-13 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c0c4e4f46ae1: Fix build of breeze-icons on the Android CI (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8264?vs=20648=20671#toc REPOSITORY R266 Breeze Icons CHANGES

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 51 - Still Unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/51/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Fri, 13 Oct 2017 10:10:32 + Build duration: 20 min and counting JUnit Tests

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 - Build # 2 - Still Failing!

2017-10-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.9/2/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 Date of build: Fri, 13 Oct 2017 10:27:59 + Build duration: 39 sec and counting CONSOLE

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/51/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 13 Oct 2017 10:10:32 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 120 - Still unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/120/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 13 Oct 2017 10:09:47 + Build duration: 9 min 28 sec and counting JUnit Tests Name:

Re: Is there interest in participating in Google Code-in this year?

2017-10-13 Thread Kevin Funk
On Thursday, 12 October 2017 23:15:27 CEST Valorie Zimmerman wrote: > Hello folks, when I've written about GCi before this, I got few to no > replies. My feeling is that previous enthusiastic mentors are without > the energy and time to participate this year. Heya, I also feel that for KDevelop

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-10-13 Thread Ben Cooksley
bcooksley added a comment. You don't have to worry about Phabricator going away, we were on Reviewboard for quite a long time before we started to move away from it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8274 To: shlomif Cc: bcooksley, #frameworks

KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 - Build # 9 - Still unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.9/9/ Project: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 13 Oct 2017 09:15:35 + Build duration: 29 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 50 - Still Unstable!

2017-10-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/50/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Fri, 13 Oct 2017 09:31:01 + Build duration: 8 min 47 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 38 - Failure!

2017-10-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/38/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 13 Oct 2017 09:14:43 + Build duration: 23 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 50 - Failure!

2017-10-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/50/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 13 Oct 2017 09:31:01 + Build duration: 2 min 49 sec and counting CONSOLE OUTPUT

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-10-13 Thread Shlomi Fish
shlomif created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch copies the symlinked file's contents upon a copy - like /usr/bin/cp instead of creating a new symlink. This is an attempt to fix

D7369: Wayland foreign protocol

2017-10-13 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R127:ce2ff96c5756: Wayland foreign protocol (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7369?vs=20639=20667#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 37 - Aborted!

2017-10-13 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ java.io.IOException: remote file operation failed:

Re: Is there interest in participating in Google Code-in this year?

2017-10-13 Thread Timothée Giet
Hi, On GCompris side, we have some tasks and a few mentors. Not that much, but if there are more from other KDE projects we can participate. Timothée Le 13/10/2017 à 00:53, Valorie Zimmerman a écrit : > We don't need one mentor though, we need up to 50, and probably 400 > tasks by January. We

D8243: Implement support for categories on KfilesPlacesView

2017-10-13 Thread Kevin Ottens
ervin added a comment. A couple more changes needed. INLINE COMMENTS > kfileplacesitem.cpp:153-158 > +if (role == KFilePlacesModel::GroupRole) { > +return QVariant(m_groupName); > +} > > +QVariant returnData; > if (role != KFilePlacesModel::HiddenRole && role !=

Re: Latte Dock in review phase

2017-10-13 Thread Ben Cooksley
On Fri, Oct 13, 2017 at 11:12 AM, Albert Astals Cid wrote: > El dijous, 5 d’octubre de 2017, a les 0:00:01 CEST, Michail Vourlakos va > escriure: >> Hello everyone, >> >> we decided to make Latte an active kde project and so now it is in review >> phase. I believe the best place to

D8243: Implement support for categories on KfilesPlacesView

2017-10-13 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. You probably missed my comment on the previous iteration: "Note that the summary part of the commit is now wrong (it still refers to KCategorizedView). Also,

KDE CI: Frameworks kimageformats kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

2017-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20AndroidQt5.9/1/ Project: Frameworks kimageformats kf5-qt5 AndroidQt5.9 Date of build: Fri, 13 Oct 2017 08:36:41 + Build duration: 49 sec and counting

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

2017-10-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.9/1/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 Date of build: Fri, 13 Oct 2017 08:35:59 + Build duration: 31 sec and counting CONSOLE

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

2017-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.9/1/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.9 Date of build: Fri, 13 Oct 2017 08:28:02 + Build duration: 3 min 32 sec and counting

Re: Commit Notifications

2017-10-13 Thread Ben Cooksley
On Fri, Oct 13, 2017 at 10:24 AM, Allen Winter wrote: > I still get email notifications on commits to a few repos. Hi Allen, > > How do I unsubscribe from the ones I no longer care about? > How do I subscribe to new repos I'm currently interested in? The legacy subscriptions

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

2017-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.9/1/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.9 Date of build: Fri, 13 Oct 2017 08:25:20 + Build duration: 1 min 12 sec and counting

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-10-13 Thread Anthony Fieroni
anthonyfieroni added a comment. > In https://phabricator.kde.org/D7446#154790, @ngraham wrote: > I'm not sure exactly what this is referring to. Can you clarify? https://api.kde.org/frameworks/kconfigwidgets/html/classKRecentFilesAction.html REPOSITORY R241 KIO REVISION DETAIL

D8243: Implement support for categories on KfilesPlacesView

2017-10-13 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > renatoo wrote in kfileplacesview.cpp:169 > Humm I did not know about this opt.index property. Did some debug here and > it is always -1 . > > Sorry but I am not sure why should I care about opt.index? Checking the > "index" arg is not